[PATCH] sutils: add random device targets to MAKEDEV

2014-06-16 Thread David Michael
* sutils/MAKEDEV.sh (random,urandom): New targets. (std): Add random and urandom to the standard devices list. --- Hi, With the random merge, can /dev/(u)random devices now be added to MAKEDEV? (I'm not married to the seed file argument, in case there is a better default location for it.) Thank

[PATCH] Add mach_debug defs rules

2014-06-16 Thread David Michael
* Makeconf (mach_debug_defs_names,mach_debug_defs): New variables. * Makeconf: Add rule to generate local $(mach_debug_defs) files. * procfs/Makefile: Remove vpath for mach_debug defs. --- Hi, The hard-coded /usr/include vpath will break building with sysroot headers. Can the mach_debug defs fil

[PATCH 5/5] libdiskfs: add permission check to file_chflags

2014-06-16 Thread Justus Winter
Only root is allowed to change the high 16 bits. The TODO entry says otherwise, but that must be a mistake. For reference, see the glibc sources, sysdeps/mach/hurd/bits/stat.h. * libdiskfs/file-chflags.c (diskfs_S_file_chflags): Add permission check. * TODO (libdiskfs): Remove entry. --- TODO

[PATCH 3/5] trans/fakeroot: fix error handling

2014-06-16 Thread Justus Winter
Found using the Clang Static Analyzer. * trans/fakeroot.c (new_node): Do not leak a pointer to freed memory. Store NULL at *np instead. This fixes a node use-after-free in netfs_S_dir_lookup. --- trans/fakeroot.c | 1 + 1 file changed, 1 insertion(+) diff --git a/trans/fakeroot.c b/trans/fakero

[PATCH 4/5] libports: avoid realloc(3) corner case

2014-06-16 Thread Justus Winter
If the size argument is 0, realloc may either return NULL, or return a pointer that is only valid for use with free(3). In either case, the memory is freed. So if realloc would return NULL (it does not on GNU), the current code would double free p. Found using the Clang Static Analyzer. * libpo

[PATCH 1/5] ftpfs: fix error handling in refresh_dir

2014-06-16 Thread Justus Winter
Found using the Clang Static Analyzer. * ftpfs/dir.c (refresh_dir): Fix error handling. --- ftpfs/dir.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/ftpfs/dir.c b/ftpfs/dir.c index da5ddbe..a9fea22 100644 --- a/ftpfs/dir.c +++ b/ftpfs/dir.c @@ -384,14

[PATCH 2/5] libshouldbeinlibc: fix dead initialization in fmt_named_interval

2014-06-16 Thread Justus Winter
Found using the Clang Static Analyzer. * libshouldbeinlibc/timefmt.c (fmt_named_interval): Fix dead initialization. --- libshouldbeinlibc/timefmt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libshouldbeinlibc/timefmt.c b/libshouldbeinlibc/timefmt.c index a28f58b..cef72e0

Re: [PATCH] utils/mount: canonicalize mountpoints

2014-06-16 Thread Justus Winter
Quoting Gabriele Giacone (2014-06-16 00:25:53) > On Sun, Jun 15, 2014 at 5:41 PM, Justus Winter > <4win...@informatik.uni-hamburg.de> wrote: > > Quoting Gabriele Giacone (2014-06-15 12:56:13) > >> >> Such hunks are workarounds at the moment because hurd mounts paths by > >> >> keeping superfluous '