Re: [PATCH] libmachdev: fix net_rcv_msg-messages

2014-06-11 Thread Ivan Shmakov
> Justus Winter <4win...@informatik.uni-hamburg.de> writes: […] > @@ -243,8 +243,10 @@ netif_rx_handle (char *data, int len, struct net_device > *dev) >pack_size = len - sizeof (struct ethhdr); >/* remember message sizes must be rounded up */ > - net_msg->msg_hdr.msgh_size = (

Re: Please merge the random translator into the Hurd repository

2014-06-11 Thread Ivan Shmakov
> Thomas Schwinge writes: > On Mon, 09 Jun 2014 12:17:31 +0200, Justus Winter wrote: […] >> I prepared this for your consideration here: >> http://darnassus.sceen.net/gitweb/teythoon/hurd.git/shortlog/refs/heads/merge-random > That looks reasonable. I would have done the subdirecto

Re: Doc Writer for GNU Hurd for The GNU Hurd

2014-06-11 Thread Thomas Schwinge
Hi Namensvetter! ;-) On Tue, 10 Jun 2014 21:28:41 +0200, Thomas Knopp wrote: > on the savannah site I see, you look for a doc writer for The GNU Hurd. > If is this "job" up to date - then I am interesting in helping with the > latter ;). Great, and thanks for your interest! And yes, there's st

Re: [PATCH 2/4] hurd: fix receiver lookup in termctty_open_terminal

2014-06-11 Thread Samuel Thibault
Justus Winter, le Wed 11 Jun 2014 13:41:08 +0200, a écrit : > * hurd/hurd_types.h (ctty_t): New type definition. > * hurd/term.defs (ctty_t): New type definition. > * term/mig-decls.h: New file. > * term/mig-mutate.h: Add mutators, includes. > * term/term.h: Add include guards. > * term/users.c (S_

Re: [PATCH 1/4] term: improve the demuxer

2014-06-11 Thread Samuel Thibault
Justus Winter, le Wed 11 Jun 2014 13:41:07 +0200, a écrit : > Handle multiple request types as recommended by the Mach Server > Writer's Guide section 4, subsection "Handling Multiple Request > Types". This avoids initializing the reply message in every X_server > function. > > * term/main.c (dem

[PATCH 3/4] libdiskfs: add permission check to file_chflags

2014-06-11 Thread Justus Winter
Only root is allowed to change the high 16 bits. The TODO entry says otherwise, but that must be a mistake. For reference, see the glibc sources, sysdeps/mach/hurd/bits/stat.h. * libdiskfs/file-chflags.c (diskfs_S_file_chflags): Add permission check. * TODO (libdiskfs): Remove entry. --- TODO

[PATCH 4/4] utils/settrans: implement settrans --start

2014-06-11 Thread Justus Winter
Start the translator specified by the NODE's passive translator record and set it as NODE's active translator. This is the equivalent of doing: % settrans --active /node $(showtrans /node) * utils/settrans.c (argp_option): Add --start. (parse_opt): Handle --start. (main): Retrieve the passive tr

[PATCH 1/4] term: improve the demuxer

2014-06-11 Thread Justus Winter
Handle multiple request types as recommended by the Mach Server Writer's Guide section 4, subsection "Handling Multiple Request Types". This avoids initializing the reply message in every X_server function. * term/main.c (demuxer): Improve the demuxer function. --- term/main.c | 24 +

[PATCH 2/4] hurd: fix receiver lookup in termctty_open_terminal

2014-06-11 Thread Justus Winter
* hurd/hurd_types.h (ctty_t): New type definition. * hurd/term.defs (ctty_t): New type definition. * term/mig-decls.h: New file. * term/mig-mutate.h: Add mutators, includes. * term/term.h: Add include guards. * term/users.c (S_termctty_open_terminal): Fix receiver lookup. * boot/boot.c (S_termctty_

Re: [PATCH 6/6] doc: explain the floating point flag in kdb output

2014-06-11 Thread Samuel Thibault
Justus Winter, le Mon 09 Jun 2014 18:38:35 +0200, a écrit : > * doc/mach.texi (Kernel Debugger Commands): Explain the floating point > flag. Ack. > --- > doc/mach.texi | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/doc/mach.texi b/doc/mach.texi > index 49c0d67..2d

Re: [PATCH 5/6] i386: remap some keys

2014-06-11 Thread Samuel Thibault
Justus Winter, le Mon 09 Jun 2014 18:38:34 +0200, a écrit : > As a convenience for the nice people using our debugger, remap some > keys to the readline-like shortcuts supported by dde. > > * i386/i386at/kd.c (kdcnmaygetc): Remap some keys. Ack. > --- > i386/i386at/kd.c | 33 +++

Re: [PATCH 4/6] i386: reformat the key map

2014-06-11 Thread Samuel Thibault
Justus Winter, le Mon 09 Jun 2014 18:38:33 +0200, a écrit : > * i386/i386at/kd.c (key_map): Remove superfluous newlines so that > every entry fits into one line. This way line numbers can be used as > an index into the map. Ack. > --- > i386/i386at/kd.c | 27 +-- > 1 fil

Re: [PATCH 2/6] ddb: print task names if available

2014-06-11 Thread Samuel Thibault
Justus Winter, le Mon 09 Jun 2014 18:38:31 +0200, a écrit : > * ddb/db_print.c (db_print_task): Print task name if available. > * i386/i386/db_interface.c (db_task_name): Likewise. Ack. You can also drop the DB_GNUMACH_TASK_NAME definition, which is not used any more then. > --- > ddb/db_print.

Re: [PATCH 3/6] ddb: use db_thread_stat to format the flags

2014-06-11 Thread Samuel Thibault
Justus Winter, le Mon 09 Jun 2014 18:38:32 +0200, a écrit : > * ddb/db_print.c (db_print_thread): Use db_thread_stat to format the > flags. Ack. > --- > ddb/db_print.c | 8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/ddb/db_print.c b/ddb/db_print.c > index 1cbff6

Re: [PATCH 1/6] kern: set the name of the kernel task to 'gnumach'

2014-06-11 Thread Samuel Thibault
Justus Winter, le Mon 09 Jun 2014 18:38:30 +0200, a écrit : > * kern/taks.c (task_init): Set the name of the kernel task to 'gnumach'. Ack. > --- > kern/task.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/kern/task.c b/kern/task.c > index 66eb25c..20acc6a 100644 > --- a/kern/task.c

Re: [PATCH] libmachdev: fix net_rcv_msg-messages

2014-06-11 Thread Samuel Thibault
Justus Winter, le Tue 10 Jun 2014 11:47:00 +0200, a écrit : > Previously, all net_rcv_msg-messages sent by netif_rx_handle were > malformed. It never was a problem in practice, since the messages are > not complex and thus the kernel does not try to parse the message. > > struct net_rcv_msg conta

Re: [PATCH] device: fix net_rcv_messages

2014-06-11 Thread Samuel Thibault
Justus Winter, le Sun 08 Jun 2014 11:48:33 +0200, a écrit : > Previously, all net_rcv_messages sent by net_deliver were malformed. > It never was a problem in practice, since the messages are not complex > and thus the kernel does not try to parse the message. > > struct net_rcv_messages contains