Re: [PATCH 7/9] ext2fs: use size_t where appropriate

2014-06-06 Thread Samuel Thibault
Justus Winter, le Fri 06 Jun 2014 16:42:16 +0200, a écrit : > * extfs/dir.c: Use size_t where appropriate. Ack. > --- > ext2fs/dir.c | 22 +++--- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/ext2fs/dir.c b/ext2fs/dir.c > index 0597500..1f7c7ed 100644 > --

Re: [PATCH 9/9] ext2fs: fix type of retry_dotdot

2014-06-06 Thread Samuel Thibault
Justus Winter, le Fri 06 Jun 2014 16:42:18 +0200, a écrit : > * ext2fs/dir.c (diskfs_lookup_hard): Use ino_t for retry_dotdot. Ack. > --- > ext2fs/dir.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ext2fs/dir.c b/ext2fs/dir.c > index ad55681..46a22a1 100644 > --- a/e

Re: [PATCH 8/9] ext2fs: fix type of blockaddr

2014-06-06 Thread Samuel Thibault
Justus Winter, le Fri 06 Jun 2014 16:42:17 +0200, a écrit : > * ext2fs/dir.c (diskfs_lookup_hard): Use vm_address_t for blockaddr. Ack. > --- > ext2fs/dir.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ext2fs/dir.c b/ext2fs/dir.c > index 1f7c7ed..ad55681 100644 > ---

Re: [PATCH 6/9] ext2fs: use correct type for disk offsets

2014-06-06 Thread Samuel Thibault
Justus Winter, le Fri 06 Jun 2014 16:42:15 +0200, a écrit : > * ext2fs/dir.c (count_dirents): Use off_t for nb. > (diskfs_get_directs): Likewise for blkno, nblks. Well, it's not actually an offset, but a block number, so it would probably be a block_t actually? > --- > ext2fs/dir.c | 6 +++--- >

Re: [PATCH 5/9] ext2fs: fix compiler warning

2014-06-06 Thread Samuel Thibault
Justus Winter, le Fri 06 Jun 2014 16:42:14 +0200, a écrit : > * ext2fs/pager.c (disk_cache_block_ref): block cannot be negative. Ack. > --- > ext2fs/pager.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ext2fs/pager.c b/ext2fs/pager.c > index ce5bc6d..39cf1c7 100644 >

Re: [PATCH 4/9] libdiskfs: avoid implicit integer conversion

2014-06-06 Thread Samuel Thibault
Justus Winter, le Fri 06 Jun 2014 16:42:13 +0200, a écrit : > * libdiskfs/boot-start.c (diskfs_boot_start): Avoid implicit integer > conversion. Ack. > --- > libdiskfs/boot-start.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/libdiskfs/boot-start.c b/libdiskfs/b

Re: [PATCH 3/9] libdiskfs: use correct type for disk offsets

2014-06-06 Thread Samuel Thibault
Justus Winter, le Fri 06 Jun 2014 16:42:12 +0200, a écrit : > * libdiskfs/diskfs.h (struct peropen): Use off_t for filepointer. Ack. > --- > libdiskfs/diskfs.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libdiskfs/diskfs.h b/libdiskfs/diskfs.h > index 2c68aa3..e3285

Re: [PATCH 2/9] hurd: fix type of optimal_transfer_size

2014-06-06 Thread Samuel Thibault
Justus Winter, le Fri 06 Jun 2014 16:42:11 +0200, a écrit : > * hurd/shared.h (struct shared_io): Use blksize_t for optimal_transfer_size. Ack. > --- > hurd/shared.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hurd/shared.h b/hurd/shared.h > index 6f13637..25747eb 1

Re: [PATCH 1/9] include: use unsigned literal in combination with binary not

2014-06-06 Thread Samuel Thibault
Justus Winter, le Fri 06 Jun 2014 16:42:10 +0200, a écrit : > * include/refcount.h (refcounts_promote): Use ~0U. > (refcounts_demote): Likewise. Ack. > --- > include/refcount.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/refcount.h b/include/refcount.h >

[PATCH 3/9] libdiskfs: use correct type for disk offsets

2014-06-06 Thread Justus Winter
* libdiskfs/diskfs.h (struct peropen): Use off_t for filepointer. --- libdiskfs/diskfs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libdiskfs/diskfs.h b/libdiskfs/diskfs.h index 2c68aa3..e328527 100644 --- a/libdiskfs/diskfs.h +++ b/libdiskfs/diskfs.h @@ -56,7 +56,7 @@ str

[PATCH 9/9] ext2fs: fix type of retry_dotdot

2014-06-06 Thread Justus Winter
* ext2fs/dir.c (diskfs_lookup_hard): Use ino_t for retry_dotdot. --- ext2fs/dir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ext2fs/dir.c b/ext2fs/dir.c index ad55681..46a22a1 100644 --- a/ext2fs/dir.c +++ b/ext2fs/dir.c @@ -140,7 +140,7 @@ diskfs_lookup_hard (struct node

[PATCH 7/9] ext2fs: use size_t where appropriate

2014-06-06 Thread Justus Winter
* extfs/dir.c: Use size_t where appropriate. --- ext2fs/dir.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/ext2fs/dir.c b/ext2fs/dir.c index 0597500..1f7c7ed 100644 --- a/ext2fs/dir.c +++ b/ext2fs/dir.c @@ -99,7 +99,7 @@ diskfs_null_dirstat (struct d

[PATCH 6/9] ext2fs: use correct type for disk offsets

2014-06-06 Thread Justus Winter
* ext2fs/dir.c (count_dirents): Use off_t for nb. (diskfs_get_directs): Likewise for blkno, nblks. --- ext2fs/dir.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ext2fs/dir.c b/ext2fs/dir.c index a7eeaaa..0597500 100644 --- a/ext2fs/dir.c +++ b/ext2fs/dir.c @@ -823,7 +8

[PATCH 1/9] include: use unsigned literal in combination with binary not

2014-06-06 Thread Justus Winter
* include/refcount.h (refcounts_promote): Use ~0U. (refcounts_demote): Likewise. --- include/refcount.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/refcount.h b/include/refcount.h index 5c3302d..785b052 100644 --- a/include/refcount.h +++ b/include/refcount.h @@

[PATCH 2/9] hurd: fix type of optimal_transfer_size

2014-06-06 Thread Justus Winter
* hurd/shared.h (struct shared_io): Use blksize_t for optimal_transfer_size. --- hurd/shared.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hurd/shared.h b/hurd/shared.h index 6f13637..25747eb 100644 --- a/hurd/shared.h +++ b/hurd/shared.h @@ -66,7 +66,7 @@ struct shared_io

[PATCH 4/9] libdiskfs: avoid implicit integer conversion

2014-06-06 Thread Justus Winter
* libdiskfs/boot-start.c (diskfs_boot_start): Avoid implicit integer conversion. --- libdiskfs/boot-start.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libdiskfs/boot-start.c b/libdiskfs/boot-start.c index a60a1d0..4cc7bb8 100644 --- a/libdiskfs/boot-start.c +++ b/libd

[PATCH 5/9] ext2fs: fix compiler warning

2014-06-06 Thread Justus Winter
* ext2fs/pager.c (disk_cache_block_ref): block cannot be negative. --- ext2fs/pager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ext2fs/pager.c b/ext2fs/pager.c index ce5bc6d..39cf1c7 100644 --- a/ext2fs/pager.c +++ b/ext2fs/pager.c @@ -957,7 +957,7 @@ disk_cache_block_ref

[PATCH 8/9] ext2fs: fix type of blockaddr

2014-06-06 Thread Justus Winter
* ext2fs/dir.c (diskfs_lookup_hard): Use vm_address_t for blockaddr. --- ext2fs/dir.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ext2fs/dir.c b/ext2fs/dir.c index 1f7c7ed..ad55681 100644 --- a/ext2fs/dir.c +++ b/ext2fs/dir.c @@ -146,7 +146,7 @@ diskfs_lookup_hard (struct n