Re: [PATCH 3/6] ext2fs: use a seperate lock to protect nodehash

Quoting Samuel Thibault (2014-06-02 03:41:55) > Justus Winter, le Sun 01 Jun 2014 22:03:01 +0200, a écrit : > > @@ -46,8 +46,18 @@ > > #define INOHASH(ino)(((unsigned)(ino))%INOHSZ) > > #endif > > > > +/* The nodehash is a cache of nodes. > > + > > + Access to nodehash and nodehash_n

Re: [PATCH 3/6] ext2fs: use a seperate lock to protect nodehash

Justus Winter, le Sun 01 Jun 2014 22:03:01 +0200, a écrit : > @@ -46,8 +46,18 @@ > #define INOHASH(ino)(((unsigned)(ino))%INOHSZ) > #endif > > +/* The nodehash is a cache of nodes. > + > + Access to nodehash and nodehash_nr_items is protected by > + nodecache_lock. > + > + Every

Re: [PATCH 2/6] libnetfs: fix memory leak

Justus Winter, le Sun 01 Jun 2014 22:03:00 +0200, a écrit : > * libnetfs/trans-callback.c (_netfs_translator_callback2_fn): Free > user if creating the protid failed. Ack. > --- > libnetfs/trans-callback.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/libnetfs/tra

Re: [PATCH 1/6] tmpfs: use a thread timeout

Justus Winter, le Sun 01 Jun 2014 22:02:59 +0200, a écrit : > There is no need to keep all the threads around, just the master > thread. Ack. > * tmpfs/tmpfs (diskfs_thread_function): Use a thread timeout. > --- > tmpfs/tmpfs.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff

Re: GSOC - valgrind-hurd queries

Subhashish, le Mon 02 Jun 2014 04:31:02 +0530, a écrit : > In case of > > #elif defined(VGO_gnu) >vg_assert(0); > > I'm now changing it to > > > #elif defined(VGO_gnu) >SysRes res; >vg_assert(0); > > for the 'return res;' at the end of the modified functions are coming > back to ha

Re: GSOC - valgrind-hurd queries

On Thursday 29 May 2014 05:36 AM, Samuel Thibault wrote: > Subhashish, le Thu 29 May 2014 04:57:55 +0530, a écrit : >> This makelog[1] indicates that I should #include "vki/vki-gnu.h"[2]. >> >> Now this vki-gnu.h is supposed to be the gnu/hurd specific kernel interface . . . > One thing you need

[PATCH 2/6] libnetfs: fix memory leak

* libnetfs/trans-callback.c (_netfs_translator_callback2_fn): Free user if creating the protid failed. --- libnetfs/trans-callback.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libnetfs/trans-callback.c b/libnetfs/trans-callback.c index 4dec162..f4f0c62 100644 --- a/lib

[PATCH 6/6] tmpfs: use a seperate lock to protect all_nodes

Previously, tmpfs used diskfs_node_refcnt_lock to serialize access to the all_nodes and some other related global state related to memory consumption. Use a separate lock to protect all_nodes, and atomic operations to access the state related to memory consumption. Adjust the reference counting ac

[PATCH 5/6] isofs: use a seperate lock to protect node_cache

Previously, isofs used diskfs_node_refcnt_lock to serialize access to the node_cache. Use a separate lock to protect node_cache. Adjust the reference counting accordingly. Every node in the node_cache carries a light reference. When we are asked to give up that light reference, we reacquire our

[PATCH 3/6] ext2fs: use a seperate lock to protect nodehash

Previously, ext2fs used diskfs_node_refcnt_lock to serialize access to the nodehash. Use a separate lock to protect nodehash. Adjust the reference counting accordingly. Every node in the nodehash carries a light reference. When we are asked to give up that light reference, we reacquire our lock

[PATCH 1/6] tmpfs: use a thread timeout

There is no need to keep all the threads around, just the master thread. * tmpfs/tmpfs (diskfs_thread_function): Use a thread timeout. --- tmpfs/tmpfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tmpfs/tmpfs.c b/tmpfs/tmpfs.c index a45d343..718c6d8 100644 --- a/tmpfs/tm

[PATCH 4/6] fatfs: use a seperate lock to protect nodehash

Previously, fatfs used diskfs_node_refcnt_lock to serialize access to the nodehash. Use a separate lock to protect nodehash. Adjust the reference counting accordingly. Every node in the nodehash carries a light reference. When we are asked to give up that light reference, we reacquire our lock

Re: GSOC - valgrind-hurd queries

Subhashish, le Sun 01 Jun 2014 18:26:25 +0530, a écrit : > I'm sure this using of system headers is not the way, but it can be easily > swapped out when the redefining-from-scratch implementation is ready. I'm > going with the darwin one now for that seems quick. I'll work on the other > implementa

Re: GSOC - valgrind-hurd queries

On Saturday 31 May 2014 06:32 AM, Samuel Thibault wrote: Subhashish, le Sat 31 May 2014 06:23:39 +0530, a écrit : Now since I've #include-ed "i386-gnu/bits/resource.h", do I need to #define the RLIMIT_* symbols with VKI_ prefixes? vki-linux.h doesn't but darwin's does. vki-linux does, in the