Re: [PATCH 7/7] libtrivfs: lock-less reference counting for trivfs_peropen objects

Justus Winter, le Mon 26 May 2014 13:19:19 +0200, a écrit : > * libtrivfs/trivfs.h (struct trivfs_peropen): Use refcount_t for field > refcnt. > (struct trivfs_control): Remove unused field lock. > * libtrivfs/cntl-create.c (trivfs_create_control): Drop the mutex > initialization. > * libtrivfs/io-

Re: [PATCH 6/7] libihash: do not use an integer hash function by default

Justus Winter, le Mon 26 May 2014 13:19:18 +0200, a écrit : > Do not use the integer hash function on the keys by default. Ack.

Re: [PATCH 5/7] libdiskfs: fix node leak in the name cache

Justus Winter, le Mon 26 May 2014 13:19:17 +0200, a écrit : > * libdiskfs/name-cache.c (diskfs_check_lookup_cache): Release node > reference in a special case of lookup failure. Ack. > --- > libdiskfs/name-cache.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libdiskfs/name-cache.c b

Re: [PATCH 4/7] trans/mtab: fix initialization

Justus Winter, le Mon 26 May 2014 13:19:16 +0200, a écrit : > * trans/mtab.c (main): Fix initialization of mtab in one-shot mode. Ack. > --- > trans/mtab.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/trans/mtab.c b/trans/mtab.c > index 8c9f8d3..df03b1d 100644 > ---

Re: [PATCH 3/7] ext2fs: fix diskfs_pager_users

Justus Winter, le Mon 26 May 2014 13:19:15 +0200, a écrit : > This fixes a bug introduced in 86122789. > > * ext2fs/pager.c (diskfs_pager_users): We count file_pager_bucket, > which does not include the disk pagers. Fix condition accordingly. Apparently I missed it indeed. Ack. > --- > ext2fs

Re: [PATCH 2/7] libpager: drop unused fields from struct pager

Justus Winter, le Mon 26 May 2014 13:19:14 +0200, a écrit : > * libpager/priv.h (struct pager): Drop fields next, pprev. Ack. > --- > libpager/priv.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/libpager/priv.h b/libpager/priv.h > index d49cbb9..1f8405a 100644 > --- a/libpager/priv

Re: [PATCH 1/7] term: fix memory leak

Justus Winter, le Mon 26 May 2014 13:19:13 +0200, a écrit : > I tested this change for some days and have not experienced any > problems with it. Ack. > * term/users.c (pi_destroy_hook): Fix memory leak. > --- > term/users.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --

[PATCH 3/7] ext2fs: fix diskfs_pager_users

This fixes a bug introduced in 86122789. * ext2fs/pager.c (diskfs_pager_users): We count file_pager_bucket, which does not include the disk pagers. Fix condition accordingly. --- ext2fs/pager.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ext2fs/pager.c b/ext2fs/pager.c in

[PATCH 6/7] libihash: do not use an integer hash function by default

Recently libihash was changed to use an integer hash function on the keys in an attempt to reduce the rate of collisions (2d898893), which has long been assumed to be high. Richard Braun was kind enough to run some benchmarks. He observed: "1/ Using an extremely simple microbenchmark [1] that me

[PATCH 7/7] libtrivfs: lock-less reference counting for trivfs_peropen objects

* libtrivfs/trivfs.h (struct trivfs_peropen): Use refcount_t for field refcnt. (struct trivfs_control): Remove unused field lock. * libtrivfs/cntl-create.c (trivfs_create_control): Drop the mutex initialization. * libtrivfs/io-reauthenticate.c (trivfs_S_io_reauthenticate): Adjust accordingly. * lib

[PATCH 4/7] trans/mtab: fix initialization

* trans/mtab.c (main): Fix initialization of mtab in one-shot mode. --- trans/mtab.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/trans/mtab.c b/trans/mtab.c index 8c9f8d3..df03b1d 100644 --- a/trans/mtab.c +++ b/trans/mtab.c @@ -255,7 +255,7 @@ main (int argc, char *argv[])

[PATCH 1/7] term: fix memory leak

I tested this change for some days and have not experienced any problems with it. * term/users.c (pi_destroy_hook): Fix memory leak. --- term/users.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/term/users.c b/term/users.c index 97bc22c..9bd51d0 100644 --- a/term/users.c

[PATCH 5/7] libdiskfs: fix node leak in the name cache

* libdiskfs/name-cache.c (diskfs_check_lookup_cache): Release node reference in a special case of lookup failure. --- libdiskfs/name-cache.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libdiskfs/name-cache.c b/libdiskfs/name-cache.c index c113692..a212a6d 100644 --- a/libdiskfs/name-cache.

[PATCH 2/7] libpager: drop unused fields from struct pager

* libpager/priv.h (struct pager): Drop fields next, pprev. --- libpager/priv.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/libpager/priv.h b/libpager/priv.h index d49cbb9..1f8405a 100644 --- a/libpager/priv.h +++ b/libpager/priv.h @@ -59,8 +59,6 @@ struct pager int noterm;