Re: [PATCH 3/4] trans/fakeroot: use C99-style struct initialization

2014-05-16 Thread Samuel Thibault
Justus Winter, le Fri 16 May 2014 18:56:26 +0200, a écrit : > * trans/fakeroot.c (main): Use C99-style struct initialization to > initialize argp. This avoids a warning about missing field > initializers. Ack. > --- > trans/fakeroot.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [PATCH 4/4] proc: move translation functions to mig-decls.h

2014-05-16 Thread Samuel Thibault
Justus Winter, le Fri 16 May 2014 18:56:27 +0200, a écrit : > * proc/hash.c (reqport_find): Move this function... > * proc/proc.h (process_drop): ... and this... > * proc/mig-decls.h: ... here and rename them. > * proc/mig-mutate.h: Update accordingly. Ack. > --- > proc/hash.c | 11 ---

Re: [PATCH 2/4] trans/fakeroot: fix comparison between signed and unsigned

2014-05-16 Thread Samuel Thibault
Justus Winter, le Fri 16 May 2014 18:56:25 +0200, a écrit : > * trans/fakeroot.c (netfs_attempt_chown): Fix comparison between > signed and unsigned integer expressions. Ack. > --- > trans/fakeroot.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/trans/fakeroot.c b

Re: [PATCH 1/4] trans/fakeroot: remove spurious semicolon

2014-05-16 Thread Samuel Thibault
Justus Winter, le Fri 16 May 2014 18:56:24 +0200, a écrit : > A spurious semicolon caused a control flow bug in check_openmodes, > leading to a port leak. Ack > * trans/fakeroot.c (check_openmodes): Remove spurious semicolon. > --- > trans/fakeroot.c | 2 +- > 1 file changed, 1 insertion(+), 1 d

[PATCH 2/4] trans/fakeroot: fix comparison between signed and unsigned

2014-05-16 Thread Justus Winter
* trans/fakeroot.c (netfs_attempt_chown): Fix comparison between signed and unsigned integer expressions. --- trans/fakeroot.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/trans/fakeroot.c b/trans/fakeroot.c index 0ea3cbf..3107e29 100644 --- a/trans/fakeroot.c +++ b/tran

[PATCH 4/4] proc: move translation functions to mig-decls.h

2014-05-16 Thread Justus Winter
* proc/hash.c (reqport_find): Move this function... * proc/proc.h (process_drop): ... and this... * proc/mig-decls.h: ... here and rename them. * proc/mig-mutate.h: Update accordingly. --- proc/hash.c | 11 --- proc/mig-decls.h | 18 ++ proc/mig-mutate.h | 6 +++---

[PATCH 3/4] trans/fakeroot: use C99-style struct initialization

2014-05-16 Thread Justus Winter
* trans/fakeroot.c (main): Use C99-style struct initialization to initialize argp. This avoids a warning about missing field initializers. --- trans/fakeroot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/trans/fakeroot.c b/trans/fakeroot.c index 3107e29..c4b95de 100644 ---

[PATCH 1/4] trans/fakeroot: remove spurious semicolon

2014-05-16 Thread Justus Winter
A spurious semicolon caused a control flow bug in check_openmodes, leading to a port leak. * trans/fakeroot.c (check_openmodes): Remove spurious semicolon. --- trans/fakeroot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/trans/fakeroot.c b/trans/fakeroot.c index 987af24..0

Re: patch8.diff updated Was: Re: GCC's -fsplit-stack disturbing Mach's vm_allocate

2014-05-16 Thread Svante Signell
On Fri, 2014-05-16 at 06:20 -0700, Ian Lance Taylor wrote: > On Fri, May 16, 2014 at 1:03 AM, Svante Signell > wrote: > > > > For that part of the patch without it the build on GNU/Hurd fails. On > > the other hand SYS_FCNTL is not defined for e.g. GNU/Linux either. This > > is used in gcc-4.9-4.9

Re: patch8.diff updated Was: Re: GCC's -fsplit-stack disturbing Mach's vm_allocate

2014-05-16 Thread Svante Signell
On Wed, 2014-05-07 at 10:18 +0200, Svante Signell wrote: > On Tue, 2014-05-06 at 15:26 +0200, Samuel Thibault wrote: Attached is an updated patch8.diff. Arch specific code to src/libgo/mksysinfo.sh has been added, now other systems are not affected by the patch except the SYS_FCNTL part. For that