Re: [PATCH 1/2] utils: escape arguments in fakeroot.sh

2014-02-24 Thread Samuel Thibault
That's better indeed, thanks! Samuel

Re: [PATCHv2,HURD] Add fork hooks for pthread_atfork

2014-02-24 Thread Samuel Thibault
Hello, Roland McGrath, le Fri 20 Dec 2013 13:05:42 -0800, a écrit : > The linker is supposed to define those symbols automagically. > Did it break? We have been having “ checking for sufficient default -shared layout... no ” at least since 2.17, yes. (I don't have logs between 2.13 and 2.17)

Re: [PATCH 3/3] libdiskfs: fix receiver lookups in fsys server functions

2014-02-24 Thread Samuel Thibault
Justus Winter, le Wed 12 Feb 2014 18:22:26 +0100, a écrit : > * libdiskfs/diskfs.h (struct diskfs_control): New declaration. > (diskfs_begin_using_control_port): New declaration and function. > (diskfs_end_using_control_port): Likewise. > * libdiskfs/fsmutations.h: Add translation functions. > * li

Re: [PATCH 2/3] libnetfs: fix receiver lookups in fsys server functions

2014-02-24 Thread Samuel Thibault
Justus Winter, le Wed 12 Feb 2014 18:22:25 +0100, a écrit : > * mutations.h: Add translation functions. > * netfs.h (struct netfs_control): New declaration. > * priv.h: Define translation functions. > * fsys-get-options.c: Fix receiver lookups. > * fsys-getroot.c: Likewise. > * fsys-goaway.c: Likew

Re: [PATCH 6/6] New RPCs, fix build

2014-02-24 Thread Samuel Thibault
Ack Justus Winter, le Tue 11 Feb 2014 17:13:12 +0100, a écrit : > --- > trans/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/trans/Makefile b/trans/Makefile > index c0386d0..90df479 100644 > --- a/trans/Makefile > +++ b/trans/Makefile > @@ -56,7 +56,7 @@ magic:

Re: [PATCH 5/6] trans/mtab: do not map unknown source strings to "none"

2014-02-24 Thread Samuel Thibault
Justus Winter, le Tue 11 Feb 2014 17:13:11 +0100, a écrit : > Previously, map_device_to_path mapped unknown device strings to > "none". Return a copy of the original source string instead so that > e.g. nfs mount point points are properly handled. Ack > * trans/mtab.c (map_device_to_path): Do no

Re: [PATCH 2/6] nfs: implement netfs_get_source

2014-02-24 Thread Samuel Thibault
Justus Winter, le Tue 11 Feb 2014 17:13:08 +0100, a écrit : > Implement netfs_get_source so that nfs translators show up in > /proc/mounts. > > * nfs/main.c (netfs_get_source): New function. Ack. > --- > nfs/main.c | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/nfs/ma

Re: [PATCH 4/6] tmpfs: set diskfs_disk_name to "none"

2014-02-24 Thread Samuel Thibault
Justus Winter, le Tue 11 Feb 2014 17:13:10 +0100, a écrit : > By default diskfs_disk_name is returned as the source of > libdiskfs-based translators. Hurds fstab allows multiple entries with > the mnt_fsname being "none". Ack. > * tmpfs/tmpfs.c (diskfs_disk_name): Set to "none". > --- > tmpfs/t

Re: [PATCH 3/6] trans/mtab: ignore translators that do not implement file_get_source

2014-02-24 Thread Samuel Thibault
Justus Winter, le Tue 11 Feb 2014 17:13:09 +0100, a écrit : > Previously, the mtab translator would guess the source of a filesystem > translator from its last argument. This made all kinds of > non-filesystem translators appear in /proc/mounts, causing severe > problems due to umount --all removi

Re: [PATCH 1/6] hurd: fix the get-children and get-source procedures

2014-02-24 Thread Samuel Thibault
Justus Winter, le Tue 11 Feb 2014 17:13:07 +0100, a écrit : > * hurd/fs.defs: Add file_get_children and file_get_source. > * hurd/fsys.defs: Remove fsys_get_children and fsys_get_source. > * libdiskfs/fsys-get-children.c: Rename and adapt accordingly. > * libdiskfs/fsys-get-source.c: Likewise. > *

Re: [PATCH 3/3] Find and link with -lmachuser -lhurduser

2014-02-24 Thread Samuel Thibault
Thomas Schwinge, le Sun 16 Feb 2014 08:49:13 +0100, a écrit : > > * configure.ac: Invoke AC_SEARCH_LIBS to search libmachuser and > > libhurduser. > > This should (currently) not be needed, for these two libraries are > (currently) considered to be part of libc. So, let's maybe settle dow

Re: [PATCH] kern: fix mig_strncpy

2014-02-24 Thread Samuel Thibault
Justus Winter, le Sat 22 Feb 2014 11:25:14 +0100, a écrit : > Previously, the function mig_strncpy would always zero-terminate the > destination string. Make mig_strncpy behave like mig_strncpy and > strncpy in the glibc. Also fix the implementation of mig_strncpy to > return the length of the wr

Re: [PATCH] Fix variable-sized c strings

2014-02-24 Thread Samuel Thibault
Justus Winter, le Fri 21 Feb 2014 23:12:03 +0100, a écrit : > Previously, the terminating zero of variable-sized c strings was only > included when copying the message if the length of the string was not > a multiple of four. mig_strncpy returns the length of the string > excluding the terminating

Re: [PATCH 5/5] mach-defpager: improve the default_pager_demux_object function

2014-02-24 Thread Samuel Thibault
Justus Winter, le Mon 24 Feb 2014 15:41:56 +0100, a écrit : > Handle multiple request types as recommended by the Mach Server > Writer's Guide section 4, subsection "Handling Multiple Request > Types". This avoids initializing the reply message in every X_server > function. Ack. > > * mach-defp

Re: [PATCH 4/5] mach-defpager: add function mig_reply_setup

2014-02-24 Thread Samuel Thibault
Justus Winter, le Mon 24 Feb 2014 15:41:55 +0100, a écrit : > Currently, mig_reply_setup is not provided by libmachuser or the > glibc. Provide it locally. > > * mach-defpager/default_pager.c (mig_reply_setup): New function. Ack. > --- > mach-defpager/default_pager.c | 31 +

Re: [PATCH 3/5] mach-defpager: fix definition of seqnos_memory_object_data_unlock

2014-02-24 Thread Samuel Thibault
Justus Winter, le Mon 24 Feb 2014 15:41:54 +0100, a écrit : > * mach-defpager/default_pager.c (seqnos_memory_object_data_unlock): > Fix function arguments. Ack. > --- > mach-defpager/default_pager.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/mach-defpager/def

Re: [PATCH 2/5] libpager: improve the pager_demuxer function

2014-02-24 Thread Samuel Thibault
Justus Winter, le Mon 24 Feb 2014 15:41:53 +0100, a écrit : > Handle multiple request types as recommended by the Mach Server > Writer's Guide section 4, subsection "Handling Multiple Request > Types". This avoids initializing the reply message in every X_server > function. The reply message has

Re: [PATCH 1/5] utils/umount: do not remove passive translator records

2014-02-24 Thread Samuel Thibault
Justus Winter, le Mon 24 Feb 2014 15:41:52 +0100, a écrit : > Passive translator records are a Hurd concept. Therefore, the umount > compatibility program should not remove them. > > * utils/umount.c (passive_flags): Unset FS_TRANS_SET. > (doc): Adjust accordingly. Ack. > --- > utils/umount.c

Re: [PATCH 2/5] libpager: improve the pager_demuxer function

2014-02-24 Thread Gabriele Giacone
> --- a/libpager/demuxer.c > +++ b/libpager/demuxer.c > @@ -19,22 +19,25 @@ > #include "memory_object_S.h" > #include "notify_S.h" > > +#include "memory_object_S.h" > +#include "notify_S.h" Dups -- G..e

[PATCH 4/5] mach-defpager: add function mig_reply_setup

2014-02-24 Thread Justus Winter
Currently, mig_reply_setup is not provided by libmachuser or the glibc. Provide it locally. * mach-defpager/default_pager.c (mig_reply_setup): New function. --- mach-defpager/default_pager.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/mach-defpager/defaul

[PATCH 5/5] mach-defpager: improve the default_pager_demux_object function

2014-02-24 Thread Justus Winter
Handle multiple request types as recommended by the Mach Server Writer's Guide section 4, subsection "Handling Multiple Request Types". This avoids initializing the reply message in every X_server function. * mach-defpager/default_pager.c (default_pager_demux_object): Improve the demuxer function

[PATCH 2/5] libpager: improve the pager_demuxer function

2014-02-24 Thread Justus Winter
Handle multiple request types as recommended by the Mach Server Writer's Guide section 4, subsection "Handling Multiple Request Types". This avoids initializing the reply message in every X_server function. The reply message has already been properly initialized in libports, so there is no need t

[PATCH 3/5] mach-defpager: fix definition of seqnos_memory_object_data_unlock

2014-02-24 Thread Justus Winter
* mach-defpager/default_pager.c (seqnos_memory_object_data_unlock): Fix function arguments. --- mach-defpager/default_pager.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mach-defpager/default_pager.c b/mach-defpager/default_pager.c index 66b8587..4d604fe 100644 --- a/

[PATCH 1/5] utils/umount: do not remove passive translator records

2014-02-24 Thread Justus Winter
Passive translator records are a Hurd concept. Therefore, the umount compatibility program should not remove them. * utils/umount.c (passive_flags): Unset FS_TRANS_SET. (doc): Adjust accordingly. --- utils/umount.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/utils/umo

Re: [PATCH] Fix variable-sized c strings

2014-02-24 Thread Justus Winter
Quoting Samuel Thibault (2014-02-22 16:54:28) > Justus Winter, le Fri 21 Feb 2014 23:12:03 +0100, a écrit : > > Previously, the terminating zero of variable-sized c strings was only > > included when copying the message if the length of the string was not > > a multiple of four. mig_strncpy return

Re: [PATCH] kern: fix mig_strncpy

2014-02-24 Thread Justus Winter
Quoting Samuel Thibault (2014-02-22 16:53:11) > Justus Winter, le Sat 22 Feb 2014 16:17:13 +0100, a écrit : > > Quoting Samuel Thibault (2014-02-22 15:37:29) > > > Justus Winter, le Sat 22 Feb 2014 11:25:14 +0100, a écrit : > > > > * kern/ipc_mig.c (mig_strncpy): Do not zero-terminate the destinati