Re: [PATCH 1/8] kern: fix printing of kmem_cache names

2014-02-01 Thread Richard Braun
On Sun, Feb 02, 2014 at 12:11:59AM +0100, Samuel Thibault wrote: > Justus Winter, le Sat 01 Feb 2014 16:34:20 +0100, a écrit : > > I thought about doing that. But that would waste one character just > > for the termination. > > That's little compared to security :) > > GNU Machs printf implement

Re: [PATCH 1/8] kern: fix printing of kmem_cache names

2014-02-01 Thread Samuel Thibault
Justus Winter, le Sat 01 Feb 2014 16:34:20 +0100, a écrit : > Quoting Samuel Thibault (2014-02-01 15:20:55) > > Justus Winter, le Sat 01 Feb 2014 15:09:21 +0100, a écrit : > > > The name field is not necessarily zero-terminated. Use a precision > > > argument to limit the number of characters writ

Re: [PATCH 1/8] kern: fix printing of kmem_cache names

2014-02-01 Thread Justus Winter
Quoting Samuel Thibault (2014-02-01 15:20:55) > Justus Winter, le Sat 01 Feb 2014 15:09:21 +0100, a écrit : > > The name field is not necessarily zero-terminated. Use a precision > > argument to limit the number of characters written when printing the > > name. > > Mmm, I'd probably rather see th

Re: [PATCH 8/8] doc: document task_set_name

2014-02-01 Thread Samuel Thibault
Justus Winter, le Sat 01 Feb 2014 15:09:28 +0100, a écrit : > * doc/mach.texi (Task Information): Document the new task_set_name > procedure. Ack. > --- > doc/mach.texi | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/doc/mach.texi b/doc/mach.texi > index 9ad9e70..d089224 1

Re: [PATCH 6/8] kern: implement task_set_name

2014-02-01 Thread Samuel Thibault
Justus Winter, le Sat 01 Feb 2014 15:09:26 +0100, a écrit : > @@ -1071,6 +1072,21 @@ task_priority( > } > > /* > + * task_set_name > + * > + * Set the name of task TASK to NAME. This is a debugging aid. > + * NAME will be used in error messages printed by the kernel. > + */ > +kern_retur

Re: [PATCH 7/8] include: add task_set_name

2014-02-01 Thread Samuel Thibault
Justus Winter, le Sat 01 Feb 2014 15:09:27 +0100, a écrit : > task_set_name sets the name of a task. This is a debugging aid. The > name will be used in error messages printed by the kernel. Ack. > * include/mach/gnumach.defs (task_set_name): New procedure. > --- > include/mach/gnumach.defs |

Re: [PATCH 5/8] include: add a fixed-size string type for debugging purposes

2014-02-01 Thread Samuel Thibault
Justus Winter, le Sat 01 Feb 2014 15:09:25 +0100, a écrit : > * include/mach/debug.defs: New file. > * include/mach/debug.h: Likewise. Ack. > --- > include/mach_debug/mach_debug_types.defs | 2 ++ > include/mach_debug/mach_debug_types.h| 11 +++ > 2 files changed, 13 insertions(+) >

Re: [PATCH 4/8] ipc: use the name of the task for error messages

2014-02-01 Thread Samuel Thibault
Justus Winter, le Sat 01 Feb 2014 15:09:24 +0100, a écrit : > * ipc/mach_port.c (mach_port_destroy): Use the name of the task for > error messages. > (mach_port_deallocate): Likewise. Ack. > --- > ipc/mach_port.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/ipc/m

Re: [PATCH 3/8] kern: add a name field to struct task

2014-02-01 Thread Samuel Thibault
Justus Winter, le Sat 01 Feb 2014 15:09:23 +0100, a écrit : > * kern/task.c (task_create): Initialize name with the address of the task. > * kern/task.h (TASK_NAME_SIZE): New definition. > (struct task): Add field name. Ack. > --- > kern/task.c | 3 +++ > kern/task.h | 9 + > 2 files cha

Re: [PATCH 2/8] kern: add snprintf

2014-02-01 Thread Samuel Thibault
Justus Winter, le Sat 01 Feb 2014 15:09:22 +0100, a écrit : > * kern/printf.c (snprintf): New function. > * kern/printf.h (snprintf): New declaration. Ack. > --- > kern/printf.c | 10 ++ > kern/printf.h | 1 + > 2 files changed, 11 insertions(+) > > diff --git a/kern/printf.c b/kern/pr

Re: [PATCH 1/8] kern: fix printing of kmem_cache names

2014-02-01 Thread Samuel Thibault
Justus Winter, le Sat 01 Feb 2014 15:09:21 +0100, a écrit : > The name field is not necessarily zero-terminated. Use a precision > argument to limit the number of characters written when printing the > name. Mmm, I'd probably rather see the name field always be zero-terminated, since that's just

[PATCH 8/8] doc: document task_set_name

2014-02-01 Thread Justus Winter
* doc/mach.texi (Task Information): Document the new task_set_name procedure. --- doc/mach.texi | 11 +++ 1 file changed, 11 insertions(+) diff --git a/doc/mach.texi b/doc/mach.texi index 9ad9e70..d089224 100644 --- a/doc/mach.texi +++ b/doc/mach.texi @@ -5037,6 +5037,17 @@ total system r

[PATCH 6/8] kern: implement task_set_name

2014-02-01 Thread Justus Winter
task_set_name sets the name of a task. This is a debugging aid. The name will be used in error messages printed by the kernel. * kern/task.c (task_set_name): New function. * kern/task.h (task_set_name): New declaration. --- kern/task.c | 16 kern/task.h | 4 2 files chang

[PATCH 7/8] include: add task_set_name

2014-02-01 Thread Justus Winter
task_set_name sets the name of a task. This is a debugging aid. The name will be used in error messages printed by the kernel. * include/mach/gnumach.defs (task_set_name): New procedure. --- include/mach/gnumach.defs | 9 + 1 file changed, 9 insertions(+) diff --git a/include/mach/gnum

[PATCH 5/8] include: add a fixed-size string type for debugging purposes

2014-02-01 Thread Justus Winter
* include/mach/debug.defs: New file. * include/mach/debug.h: Likewise. --- include/mach_debug/mach_debug_types.defs | 2 ++ include/mach_debug/mach_debug_types.h| 11 +++ 2 files changed, 13 insertions(+) diff --git a/include/mach_debug/mach_debug_types.defs b/include/mach_debug/mac

[PATCH 4/8] ipc: use the name of the task for error messages

2014-02-01 Thread Justus Winter
* ipc/mach_port.c (mach_port_destroy): Use the name of the task for error messages. (mach_port_deallocate): Likewise. --- ipc/mach_port.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ipc/mach_port.c b/ipc/mach_port.c index fbc5e69..13572a1 100644 --- a/ipc/mach_port.c ++

[PATCH 3/8] kern: add a name field to struct task

2014-02-01 Thread Justus Winter
* kern/task.c (task_create): Initialize name with the address of the task. * kern/task.h (TASK_NAME_SIZE): New definition. (struct task): Add field name. --- kern/task.c | 3 +++ kern/task.h | 9 + 2 files changed, 12 insertions(+) diff --git a/kern/task.c b/kern/task.c index 13b3c76..0b5

[PATCH 1/8] kern: fix printing of kmem_cache names

2014-02-01 Thread Justus Winter
The name field is not necessarily zero-terminated. Use a precision argument to limit the number of characters written when printing the name. * kern/slab.c (kmem_cache_error): Fix printing of cache names. --- kern/slab.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/kern/

[PATCH 2/8] kern: add snprintf

2014-02-01 Thread Justus Winter
* kern/printf.c (snprintf): New function. * kern/printf.h (snprintf): New declaration. --- kern/printf.c | 10 ++ kern/printf.h | 1 + 2 files changed, 11 insertions(+) diff --git a/kern/printf.c b/kern/printf.c index af59d5a..ea78d48 100644 --- a/kern/printf.c +++ b/kern/printf.c @@ -61

Re: GNU/Hurd DDE talk at FOSDEM

2014-02-01 Thread Michael Banck
On January 31, 2014 6:35:44 PM CET, Samuel Thibault wrote: >Emilio Pozuelo Monfort, le Fri 31 Jan 2014 12:31:39 +0100, a écrit : >> What's the status quo of driver support in the Hurd without DDE (very >few linux >> old 2.0 drivers...) > >You mean other than network boards? That's a usual part o

Re: GNU/Hurd DDE talk at FOSDEM

2014-02-01 Thread Emilio Pozuelo Monfort
On 01/02/14 10:34, Samuel Thibault wrote: > Samuel Thibault, le Fri 31 Jan 2014 18:35:44 +0100, a écrit : >>> I look forward to watching the recorded video :-) >> >> I'm afraid there is usually no video of the microkernel room. > > Actually all rooms will be recorded :D (except the Java room) Coo

Re: GNU/Hurd DDE talk at FOSDEM

2014-02-01 Thread Samuel Thibault
Samuel Thibault, le Fri 31 Jan 2014 18:35:44 +0100, a écrit : > > I look forward to watching the recorded video :-) > > I'm afraid there is usually no video of the microkernel room. Actually all rooms will be recorded :D (except the Java room) Samuel