Re: [PATCH 2/2] proc: fix the receiver lookup in S_proc_exception_raise

2014-01-19 Thread Samuel Thibault
Justus Winter, le Sat 18 Jan 2014 18:19:26 +0100, a écrit : > * proc/mgt.c (S_proc_exception_raise): Update accordingly. > * proc/mig-decls.h: New file. > * proc/proc_exc.defs: Add translation functions. Why putting translation functions into proc_exc, rather than using mutation? > --- > proc/mg

Re: [PATCH 1/2] trans: fix the receiver lookup in password

2014-01-19 Thread Samuel Thibault
Justus Winter, le Sat 18 Jan 2014 18:19:25 +0100, a écrit : > Use translation functions instead of doing the lookup manually. > > * trans/Makefile (password-MIGSFLAGS): Add mutators. > * trans/password.c (S_password_check_user): Update accordingly. > (S_password_check_group): Likewise. Ack. > --

Re: [PATCH 1/2] auth: include the mig-generated server headers in auth.c

2014-01-19 Thread Samuel Thibault
Justus Winter, le Sun 19 Jan 2014 15:05:28 +0100, a écrit : > GNU MIG recently gained support for emitting x_server_routine > declarations in the generated server header file. Using this > declaration, the x_server_routine functions can be inlined into the > demuxer function. > > * auth/auth.c: I

Re: [PATCH 2/2] utils: include the mig-generated server headers in fakeauth.c

2014-01-19 Thread Samuel Thibault
Justus Winter, le Sun 19 Jan 2014 15:05:29 +0100, a écrit : > GNU MIG recently gained support for emitting x_server_routine > declarations in the generated server header file. Using this > declaration, the x_server_routine functions can be inlined into the > demuxer function. > > * utils/fakeauth

Re: [PATCH 6/7] pfinet: include the mig-generated server headers in main.c

2014-01-19 Thread Samuel Thibault
Justus Winter, le Mon 02 Dec 2013 18:01:46 +0100, a écrit : > GNU MIG recently gained support for emitting x_server_routine > declarations in the generated server header file. Using this > declaration, the x_server_routine functions can be inlined into the > demuxer function. > > * pfinet/main.c:

Re: [PATCH 7/7] pflocal: include the mig-generated server headers

2014-01-19 Thread Samuel Thibault
Justus Winter, le Mon 02 Dec 2013 18:01:47 +0100, a écrit : > GNU MIG recently gained support for emitting x_server_routine > declarations in the generated server header file. Using this > declaration, the x_server_routine functions can be inlined into the > demuxer function. > > * pflocal/demuxe

Re: [PATCH 5/7] proc: include the mig-generated server headers in main.c

2014-01-19 Thread Samuel Thibault
Justus Winter, le Mon 02 Dec 2013 18:01:45 +0100, a écrit : > GNU MIG recently gained support for emitting x_server_routine > declarations in the generated server header file. Using this > declaration, the x_server_routine functions can be inlined into the > demuxer function. > > * proc/main.c: I

Re: [PATCH 4/7] exec: include the mig-generated server headers in main.c

2014-01-19 Thread Samuel Thibault
Justus Winter, le Mon 02 Dec 2013 18:01:44 +0100, a écrit : > GNU MIG recently gained support for emitting x_server_routine > declarations in the generated server header file. Using this > declaration, the x_server_routine functions can be inlined into the > demuxer function. Ack. > * exec/main.

Re: [PATCH 3/7] libtrivfs: include the mig-generated server headers in demuxer.c

2014-01-19 Thread Samuel Thibault
Justus Winter, le Mon 02 Dec 2013 18:01:43 +0100, a écrit : > GNU MIG recently gained support for emitting x_server_routine > declarations in the generated server header file. Using this > declaration, the x_server_routine functions can be inlined into the > demuxer function. Ack. > * libtrivfs/

Re: [PATCH 1/7] libdiskfs: include the mig-generated server headers in demuxer.c

2014-01-19 Thread Samuel Thibault
Justus Winter, le Mon 02 Dec 2013 18:01:41 +0100, a écrit : > GNU MIG recently gained support for emitting x_server_routine > declarations in the generated server header file. Using this > declaration, the x_server_routine functions can be inlined into the > demuxer function. > > * libdiskfs/demu

Re: [PATCH 5/5] Generate a x_server_routine in the sheader so it can be inlined

2014-01-19 Thread Samuel Thibault
Justus Winter, le Mon 02 Dec 2013 10:58:19 +0100, a écrit : > * header.c (WriteServerHeader): Emit a x_server_routine that can be > inlined. > * server.c (WriteEpilog): Export the x_routines array so it can be > used from the inlined x_server_routine. Ack. > --- > header.c |8 >

Re: [PATCH 2/7] libnetfs: include the mig-generated server headers in demuxer.c

2014-01-19 Thread Samuel Thibault
Justus Winter, le Mon 02 Dec 2013 18:01:42 +0100, a écrit : > GNU MIG recently gained support for emitting x_server_routine > declarations in the generated server header file. Using this > declaration, the x_server_routine functions can be inlined into the > demuxer function. Ack. > * libnetfs/d

Re: [PATCH 1/2] vm: remove the declaration of memory_object_create_proxy

2014-01-19 Thread Samuel Thibault
Justus Winter, le Thu 16 Jan 2014 15:24:06 +0100, a écrit : > It is not clear to me why the declaration was put there in the first > place. It is not used anywhere, and it conflicts with the declaration > generated by mig. Ack. > * vm/memory_object_proxy.h (memory_object_create_proxy): Remove de

Re: [PATCH 2/2] kern: include the mig-generated server headers in ipc_kobject.c

2014-01-19 Thread Samuel Thibault
Justus Winter, le Thu 16 Jan 2014 15:24:07 +0100, a écrit : > GNU MIG recently gained support for emitting x_server_routine > declarations in the generated server header file. Using this > declaration, the x_server_routine functions can be inlined into the > ipc_kobject_server function. Ack. > *

Re: [PATCH] Rename variables with the name "error" to "err".

2014-01-19 Thread Samuel Thibault
Justus Winter, le Sun 19 Jan 2014 15:24:53 +0100, a écrit : > The canonical name for variables of the type error_t is err. There > are, however, places where the variable is called error instead. This > is unfortunate, as this shadows the error function. Rename such > variables to err. Ack. >

[PATCH] Rename variables with the name "error" to "err".

2014-01-19 Thread Justus Winter
The canonical name for variables of the type error_t is err. There are, however, places where the variable is called error instead. This is unfortunate, as this shadows the error function. Rename such variables to err. For reference, this is accomplished using the following semantic patch: @@

[PATCH 2/2] utils: include the mig-generated server headers in fakeauth.c

2014-01-19 Thread Justus Winter
GNU MIG recently gained support for emitting x_server_routine declarations in the generated server header file. Using this declaration, the x_server_routine functions can be inlined into the demuxer function. * utils/fakeauth.c: Include the mig-generated server headers. --- utils/fakeauth.c | 6

[PATCH 1/2] auth: include the mig-generated server headers in auth.c

2014-01-19 Thread Justus Winter
GNU MIG recently gained support for emitting x_server_routine declarations in the generated server header file. Using this declaration, the x_server_routine functions can be inlined into the demuxer function. * auth/auth.c: Include the mig-generated server headers. --- auth/auth.c | 10 -