Re: [PATCH v14] kern: simple futex for gnumach

2014-01-13 Thread Diego Nieto Cid
Hi Marin, If you decide to keep working on this, take a look at the following notes 2014/1/13 Marin Ramesa : > + > +static int futex_shared_init(vm_offset_t address, struct futex **futex) > +{ > + vm_map_version_t version; > + vm_prot_t prot; > + boolean_t wired; > + > + *

Re: [PATCH v14] kern: simple futex for gnumach

2014-01-13 Thread Justus Winter
Quoting Marin Ramesa (2014-01-13 19:15:41) > Thanks for your reviews, I learned a lot. You are welcome :) > I won't take up your time anymore. Why not? We are all consenting adults here, right? Anyone can decide by herself how much time she wants to spend on stuff. > I will do this privately

Re: [PATCH v14] kern: simple futex for gnumach

2014-01-13 Thread Richard Braun
On Mon, Jan 13, 2014 at 07:15:41PM +0100, Marin Ramesa wrote: > Thanks for your reviews, I learned a lot. I won't take up your time > anymore. > I will do this privately from now on, so I don't bother people on the > mailing list with my patches. How about making some real learning effort instead

Re: [PATCH v14] kern: simple futex for gnumach

2014-01-13 Thread Marin Ramesa
On 01/13/2014 06:28:44 PM, Richard Braun wrote: On Mon, Jan 13, 2014 at 03:38:19PM +0100, Marin Ramesa wrote: > Fixed a bug in private wakeups by calling ipc_entry_alloc_name(). > > This is the last version as everything works now. *Sigh* You didn't understand my comment mentioning IPC spaces a

Re: [PATCH v14] kern: simple futex for gnumach

2014-01-13 Thread Richard Braun
On Mon, Jan 13, 2014 at 03:38:19PM +0100, Marin Ramesa wrote: > Fixed a bug in private wakeups by calling ipc_entry_alloc_name(). > > This is the last version as everything works now. *Sigh* You didn't understand my comment mentioning IPC spaces at all... You keep wrongly using the red-black tre

Re: [PATCH v14] kern: simple futex for gnumach

2014-01-13 Thread Justus Winter
Hi Marin :) Quoting Marin Ramesa (2014-01-13 15:38:19) > Fixed a bug in private wakeups by calling ipc_entry_alloc_name(). > > This is the last version as everything works now. Heh, how many times did I think just that >,< > To do a quick userspace mutex test with timed waits: Good to see you

[PATCH v14] kern: simple futex for gnumach

2014-01-13 Thread Marin Ramesa
Fixed a bug in private wakeups by calling ipc_entry_alloc_name(). This is the last version as everything works now. To do a quick userspace mutex test with timed waits: #include "gnumach.h" #include #include #include int e = 0; void *thread_f(void *arg) { printf("Thread 2 about to b

Re: [PATCH] Replaced bz2 decompression code with libbz2

2014-01-13 Thread Justus Winter
Hi Ignazio :) Quoting Ignazio Sgalmuzzo (2014-01-12 23:22:37) > While testing, I noticed a little problem with "settrans -ca test > /hurd/storeio -T bunzip2 test.bz2": it seems it looks for a .so module > with wrong name (something like "libstore_test.bz2.so.0.3)": I want to > investigate furth