Re: [RFC] GDB Hurd Fixes

2014-01-06 Thread Pedro Alves
On 01/06/2014 04:56 PM, Thomas Schwinge wrote: > Hi! > > Sorry for the delay, and thanks for the patches you posted. Here are > three patches, based on yours, that I intend to apply if there are no > further comments. I have no further comments (other than saying that IWBN to have the rationale

Re: [RFC] GDB Hurd Fixes

2014-01-06 Thread Thomas Schwinge
Hi! Sorry for the delay, and thanks for the patches you posted. Here are three patches, based on yours, that I intend to apply if there are no further comments. On Fri, 20 Sep 2013 11:17:08 -0400, David Michael wrote: > On Fri, Sep 20, 2013 at 4:47 AM, Pedro Alves wrote: > > On 09/20/2013 01:

Re: [RFC] kern: simple futex for gnumach (version 10)

2014-01-06 Thread Richard Braun
On Mon, Jan 06, 2014 at 12:34:32PM +0100, Richard Braun wrote: > > +static struct rbtree futex_tree; > > http://lists.gnu.org/archive/html/bug-hurd/2013-12/msg00545.html : > "Personally, I'd use a per-task red-black tree". > > > http://lists.gnu.org/archive/html/bu

Re: [RFC] kern: simple futex for gnumach (version 10)

2014-01-06 Thread Richard Braun
On Sun, Jan 05, 2014 at 11:12:29PM +0100, Marin Ramesa wrote: > +/* Atomic compare using GCC builtin. */ > +#define atomic_compare(value1, value2) __sync_bool_compare_and_swap(&value1, > value2, value1) The kernel needs its own atomic interface, and it will probably use the "atomic_" namespace. I

Re: [PATCH 1/4] linux: fix bit tests

2014-01-06 Thread Justus Winter
Quoting Samuel Thibault (2014-01-06 02:41:03) > > * linux/src/drivers/net/tlan.c: Fix bit tests. > > * linux/src/drivers/scsi/AM53C974.c: Likewise. > > * linux/src/drivers/scsi/FlashPoint.c: Likewise. > > * linux/src/drivers/scsi/NCR5380.c: Likewise. > > * linux/src/drivers/scsi/t128.c: Likewise. >

Re: [PATCH 4/4] kern: optimize the layout of struct kmem_cache

2014-01-06 Thread Samuel Thibault
Richard Braun, le Mon 06 Jan 2014 11:56:57 +0100, a écrit : > On Mon, Jan 06, 2014 at 11:47:10AM +0100, Justus Winter wrote: > > No, but I profiled this. This is the output of pahole (on the left) > > and the results of my profiling on the right. The rightmost number is > > the access count. Thi

Re: [PATCH 4/4] kern: optimize the layout of struct kmem_cache

2014-01-06 Thread Richard Braun
On Mon, Jan 06, 2014 at 11:47:10AM +0100, Justus Winter wrote: > No, but I profiled this. This is the output of pahole (on the left) > and the results of my profiling on the right. The rightmost number is > the access count. This is the situation before my patch: This looks fine to me, although

Re: [PATCH 4/4] kern: optimize the layout of struct kmem_cache

2014-01-06 Thread Justus Winter
Quoting Samuel Thibault (2014-01-06 02:43:20) > Justus Winter, le Mon 06 Jan 2014 00:34:55 +0100, a écrit : > > * kern/slab.h (struct kmem_cache): Reorder the fields so that all hot > > fields are within the first cache line. > > Did you try to benchmark this a bit? > > I'm unsure about all movem

Re: Valgrind porting

2014-01-06 Thread Richard Braun
On Mon, Jan 06, 2014 at 01:27:08AM +0530, Subhashish Pradhan wrote: > Has anyone started working on porting valgrind to hurd? > > If not, I'd like to take up the task (and for GSOC). > > What would be the essential skills that would be required for this task? > > Shell scripting, understanding o

Re: Valgrind porting

2014-01-06 Thread Samuel Thibault
Hello, Subhashish Pradhan, le Mon 06 Jan 2014 09:01:26 +0530, a écrit : > So teaching valgrind the syscall means directing memcache tool to > intercept the read/write operations of the syscall? It does not mean "intercepting", but writing in the valgrind source code what read/write operations the