Re: [PATCH 57/68] Remove MACH_TTD code

On 04.12.2013 22:59:06, Samuel Thibault wrote: > Marin Ramesa, le Fri 29 Nov 2013 22:54:22 +0100, a écrit : > > * device/net_io.c [MACH_TTD]: Remove code. > > * i386/i386/trap.c [MACH_TTD]: Likewise. > > * i386/i386at/autoconf.c [MACH_TTD]: Likewise. > > Ah. The patch ordering was improper then :)

Re: [PATCH 57/68] Remove MACH_TTD code

Marin Ramesa, le Fri 29 Nov 2013 22:54:22 +0100, a écrit : > * device/net_io.c [MACH_TTD]: Remove code. > * i386/i386/trap.c [MACH_TTD]: Likewise. > * i386/i386at/autoconf.c [MACH_TTD]: Likewise. Ah. The patch ordering was improper then :) There are other occurrences of MACH_TTD. Samuel

Re: [PATCH 56/68] Remove unnecessary files

Marin Ramesa, le Fri 29 Nov 2013 22:54:21 +0100, a écrit : > * i386/i386/kttd_interface.c: Remove file. > * i386/i386/kttd_machdep.h: Remove file. Err, kttd *is* used when MACH_TTD is 1. -- Samuel

Re: [PATCH 53/68] Normalize whitespace

Marin Ramesa, le Fri 29 Nov 2013 22:54:18 +0100, a écrit : > Normalize whitespace. Well, I don't really see the need to normalize the number of empty lines. Depending on cases it may be preferrable to have several of them, or not. -- Samuel

Re: [PATCH 46/68] kern/ipc_kobject.c: remove forward declarations

Marin Ramesa, le Fri 29 Nov 2013 22:54:11 +0100, a écrit : > diff --git a/i386/i386/machine_routines.h b/i386/i386/machine_routines.h > index d77849a..0fdf630 100644 > --- a/i386/i386/machine_routines.h > +++ b/i386/i386/machine_routines.h > @@ -33,5 +33,23 @@ > #define MACHINE_SERVER

Re: [PATCH 29/68] i386/i386at/pic_isa.c: remove forward declaration

Marin Ramesa, le Fri 29 Nov 2013 22:53:54 +0100, a écrit : > --- a/kern/mach_clock.h > +++ b/kern/mach_clock.h > @@ -29,7 +29,7 @@ > #include > #include > #include > - > +#include > > /* Timers in kernel. */ > extern unsigned long elapsed_ticks; /* number of ticks elapsed since bootup

Re: [PATCH 24/68] i386/i386at/conf.c: remove forward declarations

Marin Ramesa, le Fri 29 Nov 2013 22:53:49 +0100, a écrit : > -timemmap(dev,off,prot) > +timemmap(prot) Again, you can't drop parameters like this, it'll just break things. Samuel

Re: [PATCH 23/68] i386/i386at/autoconf.c, com.c, lpr.c: remove forward declarations

Marin Ramesa, le Fri 29 Nov 2013 22:53:48 +0100, a écrit : > @@ -70,7 +62,7 @@ struct tty lpr_tty[NLPR]; > int lpr_alive[NLPR]; > > int > -lprprobe(port, dev) > +lprprobe(dev) > struct bus_device *dev; > { > u_short addr = (u_short) dev->address; Why the change in the prototype? The

Re: [PATCH 17/68] i386/i386/fpu.c: remove (#if 1)

Marin Ramesa, le Fri 29 Nov 2013 22:53:42 +0100, a écrit : > * i386/i386/fpu.c: Remove (#if 1). The if corresponds to the comment below, it shows exactly what the authors believed not to be useful perhaps. > -#if 1 > /* > * I'm not sure this is needed. Does the fpu regenerate the interrupt in

Re: [PATCH 04/68] ddb/db_output.c: remove forward declaration

Marin Ramesa, le Fri 29 Nov 2013 22:53:29 +0100, a écrit : > * ddb/db_output.c (db_check_interrupt): Remove forward declaration. > * ddb/db_output.h (db_check_interrupt): Add prototype. Err, rather put it in db_input.h since it's defined in db_input.c? Samuel

Re: [PATCH] Patch that breaks the gnumach build

Marin Ramesa, le Mon 02 Dec 2013 20:06:34 +0100, a écrit : > On 02.12.2013 14:38:28, Samuel Thibault wrote: > > Marin Ramesa, le Sun 01 Dec 2013 10:47:53 +0100, a écrit : > > > I need some help. I'm trying to fix a GCC warning by modifying the > > > struct dev_ops in device/conf.h. I need the defin

Re: [PATCH 7/7] trans: make the fakeroot environment more transparent

Justus Winter, le Wed 04 Dec 2013 12:11:56 +0100, a écrit : > Previously fakeroot did not explicitly proxy io_identity requests, so > the default implementation from libnetfs handled them. But as the fsys > identity port returned was always netfs_fsys_identity, this broke the > getcwd logic (assumi

Re: [PATCH 6/7] trans: fix transparent reauthentication in fakeroot

Justus Winter, le Wed 04 Dec 2013 12:11:55 +0100, a écrit : > When looking up files, fakeroot intercepts reauthentication requests > and executes io_reauthenticate and auth_user_authenticate > transparently for the client. This, however, makes the client > incorrectly assume that the lookup is fini

Re: [PATCH 5/7] trans: fix the creation of files in fakeroot

Justus Winter, le Wed 04 Dec 2013 12:11:54 +0100, a écrit : > Previously, fakeroot failed to create files in certain circumstances, > e. g. assuming /tmp is a tmpfs and /tmp/some_file does not exist: > > % cd /tmp && fakeroot-hurd /bin/sh -c ':>/tmp/some_file' > /bin/sh: 1: cannot create /tmp/some

Re: [PATCH 4/7] trans: improve the netfs_demuxer function in fakeroot.c

Justus Winter, le Wed 04 Dec 2013 12:11:53 +0100, a écrit : > Handle multiple request types as recommended by the Mach Server > Writer's Guide section 4, subsection "Handling Multiple Request > Types". This avoids initializing the reply message in every X_server > function. The reply message has

Re: [PATCH 3/7] trans: remove unused declaration from fakeroot.c

Justus Winter, le Wed 04 Dec 2013 12:11:52 +0100, a écrit : > Any messages we do not intercept are forwarded to the underlying file. > > * trans/fakeroot.c (netfs_demuxer): Remove unused declaration of > function netfs_ifsock_server. Ack.

Re: [PATCH 1/7] auth: improve the auth_demuxer function

Justus Winter, le Wed 04 Dec 2013 12:11:50 +0100, a écrit : > Handle multiple request types as recommended by the Mach Server > Writer's Guide section 4, subsection "Handling Multiple Request > Types". This avoids initializing the reply message in every X_server > function. The reply message has

Re: [PATCH 2/7] utils: improve the auth_demuxer function in fakeauth.c

Justus Winter, le Wed 04 Dec 2013 12:11:51 +0100, a écrit : > Handle multiple request types as recommended by the Mach Server > Writer's Guide section 4, subsection "Handling Multiple Request > Types". This avoids initializing the reply message in every X_server > function. The reply message has

[PATCH 7/7] trans: make the fakeroot environment more transparent

Previously fakeroot did not explicitly proxy io_identity requests, so the default implementation from libnetfs handled them. But as the fsys identity port returned was always netfs_fsys_identity, this broke the getcwd logic (assuming /media/scratch is a translator): % cd /media/scratch/foo && fake

[PATCH 6/7] trans: fix transparent reauthentication in fakeroot

When looking up files, fakeroot intercepts reauthentication requests and executes io_reauthenticate and auth_user_authenticate transparently for the client. This, however, makes the client incorrectly assume that the lookup is finished (assuming /media/scratch is a translator): % cd /media/scratch

[PATCH 4/7] trans: improve the netfs_demuxer function in fakeroot.c

Handle multiple request types as recommended by the Mach Server Writer's Guide section 4, subsection "Handling Multiple Request Types". This avoids initializing the reply message in every X_server function. The reply message has already been properly initialized in libports, so there is no need t

[PATCH 2/7] utils: improve the auth_demuxer function in fakeauth.c

Handle multiple request types as recommended by the Mach Server Writer's Guide section 4, subsection "Handling Multiple Request Types". This avoids initializing the reply message in every X_server function. The reply message has already been properly initialized in libports, so there is no need t

[PATCH 5/7] trans: fix the creation of files in fakeroot

Previously, fakeroot failed to create files in certain circumstances, e. g. assuming /tmp is a tmpfs and /tmp/some_file does not exist: % cd /tmp && fakeroot-hurd /bin/sh -c ':>/tmp/some_file' /bin/sh: 1: cannot create /tmp/some_file: Is a directory Fix this by sanitizing the flags value not to c

[PATCH 3/7] trans: remove unused declaration from fakeroot.c

Any messages we do not intercept are forwarded to the underlying file. * trans/fakeroot.c (netfs_demuxer): Remove unused declaration of function netfs_ifsock_server. --- trans/fakeroot.c |1 - 1 file changed, 1 deletion(-) diff --git a/trans/fakeroot.c b/trans/fakeroot.c index 1766cc2..f3d

[PATCH 1/7] auth: improve the auth_demuxer function

Handle multiple request types as recommended by the Mach Server Writer's Guide section 4, subsection "Handling Multiple Request Types". This avoids initializing the reply message in every X_server function. The reply message has already been properly initialized in libports, so there is no need t

Re: [PATCH 59/68] Type definition

On 29.11.2013 22:54:24, Marin Ramesa wrote: > -lock_info_sort(arg, abs, count) > +void lock_info_sort(int count) This is wrong. It should be: -lock_info_sort(arg, abs, count) +void lock_info_sort(int arg, int abs, int count)