Re: [PATCH 11/11] proc: store the device master port in _hurd_device_master

Justus Winter, le Wed 27 Nov 2013 13:31:18 +0100, a écrit : > * proc/host.c (S_proc_getprivports): Adapt accordingly. > * proc/main.c (main): Store the device master port in _hurd_device_master. > * proc/proc.h (master_device_port): Remove unused variable. Ditto, ack. > --- > proc/host.c |2

Re: [PATCH 10/11] proc: store the privileged host port in _hurd_host_priv

Justus Winter, le Wed 27 Nov 2013 13:31:17 +0100, a écrit : > Store the privileged host port in _hurd_host_priv like it is done in > the root filesystem. This fixes the thread priority adjustment in the > proc server. Prior to this fix, a warning message "unable to adjust > libports thread priority

Re: [PATCH 09/11] libports: improve error reporting in adjust_priority

Justus Winter, le Wed 27 Nov 2013 13:31:16 +0100, a écrit : > By using error instead of perror, the warning can be proprely > attributed to the process. > > * libports/manage-multithread.c (adjust_priority): Use error instead > of perror to print the warning. Ack. > --- > libports/manage-mult

Re: [PATCH 08/11] libfshelp: improve error handling in fshelp_start_translator_long

Justus Winter, le Wed 27 Nov 2013 13:31:15 +0100, a écrit : > Properly deallocate all ports and terminate the started translator if > an error occurs. > > * libfshelp/start-translator-long.c (fshelp_start_translator_long): > Improve error handling. > --- > libfshelp/start-translator-long.c |

Re: [PATCH 05/11] libports: improve error handling in ports_reallocate_from_external

Justus Winter, le Wed 27 Nov 2013 13:31:12 +0100, a écrit : > * libports/reallocate-from-external.c (ports_reallocate_from_external): > Improve error handling. Ditto, ack. > --- > libports/reallocate-from-external.c |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a

Re: [PATCH 07/11] libdiskfs: improve error reporting in diskfs_start_disk_pager

Justus Winter, le Wed 27 Nov 2013 13:31:14 +0100, a écrit : > * libdiskfs/disk-pager.c (diskfs_start_disk_pager): Improve error reporting. Better message indeed, ack. > --- > libdiskfs/disk-pager.c |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libdiskfs/disk-page

Re: [PATCH 06/11] libports: improve error handling in ports_transfer_right

Justus Winter, le Wed 27 Nov 2013 13:31:13 +0100, a écrit : > * libports/transfer-right.c (ports_transfer_right): Improve error handling. Ditto, ack. > --- > libports/transfer-right.c |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libports/transfer-right.c b/libpo

Re: [PATCH 04/11] libports: improve error handling in ports_reallocate_port

Justus Winter, le Wed 27 Nov 2013 13:31:11 +0100, a écrit : > * libports/reallocate-port.c (ports_reallocate_port): Improve error > handling. Better safe than sorry, yes. Ack > --- > libports/reallocate-port.c |3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libpo

Re: [PATCH 03/11] proc: update comments

Justus Winter, le Wed 27 Nov 2013 13:31:10 +0100, a écrit : > * proc/main.c (main): Update comment. The proc server is no longer PID 0. > * proc/proc.h: Likewise. Ack. > --- > proc/main.c |2 +- > proc/proc.h |2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/pro

Re: [PATCH 02/11] init: fix port leak

Justus Winter, le Wed 27 Nov 2013 13:31:09 +0100, a écrit : > * init/init.c (S_startup_essential_task): Fix port leak. Ack. > --- > init/init.c |6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/init/init.c b/init/init.c > index de5dd6b..b7b40bd 100644 > --- a/ini

Re: [PATCH 01/11] libshouldbeinlibc: fix minor port leak in maptime_map

Justus Winter, le Wed 27 Nov 2013 13:31:08 +0100, a écrit : > Deallocate the device port after creating the mapping. The mapping is > independent of the device port. > > * libshouldbeinlibc/maptime.c (maptime_map): Deallocate device port. Ack. > --- > libshouldbeinlibc/maptime.c |4 >

[PATCH 11/11] proc: store the device master port in _hurd_device_master

* proc/host.c (S_proc_getprivports): Adapt accordingly. * proc/main.c (main): Store the device master port in _hurd_device_master. * proc/proc.h (master_device_port): Remove unused variable. --- proc/host.c |2 +- proc/main.c |4 ++-- proc/proc.h |2 -- 3 files changed, 3 insertions(+)

[PATCH 10/11] proc: store the privileged host port in _hurd_host_priv

Store the privileged host port in _hurd_host_priv like it is done in the root filesystem. This fixes the thread priority adjustment in the proc server. Prior to this fix, a warning message "unable to adjust libports thread priority" sometimes appeared early in the boot process. * proc/host.c (S_pr

[PATCH 09/11] libports: improve error reporting in adjust_priority

By using error instead of perror, the warning can be proprely attributed to the process. * libports/manage-multithread.c (adjust_priority): Use error instead of perror to print the warning. --- libports/manage-multithread.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --

[PATCH 08/11] libfshelp: improve error handling in fshelp_start_translator_long

Properly deallocate all ports and terminate the started translator if an error occurs. * libfshelp/start-translator-long.c (fshelp_start_translator_long): Improve error handling. --- libfshelp/start-translator-long.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/l

[PATCH 07/11] libdiskfs: improve error reporting in diskfs_start_disk_pager

* libdiskfs/disk-pager.c (diskfs_start_disk_pager): Improve error reporting. --- libdiskfs/disk-pager.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libdiskfs/disk-pager.c b/libdiskfs/disk-pager.c index 8fe8f80..9a0d9d8 100644 --- a/libdiskfs/disk-pager.c +++ b/libdiskf

[PATCH 06/11] libports: improve error handling in ports_transfer_right

* libports/transfer-right.c (ports_transfer_right): Improve error handling. --- libports/transfer-right.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libports/transfer-right.c b/libports/transfer-right.c index e313f71..72488a9 100644 --- a/libports/transfer-right.c +++

[PATCH 04/11] libports: improve error handling in ports_reallocate_port

* libports/reallocate-port.c (ports_reallocate_port): Improve error handling. --- libports/reallocate-port.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libports/reallocate-port.c b/libports/reallocate-port.c index b2977dd..d2adaeb 100644 --- a/libports/reallocate-po

[PATCH 05/11] libports: improve error handling in ports_reallocate_from_external

* libports/reallocate-from-external.c (ports_reallocate_from_external): Improve error handling. --- libports/reallocate-from-external.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libports/reallocate-from-external.c b/libports/reallocate-from-external.c index cd1214

[PATCH 01/11] libshouldbeinlibc: fix minor port leak in maptime_map

Deallocate the device port after creating the mapping. The mapping is independent of the device port. * libshouldbeinlibc/maptime.c (maptime_map): Deallocate device port. --- libshouldbeinlibc/maptime.c |4 1 file changed, 4 insertions(+) diff --git a/libshouldbeinlibc/maptime.c b/libsh

[PATCH 02/11] init: fix port leak

* init/init.c (S_startup_essential_task): Fix port leak. --- init/init.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/init/init.c b/init/init.c index de5dd6b..b7b40bd 100644 --- a/init/init.c +++ b/init/init.c @@ -1202,6 +1202,10 @@ S_startup_essential_task (mach_po

[PATCH 03/11] proc: update comments

* proc/main.c (main): Update comment. The proc server is no longer PID 0. * proc/proc.h: Likewise. --- proc/main.c |2 +- proc/proc.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/proc/main.c b/proc/main.c index 73abbc0..6b18737 100644 --- a/proc/main.c +++ b/proc/m

Re: [PATCH 1/5] Stylistic fixes

On 27.11.2013 09:59:02, Samuel Thibault wrote: > Marin Ramesa, le Tue 26 Nov 2013 21:03:31 +0100, a écrit : > > After the patch is applied, fixes for the patch need to be applied > > (I will send those shortly after this mail). It seems that ANSI > > style definitions don't allow for forward decla

Re: [PATCH 1/5] Stylistic fixes

Marin Ramesa, le Tue 26 Nov 2013 21:03:31 +0100, a écrit : > After the patch is applied, fixes for the patch need to be applied (I > will send those shortly after this mail). It seems that ANSI style > definitions don't allow for forward declarations that conflict the > definitions, so these (th