Re: [PATCH 2/2] kern: fix the error handling in exec_load

2013-11-04 Thread Samuel Thibault
Justus Winter, le Mon 04 Nov 2013 19:18:35 +0100, a écrit : > Found using the Clang Static Analyzer. > > * kern/elf-load.c (exec_load): Properly propagate errors. ACK > --- > kern/elf-load.c |2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/kern/elf-load.c b/kern/elf-load.c > index

Re: [PATCH 1/2] device: fix enqueuing of characters in ttyinput_many

2013-11-04 Thread Samuel Thibault
Justus Winter, le Mon 04 Nov 2013 19:18:34 +0100, a écrit : > Fix enqueuing of characters in ttyinput_many by wrapping the call to > b_to_q in a loop. This was probably intended by the authors, as they > subtract the number of enqueued characters from count. Mmm, I don't think so actually, see the

[PATCH 2/2] kern: fix the error handling in exec_load

2013-11-04 Thread Justus Winter
Found using the Clang Static Analyzer. * kern/elf-load.c (exec_load): Properly propagate errors. --- kern/elf-load.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/kern/elf-load.c b/kern/elf-load.c index 1d103d3..441276e 100644 --- a/kern/elf-load.c +++ b/kern/elf-load.c @@ -80,6 +80,8

[PATCH 1/2] device: fix enqueuing of characters in ttyinput_many

2013-11-04 Thread Justus Winter
Fix enqueuing of characters in ttyinput_many by wrapping the call to b_to_q in a loop. This was probably intended by the authors, as they subtract the number of enqueued characters from count. Found using the Clang Static Analyzer. * device/chario.c (ttyinput_many): Fix enqueuing of characters. -

Re: llvm / clang / scan-build of the Hurd

2013-11-04 Thread Richard Braun
On Fri, Oct 25, 2013 at 02:32:08PM -0700, Roland McGrath wrote: > > Clang does not support nested functions [1], and there is no plan to > > support them upstream. As such, any file that uses nested functions > > (or any gcc extension not supported by clang) is excluded from the > > analysis (see e