Re: RFC: Look up device file name on device_open

2013-09-09 Thread Samuel Thibault
rekado, le Tue 10 Sep 2013 11:10:47 +0800, a écrit : > > - it should close the previous master device before opening another > > one, otherwise you get a port leak on each ds_device_open call. It > > ds_device_close() only returns D_INVALID_OPERATION. How should the > master device be closed? I

Re: [PATCH] Look up device file name on device_open

2013-09-09 Thread rekado
Hi Samuel, thank you for your comments. On 09/10/2013 03:03 AM, Samuel Thibault wrote: > - it should only reopen the master device if master_file is not NULL ; I assumed that master_file is always non-NULL when master_device is used, but I was wrong: I overlooked the call to get_privileged_port

Re: [PATCH] mount: handle -t auto

2013-09-09 Thread Samuel Thibault
David Michael, le Mon 09 Sep 2013 18:00:19 -0400, a écrit : > I tried building mount and got a linker error due to missing the -lblkid. > > On Mon, Sep 2, 2013 at 4:55 AM, Justus Winter > <4win...@informatik.uni-hamburg.de> wrote: > > +mount-LDLIBS = $(libblkid-LIBS) > > +mount-CPPFLAGS = $(libblk

Re: [PATCH] mount: handle -t auto

2013-09-09 Thread David Michael
Hi, I tried building mount and got a linker error due to missing the -lblkid. On Mon, Sep 2, 2013 at 4:55 AM, Justus Winter <4win...@informatik.uni-hamburg.de> wrote: > +mount-LDLIBS = $(libblkid-LIBS) > +mount-CPPFLAGS = $(libblkid-CFLAGS) Those libblkid variables were defined using an undersco

Re: [PATCH] device: cleanup of the TTY io

2013-09-09 Thread Samuel Thibault
Marin Ramesa, le Sun 08 Sep 2013 18:10:45 +0200, a écrit : > I also removed the _PR calculation and broke it into two > calculations (_PR_T and _PR_WM) that I wrote in tty.h, in this way they > can be used by other parts of the code and we get rid of the confusing > undef and redefinition in the

Re: [PATCH] kern: remove all trace of luna88k arch

2013-09-09 Thread Samuel Thibault
Marin Ramesa, le Mon 09 Sep 2013 08:49:09 +0200, a écrit : > Simple patch to remove all trace of the luna88k arch. Applied along the other change to drop luna88k, thanks. > By the way, I'm sending this to the list as a test for git-send-email > as Justus suggested, so if something unexpected hap

Re: [PATCH] Look up device file name on device_open

2013-09-09 Thread Samuel Thibault
Hello, rekado, le Mon 09 Sep 2013 20:37:17 +0800, a écrit : > A fresh `master_device' port is now obtained when accessing the device > file, not only on translator startup. This ensures that the device > can be re-opened after netdde has died. This is indeed the intended fix, but it forgets a co

Re: Hacking gnumach to track parental relationship of tasks

2013-09-09 Thread Samuel Thibault
Ludovic Courtès, le Mon 09 Sep 2013 18:48:03 +0200, a écrit : > Samuel Thibault skribis: > > Ludovic Courtès, le Sat 07 Sep 2013 22:04:06 +0200, a écrit : > >> However, wouldn’t it be preferable to fix it by interposing on > >> ‘task_create’ calls, à la clans & chiefs? (IIUC, this can be done wit

Re: Hacking gnumach to track parental relationship of tasks

2013-09-09 Thread Ludovic Courtès
Samuel Thibault skribis: > Ludovic Courtès, le Sat 07 Sep 2013 22:04:06 +0200, a écrit : >> However, wouldn’t it be preferable to fix it by interposing on >> ‘task_create’ calls, à la clans & chiefs? (IIUC, this can be done with >> by setting the TASK_KERNEL_PORT of a task.) > > Apparently task_

Re: [PATCH] Try to re-open network device on transmission error

2013-09-09 Thread Samuel Thibault
Hello, Thanks for working on this! rekado, le Mon 09 Sep 2013 21:03:44 +0800, a écrit : > Attempt to re-open the network device when device_write fails, e.g. when > netdde has crashed. It seems there are other things done on ether_port in setup_ethernet_device. I however guess these could be m

[PATCH] Look up device file name on device_open

2013-09-09 Thread rekado
A fresh `master_device' port is now obtained when accessing the device file, not only on translator startup. This ensures that the device can be re-opened after netdde has died. --- devnode/devnode.c | 4 1 file changed, 4 insertions(+) diff --git a/devnode/devnode.c b/devnode/devnode.c ind

[PATCH] Try to re-open network device on transmission error

2013-09-09 Thread rekado
Attempt to re-open the network device when device_write fails, e.g. when netdde has crashed. --- pfinet/ethernet.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/pfinet/ethernet.c b/pfinet/ethernet.c index b96c09a..f9fadf1 100644 --- a/pfinet/ethernet.c ++

[PATCH] Look up device file name on device_open

2013-09-09 Thread rekado
Hi, the following patch is supposed to be applied to the dde incubator branch. rekado (1): Look up device file name on device_open devnode/devnode.c | 4 1 file changed, 4 insertions(+) -- 1.8.3.1

[PATCH] Try to re-open network device on transmission error

2013-09-09 Thread rekado
Attempt to re-open the network device when device_write fails, e.g. when netdde has crashed. --- pfinet/ethernet.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/pfinet/ethernet.c b/pfinet/ethernet.c index b96c09a..f9fadf1 100644 --- a/pfinet/ethernet.c +++

Re: [PATCH 1/2] Port gdbserver to GNU/Hurd

2013-09-09 Thread Yue Lu
Hi, On Fri, Sep 6, 2013 at 3:29 AM, Pedro Alves wrote: > I'm actually very excited to see gdb and gdbserver sharing > a single target backend, even if we still have many wrinkles > in the interfaces to iron out! It does looks like this way > results in lots of less work, and makes me believe we

Re: upstream GNU Hurd vs Debian GNU Hurd?

2013-09-09 Thread Justus Winter
Hi :) Quoting Samuel Thibault (2013-09-09 10:04:55) > Putting a proper subject and explicitly Cc-ing maintainers, otherwise > people will not notice the question under technical details :) Noted >,< > Justus Winter, le Thu 05 Sep 2013 13:04:35 +0200, a écrit : > > Turns out it was only because m

Re: [PATCH 1/2] Port gdbserver to GNU/Hurd

2013-09-09 Thread Thomas Schwinge
Hi! On Sun, 8 Sep 2013 21:35:05 +0800, Yue Lu wrote: > On Fri, Sep 6, 2013 at 5:37 AM, Thomas Schwinge > wrote: > >> (correct me if > >> I'm wrong here), the Hurd's threads are kernel threads > > > > Correct. > > > >> so it'd > >> be better to just make the GDB side use the lwp field too. > >>

Re: upstream GNU Hurd vs Debian GNU Hurd?

2013-09-09 Thread Samuel Thibault
Hello, Putting a proper subject and explicitly Cc-ing maintainers, otherwise people will not notice the question under technical details :) Justus Winter, le Thu 05 Sep 2013 13:04:35 +0200, a écrit : > Turns out it was only because my /hurd/init contained the > proc_set_init_task patches while th

Re: [PATCH] mount: handle -t auto

2013-09-09 Thread Samuel Thibault
Justus Winter, le Mon 02 Sep 2013 10:55:24 +0200, a écrit : > Use libblkid to detect the filesystem type if "auto" is given as > type. Remove the translator localization from main, this is also done > in do_mount and any errors are propagated properly. This way "auto" is > handled correctly if give

Re: Hacking gnumach to track parental relationship of tasks

2013-09-09 Thread Samuel Thibault
Ludovic Courtès, le Sat 07 Sep 2013 22:04:06 +0200, a écrit : > However, wouldn’t it be preferable to fix it by interposing on > ‘task_create’ calls, à la clans & chiefs? (IIUC, this can be done with > by setting the TASK_KERNEL_PORT of a task.) Apparently task_create is a kernel trap. Samuel