Re: [PATCH] Report VM cache statistics

Ah, I hadn't realized the gnumach part was already in, so there's not much to review actually, the client part is trivial, please push to master. Samuel

Re: Questions about patches for hurdselect.c

Svante Signell, le Sun 13 Jan 2013 21:59:23 +0100, a écrit : > On Sun, 2013-01-13 at 21:31 +0100, Samuel Thibault wrote: > > Svante Signell, le Sun 13 Jan 2013 21:18:07 +0100, a écrit : > > > > - In the poll case, on error on one descriptor, the loop shall mark > > > > POLLERR and continue, not fai

Re: Questions about patches for hurdselect.c

Svante Signell, le Sun 13 Jan 2013 21:59:23 +0100, a écrit : > A comment: You removed my comments about readability and > maintainability of if-then-else constructs vs case oriented code. We > seem to have different views on code constructs. As you said yourself, the end decision is Roland's, so

Re: Questions about patches for hurdselect.c

On Sun, 2013-01-13 at 21:31 +0100, Samuel Thibault wrote: > Svante Signell, le Sun 13 Jan 2013 21:18:07 +0100, a écrit : > > > - In the poll case, on error on one descriptor, the loop shall mark > > > POLLERR and continue, not fail altogether. > > > > > > Is that right? > > > > The current code e

[PATCH] Report VM cache size in meminfo

* rootdir.c: Include and . (rootdir_gc_meminfo): Call vm_cache_statistics and return the VM cache size. --- rootdir.c |9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/rootdir.c b/rootdir.c index 1fa71b0..31e2d8c 100644 --- a/rootdir.c +++ b/rootdir.c @@ -17,8 +17,10

[PATCH] Report VM cache statistics

* utils/vmstat.c: Include and . (vm_state): New `cache_stats` member. (vm_state_refresh): Call vm_cache_statistics. (_F): Adjust offset. (fields): Add entries for new statistics and adjust member names. --- utils/vmstat.c | 44 +--- 1 file changed, 29 ins

Re: Questions about patches for hurdselect.c

Svante Signell, le Sun 13 Jan 2013 21:18:07 +0100, a écrit : > > - In the poll case, on error on one descriptor, the loop shall mark > > POLLERR and continue, not fail altogether. > > > > Is that right? > > The current code errors out if it finds one FD not OK, which is a bug. > Irrespective of h

Re: Questions about patches for hurdselect.c

Please don't use @telia.com, it should not be usable any longer, use @gmail.com: I've changed ISP. On Sun, 2013-01-13 at 20:53 +0100, Samuel Thibault wrote: > Hello, > > Svante Signell, le Wed 12 Dec 2012 20:11:55 +0100, a écrit : > > As promised, attached is the first patch to split hurdselect.

Re: Questions about patches for hurdselect.c

Hello, Svante Signell, le Wed 12 Dec 2012 20:11:55 +0100, a écrit : > As promised, attached is the first patch to split hurdselect.c code into > three cases: DELAY, POLL and SELECT, doing the first two parts as > promised in an earlier mail: > 1) Introducing three cases: DELAY, POLL, and SELECT >

Re: [PATCH] Fix segfault in ps after integration of TASK_EVENTS_INFO

David Höppner, le Sat 05 Jan 2013 14:22:56 +0100, a écrit : > this fixes a segfault of ps (ps a -o msgin) after TASK_EVENTS_INFO > will be integrated in gnumach. Applied, thanks! Samuel

Re: [PATCH] Add statistics for task_events_info

David Höppner, le Fri 04 Jan 2013 23:20:00 +0100, a écrit : > this adds the task_events_info statistics to the task structure. I will send > fixes for hurd ps and proc later. Applied, thanks. It would be better if you could assign your copyright to the FSF. This is not strictly needed for gnumach