Re: Questions about patches for hurdselect.c

2012-12-17 Thread Samuel Thibault
Svante Signell, le Mon 17 Dec 2012 22:55:22 +0100, a écrit : > On Mon, 2012-12-17 at 20:37 +0100, Samuel Thibault wrote: > > Svante Signell, le Mon 17 Dec 2012 03:12:10 +0100, a écrit : > > > > > + /* FIXME: sigmask is only used for ppoll and pselect: not yet > > > > > implemented */ > > > > > >

Re: Questions about patches for hurdselect.c

2012-12-17 Thread Svante Signell
On Mon, 2012-12-17 at 20:58 +0100, Richard Braun wrote: > On Mon, Dec 17, 2012 at 03:12:10AM +0100, Svante Signell wrote: > > Richards patch "if (!err && got == 0 && firstfd != -1 && (firstfd != > > lastfd))" does not work, apt-get update (select-based) fails. So there > > will be other means to av

Re: Questions about patches for hurdselect.c

2012-12-17 Thread Svante Signell
On Mon, 2012-12-17 at 20:37 +0100, Samuel Thibault wrote: > Svante Signell, le Mon 17 Dec 2012 03:12:10 +0100, a écrit : > > > > + /* FIXME: sigmask is only used for ppoll and pselect: not yet > > > > implemented */ > > > > > > What do you mean by not yet implemented? > > > > ppoll and pselect

Re: [PATCH 5/7] Fix double call to pthread_mutex_unlock in _treefs_s_dir_lookup.

2012-12-17 Thread Samuel Thibault
Cyril Roelandt, le Mon 17 Dec 2012 20:49:21 +0100, a écrit : > On 12/17/2012 01:31 AM, Samuel Thibault wrote: > >Cyril Roelandt, le Mon 17 Dec 2012 00:51:28 +0100, a écrit : > >>* libtreefs/dir-lookup.c (_treefs_s_dir_lookup): remove a redundant call to > >>pthread_mutex_unlock. > >> > >>Signed-off

Re: Questions about patches for hurdselect.c

2012-12-17 Thread Richard Braun
On Mon, Dec 17, 2012 at 03:12:10AM +0100, Svante Signell wrote: > Richards patch "if (!err && got == 0 && firstfd != -1 && (firstfd != > lastfd))" does not work, apt-get update (select-based) fails. So there > will be other means to avoid the double delay bug. Please don't mention work I haven't r

Re: [PATCH 5/7] Fix double call to pthread_mutex_unlock in _treefs_s_dir_lookup.

2012-12-17 Thread Cyril Roelandt
On 12/17/2012 01:31 AM, Samuel Thibault wrote: Cyril Roelandt, le Mon 17 Dec 2012 00:51:28 +0100, a écrit : * libtreefs/dir-lookup.c (_treefs_s_dir_lookup): remove a redundant call to pthread_mutex_unlock. Signed-off-by: Cyril Roelandt --- libtreefs/dir-lookup.c |1 - 1 file changed, 1 d

Re: Questions about patches for hurdselect.c

2012-12-17 Thread Samuel Thibault
Svante Signell, le Mon 17 Dec 2012 03:12:10 +0100, a écrit : > > > + /* FIXME: sigmask is only used for ppoll and pselect: not yet > > > implemented */ > > > > What do you mean by not yet implemented? > > ppoll and pselect are not implemented (yet), hence sigmask is NULL. ?? See ./sysdeps/mach

Re: Questions about patches for hurdselect.c

2012-12-17 Thread Svante Signell
On Mon, 2012-12-17 at 00:33 +0100, Samuel Thibault wrote: > Svante Signell, le Wed 12 Dec 2012 20:11:55 +0100, a écrit : > > --- hurdselect_orig.c 2012-10-21 22:55:26.0 +0200 > > +++ hurdselect_step1.c 2012-12-12 19:29:26.0 +0100 > > @@ -37,6 +37,13 @@ > > each of REA

Re: [PATCH 5/7] Fix double call to pthread_mutex_unlock in _treefs_s_dir_lookup.

2012-12-17 Thread Neal H. Walfield
At Mon, 17 Dec 2012 01:31:32 +0100, Samuel Thibault wrote: > > Cyril Roelandt, le Mon 17 Dec 2012 00:51:28 +0100, a écrit : > > * libtreefs/dir-lookup.c (_treefs_s_dir_lookup): remove a redundant call to > > pthread_mutex_unlock. > > > > Signed-off-by: Cyril Roelandt > > --- > > libtreefs/dir-l