Re: bug#10021: [PATCH id] Add error-checking on GNU

2011-11-13 Thread Jim Meyering
Ludovic Courtès wrote: > Jim Meyering skribis: > >> Oh, I also had to make the new test script executable, >> or else "make check" would fail. > > It works for me even if it’s not executable when I run “make check > TESTS=id/gnu-zero-uids”, apparently because it’s run this way: > > execve("/bin/

Re: bug#10021: [PATCH id] Add error-checking on GNU

2011-11-13 Thread Alan Curry
Ludovic =?UTF-8?Q?Court=C3=A8s?= writes: > > OTOH, on POSIX-conforming systems (which includes GNU/Linux, so it may > be the majority of systems in use), -1 may well be a valid UID/GID. That's a bizarre statement. 3.428 User ID A non-negative integer that is used to identify a system user.

Re: bug#10021: [PATCH id] Add error-checking on GNU

2011-11-13 Thread Ludovic Courtès
Hi Paul, Paul Eggert skribis: > On 11/12/11 13:48, Ludovic Courtès wrote: >> +#ifdef __GNU__ >> + if (euid == -1 && !use_real >> + && !just_group && !just_group_list && !just_context) >> +error (EXIT_FAILURE, errno, _("cannot get effective UID")); >> +#endif > > I suggest r

Re: bug#10021: [PATCH id] Add error-checking on GNU

2011-11-13 Thread Ludovic Courtès
Hi Jim, Jim Meyering skribis: > Oh, I also had to make the new test script executable, > or else "make check" would fail. It works for me even if it’s not executable when I run “make check TESTS=id/gnu-zero-uids”, apparently because it’s run this way: execve("/bin/sh", ["/bin/sh", "./shell-o

Fixing tmpfs and defpager

2011-11-13 Thread Maksym Planeta
Hello. I've got some results with defpager: $ settrans -ca foo tmpfs/tmpfs 1M $ echo baz > foo/bar $ cat foo/bar baz $ settrans -g foo The patch I wrote is in attachment, but I'm not sure if the way I was fixing defpager and tmpfs is right. So I'm looking forward for your critique. -- Thanks,

QotH q3: Please comment on the quarter of the Hurd

2011-11-13 Thread Arne Babenhauserheide
I finally finished drafting the QotH (to be released on 2011-10 :) ). → http://www.bddebian.com/~hurd-web/contributing/web_pages/news/moth_next/ I hope you enjoy reading it! If you see stuff which should go in, or stuff we should leave out or change, please write so! -- -- -- --

Re: Patch procfs cpuinfo

2011-11-13 Thread Bouju Alain
Hello, with cpuinfo.c and cpuinfo.h Alain ... /* Hurd /proc filesystem, implementation of process directories. Copyright (C) 2010 Free Software Foundation, Inc. This file is part of the GNU Hurd. The GNU Hurd is free software; you can redistribute it and/or modify it under the term

Re: Fix GNU/Hurd linker flags & such

2011-11-13 Thread Samuel Thibault
Ludovic Courtès, le Sat 12 Nov 2011 23:13:28 +0100, a écrit : > Samuel Thibault skribis: > > > # This must be glibc/ELF. > > -linux* | k*bsd*-gnu | kopensolaris*-gnu) > > +linux* | k*bsd*-gnu | kopensolaris*-gnu | gnu*) > > Wouldn’t *-gnu* be a better pattern? Nope, there's netbsdelf-gnu just

Re: Patch procfs cpuinfo

2011-11-13 Thread Samuel Thibault
Bouju Alain, le Sun 13 Nov 2011 01:19:12 +0100, a écrit : > A patch for procfs /proc/cpuinfo Please also post your cpuinfo.c file. Samuel

Re: bug#10021: [PATCH id] Add error-checking on GNU

2011-11-13 Thread Jim Meyering
Ludovic Courtès wrote: > Thanks for the quick review! > > Jim Meyering skribis: > >> However, wouldn't that fail unnecessarily for a process without >> one ID even though id is being asked to print some other(s)? >> E.g., it'd fail for a process with no EUID even when id >> is being asked to print

Patch procfs cpuinfo

2011-11-13 Thread Bouju Alain
Hello, A patch for procfs /proc/cpuinfo Alain ... diff --git a/Makefile b/Makefile index a397522..d79b523 100644 --- a/Makefile +++ b/Makefile @@ -1,10 +1,10 @@ TARGET = procfs -OBJS = procfs.o netfs.o procfs_dir.o \ +OBJS = procfs.o netfs.o procfs_dir.o cpuinfo.o\ process.o proclist.o

Patch procfs cpuinfo

2011-11-13 Thread Bouju Alain
Hello, A patch for procfs /proc/cpuinfo Alain ... diff --git a/Makefile b/Makefile index a397522..d79b523 100644 --- a/Makefile +++ b/Makefile @@ -1,10 +1,10 @@ TARGET = procfs -OBJS = procfs.o netfs.o procfs_dir.o \ +OBJS = procfs.o netfs.o procfs_dir.o cpuinfo.o\ process.o proclist.o

Re: Fix GNU/Hurd linker flags & such

2011-11-13 Thread Ludovic Courtès
Hello, Samuel Thibault skribis: > # This must be glibc/ELF. > -linux* | k*bsd*-gnu | kopensolaris*-gnu) > +linux* | k*bsd*-gnu | kopensolaris*-gnu | gnu*) Wouldn’t *-gnu* be a better pattern? (Especially since linux* could be Linux with another libc.) Thanks, Ludo’.