Re: bug#10021: [PATCH id] Add error-checking on GNU

2011-11-12 Thread Paul Eggert
On 11/12/11 13:48, Ludovic Courtès wrote: > +#ifdef __GNU__ > + if (euid == -1 && !use_real > + && !just_group && !just_group_list && !just_context) > +error (EXIT_FAILURE, errno, _("cannot get effective UID")); > +#endif I suggest removing the "#ifdef __GNU__" here and in it

Re: bug#10021: [PATCH id] Add error-checking on GNU

2011-11-12 Thread Ludovic Courtès
Hi Jim, Thanks for the quick review! Jim Meyering skribis: > However, wouldn't that fail unnecessarily for a process without > one ID even though id is being asked to print some other(s)? > E.g., it'd fail for a process with no EUID even when id > is being asked to print only the real UID or GI

Re: [PATCH gnumach] Inline version.m4 into configure.ac

2011-11-12 Thread Ludovic Courtès
Hi, Guillem Jover skribis: > Here's a first batch, some of those are based on the latest change to > the =announce-N.N files which might seem to be post-release, I could > provide instead the ones that last modified the version number, but > that does not seem more accurate, I guess the most cor

Re: Fix GNU/Hurd linker flags & such

2011-11-12 Thread Samuel Thibault
Samuel Thibault, le Sat 12 Nov 2011 14:52:20 +0100, a écrit : > libtool is missing the GNU/Hurd case in a few places, resulting to build > issues in Debin GNU/Hurd, the attached patch fixes it, could you apply > it please? Ooops, sorry, I forgot to remove the existing bits, which are basically the

Fix GNU/Hurd linker flags & such

2011-11-12 Thread Samuel Thibault
Hello, libtool is missing the GNU/Hurd case in a few places, resulting to build issues in Debin GNU/Hurd, the attached patch fixes it, could you apply it please? Thanks, Samuel diff -ur libtool-2.4.2.orig/libltdl/m4/libtool.m4 libtool-2.4.2/libltdl/m4/libtool.m4 --- libtool-2.4.2.orig/libltdl/m4

Re: [PATCH gnumach] Inline version.m4 into configure.ac

2011-11-12 Thread Svante Signell
What about removing dead (not compiled or used) linux code from gnumach? It is merely confusing...