Re: [PATCH gnumach 4/6] Remove set but unused variables

2011-09-02 Thread Samuel Thibault
Guillem Jover, le Thu 01 Sep 2011 17:17:22 +0200, a écrit : > * linux/dev/drivers/block/floppy.c (setup_rw_floppy): Remove `dflags'. > (floppy_eject): Remove `dummy'. > * linux/src/drivers/net/8390.c (ethdev_init): Remove `ei_local'. > * linux/src/drivers/scsi/ppa.c (ppa_detect): Remove `ppb'. App

Re: [PATCH gnumach 2/6] Add vsnprintf prototype

2011-09-02 Thread Samuel Thibault
Guillem Jover, le Thu 01 Sep 2011 17:17:20 +0200, a écrit : > * kern/printf.h (vsnprintf): New prototype. Applied, thanks. Samuel

Re: [PATCH gnumach 1/3] Use Mach native error codes instead of POSIX errno E* ones

2011-09-02 Thread Samuel Thibault
Guillem Jover, le Thu 01 Sep 2011 20:24:56 +0200, a écrit : > * device/errno.h: Remove file. > * Makefrag.am (libkernel_a_SOURCES): Remove `device/errno.h'. > * i386/i386at/com.c: Include instead of > . > (comopen): Replace ENXIO with D_NO_SUCH_DEVICE. > * i386/i386at/kd_event.c: Include instead

Re: [PATCH gnumach 6/6] Change argument name to match function body usage

2011-09-02 Thread Samuel Thibault
Guillem Jover, le Thu 01 Sep 2011 17:17:24 +0200, a écrit : > Otherwise the function wrongly uses the global symbol. > > * linux/src/drivers/scsi/ppa.c (ppa_nibble_in): Rename `str_p' argument > to `base'. Applied, thanks. This is crazy :) (and already fixed in upstream Linux). Samuel

Re: [PATCH gnumach 5/6] Disable set but unused variable

2011-09-02 Thread Samuel Thibault
Guillem Jover, le Thu 01 Sep 2011 17:17:23 +0200, a écrit : > * linux/src/drivers/scsi/gdth.c (gdth_detect): Conditionalize `b' on > [LINUX_VERSION_CODE < 0x02]. Do not preset it to 0, it's initialized > later on when needed. Applied, thanks. Samuel

Re: [PATCH gnumach 2/3] Do not remap errno codes from E* to LINUX_E*

2011-09-02 Thread Samuel Thibault
Guillem Jover, le Thu 01 Sep 2011 20:24:57 +0200, a écrit : > Mach no longer uses any of the old and clashing errno E* codes, so > it's safe to use them now w/o namespacing. This also means one less > modification needed to the Linux code. > > * linux/dev/include/asm-i386/errno.h: Remove file. > *

Re: [PATCH gnumach 3/3] Remove long obsolete RPC routines

2011-09-02 Thread Samuel Thibault
Applied, thank. Samuel

Re: [PATCH gnumach 3/6] Cast addr argument to vm_offset_t

2011-09-02 Thread Samuel Thibault
Guillem Jover, le Thu 01 Sep 2011 17:17:21 +0200, a écrit : > * linux/dev/glue/kmem.c (vfree): Cast `addr' argument on kfree_mem > function to vm_offset_t. Applied, thanks. Samuel

Re: [PATCH gnumach 1/6] Add missing headers

2011-09-02 Thread Samuel Thibault
Guillem Jover, le Thu 01 Sep 2011 17:17:19 +0200, a écrit : > * linux/dev/init/main.c: Include . > * linux/dev/kernel/printk.c: Include . Applied, thanks. Samuel