Re: [ams@kemisten.nu: ls --translators (coreutils)]

2003-09-19 Thread Alfred M. Szmidt
There is no limit in the protocol, though the ext2fs and ufs implementations limit it to one filesystem block (4kb usually now). Clients should not presume any arbitrary limit on the size of the translator setting. The posted code has no arbitrary limit, but leaks. It needs to do

Re: [ams@kemisten.nu: ls --translators (coreutils)]

2003-09-19 Thread Roland McGrath
> Alfred M. Szmidt wrote: > >> + if (trans_stat.st_mode & S_IPTRANS) > >> +{ > >> + char buf[1024], *trans = buf; > >Is this 1024-byte buffer guaranteed to be large enough? Code like this is using a mig stub feature whereby a larger buffer is alloc

Re: [ams@kemisten.nu: ls --translators (coreutils)]

2003-09-19 Thread Ognyan Kulev
Alfred M. Szmidt wrote: > + if (trans_stat.st_mode & S_IPTRANS) > +{ > + char buf[1024], *trans = buf; Is this 1024-byte buffer guaranteed to be large enough? Good one. I poked around in the Hurd source code, and couldn't really figure out if it would

Re: [ams@kemisten.nu: ls --translators (coreutils)]

2003-09-19 Thread Alfred M. Szmidt
Thanks for the patch and the prod :-) Atleast you wake up when being proded. :-) Please mention that this option is Hurd-specific in both --help output and in coreutils.texi. In `--help' too? I don't think its useful to document it in --help, since well, its just a "reminder" of what t

[ams@kemisten.nu: Re: gcc 3.3.x and profile]

2003-09-19 Thread Alfred M. Szmidt
Could someone comment on this or point me to some place that could? --- Start of forwarded message --- Date: Fri, 22 Aug 2003 10:57:53 +0200 (MEST) From: "Alfred M. Szmidt" <[EMAIL PROTECTED]> To: [EMAIL PROTECTED] CC: [EMAIL PROTECTED] Subject: Re: gcc 3.3.x and profile Hacking on gettin