Re: [PATCH] Unzip fails without optional extended local header signature

2012-02-08 Thread Jim Meyering
Michael Gray wrote: > Heard back from them today. Is this all you need? ... > Your assignment/disclaimer process with the FSF is currently > complete; your fully executed PDF will be sent to you in a separate > email immediately following this one. Great. Thanks for letting me know. I've Cc

Re: Bug#647522: non-deterministic compression results with gzip -n9

2012-02-08 Thread Riku Voipio
Thanks Cyril for tracking this down. On Wed, Feb 08, 2012 at 01:15:00PM +0100, Cyril Brulebois wrote: > I think at least the attached patch won't hurt (when the DYN_ALLOC part > is fixed; and possibly turning that into a MEMSET-like macro). > And given dh_compress is passing files in an arbitrary

Re: Bug#647522: non-deterministic compression results with gzip -n9

2012-02-08 Thread Paul Eggert
Thanks very much for the patch. But can someone who's looked into it please explain why 'window' needs to be zeroed out? This will save me time in reviewing the patch. Thanks.

Re: non-deterministic compression results with gzip -n9

2012-02-08 Thread Zack Weinberg
I've seen inexplicable nondeterminism like this before, and quite often it's turned out to be controlled by the total size of the command line argument area (that is, argv + environ + ELF auxv). Changes in how big that is change the initial stack pointer address, and while that *shouldn't* matter t

Re: Bug#647522: non-deterministic compression results with gzip -n9

2012-02-08 Thread Cyril Brulebois
Zack Weinberg (07/02/2012): > I've seen inexplicable nondeterminism like this before, and quite > often it's turned out to be controlled by the total size of the > command line argument area (that is, argv + environ + ELF auxv). FWIW, a quick look on kfreebsd-amd64 with ppl's CREDITS file led me

Re: Bug#647522: non-deterministic compression results with gzip -n9

2012-02-08 Thread Cyril Brulebois
Cyril Brulebois (08/02/2012): > Playing on amd64: > cbrulebois@Cygnus:/tmp/ppl-0.11.2$ cp ../ppl-pristine/{CREDITS,README} . > cbrulebois@Cygnus:/tmp/ppl-0.11.2$ gzip -9nf CREDITS README > cbrulebois@Cygnus:/tmp/ppl-0.11.2$ ls -l *gz > -rw-r--r-- 1 cbrulebois cbrulebois 6343 Feb 8 12:34 CREDITS.g

Re: Bug#647522: non-deterministic compression results with gzip -n9

2012-02-08 Thread Fabian Greffrath
I think at least the attached patch won't hurt (when the DYN_ALLOC part is fixed; and possibly turning that into a MEMSET-like macro). Just an idea, but couldn't ZEROIFY in the DYN_ALLOC part be defined as free() and subsequent calloc() of the arrays preserving their size? - Fabian