[PATCH] build: do not override gnulib-provided AM_CFLAGS options

2010-01-11 Thread Jim Meyering
FYI, >From 033dda0eeed5b886eb862ba6e12628f2e4011324 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Mon, 11 Jan 2010 11:51:13 +0100 Subject: [PATCH] build: do not override gnulib-provided AM_CFLAGS options Avoid a warning from automake: lib/Makefile.am:24: AM_CFLAGS multiply defined in conditi

RE: gzip use of memcpy

2010-01-11 Thread Alain Magloire
Bonjour, Our tester (Yuxi) was proposing something along this line to check for overlapping. ===email from yuxi=== We could do a smart checking here: Unsigned int delta = w > d ? w -d : d -w; if (delta >= e) /* (this test assumes unsigned comparison) */ { memcp

Re: gzip use of memcpy

2010-01-11 Thread Jim Meyering
Alain Magloire wrote: > Bonjour, > > Our tester (Yuxi) was proposing something along this line to check for > overlapping. > > ===email from yuxi=== > We could do a smart checking here: > Unsigned int delta = w > d ? w -d : d -w; > if (delta >= e) /* (this test assumes unsigned >

RE: gzip use of memcpy

2010-01-11 Thread Yuxi Zhang
Hi Jim It would be nice to declare the delta inside the function scope. Index: inflate.c === --- inflate.c (revision 248271) +++ inflate.c (working copy) @@ -526,6 +526,7 @@ register unsigned e; /* table entry flag/number of

Re: gzip use of memcpy

2010-01-11 Thread Jim Meyering
Yuxi Zhang wrote: > It would be nice to declare the delta inside the function scope. Why? I find it less readable and less maintainable. Do you have to use a compiler for which that is required? If so, please give its name and version number. > Index: inflate.c > =