bug#74196: maint: assume proper behavior of tolower

2024-11-11 Thread Paul Eggert
On 2024-11-11 10:42, Collin Funk wrote: I doubt MSDOS, OS2, ATARI would be supported by Gnulib. Not only are they not supported by Gnulib, I'm sure gzip hasn't worked on them for decades. We just haven't bothered to rip out all the supporting code.

bug#74196: maint: assume proper behavior of tolower

2024-11-11 Thread Collin Funk
Hi Simon, Simon Josefsson writes: > This is for MSDOS/OS2/WIN32/ATARI only as far as I can tell -- do we > know that tolower() works as expected on these architectures? What > problem is caused by the current behaviour? I think it would be nice to > establish that first. I doubt MSDOS, OS2, A

bug#74196: maint: assume proper behavior of tolower

2024-11-05 Thread GNU gzip discussion and bug reports.
Collin Funk writes: > -# define casemap(c) tolow(c) /* Force file names to lower case */ This is for MSDOS/OS2/WIN32/ATARI only as far as I can tell -- do we know that tolower() works as expected on these architectures? What problem is caused by the current behaviour? I think it would be nice

bug#74196: maint: assume proper behavior of tolower

2024-11-03 Thread Collin Funk
Some pre-standard C implementations of tolower had undefined behavior if the character passed to it was not an uppercase character. This patch removes the isupper check before calling tolower since any reasonable platform will behave correctly. Collin >From 118dba90c89a97c4343bbf6afd19c2c9291948