bug#64106: `modify-services` no longer affects multiple instances of the same service

2023-07-18 Thread Brian Cully via Bug reports for GNU Guix
I sent a patch to this ticket yesterday, before remembering this morning that y'all probably weren't auto-Cc'd on it by debbugs. Please have a look over it, especially the tests, in case I missed some functionality or misinterpreted some requirements. This will probably be deserving of a news ite

bug#64106: `modify-services` no longer affects multiple instances of the same service

2023-07-07 Thread Ludovic Courtès
Hi, Brian Cully skribis: > However, if ‘modify-services’ can be changed to do two passes, the first > as a sanity check which verifies service references and raises errors, > and the second to do the actual modification, that should work well. I'm > not concerned with efficiency particularly. Un

bug#64106: `modify-services` no longer affects multiple instances of the same service

2023-06-21 Thread Brian Cully via Bug reports for GNU Guix
Ludovic Courtès writes: > It wasn’t really intended, more a side effect of the implementation, and > I agree it should be fixed. There have been a number of complaints about the behavior change, and I think the patch should probably be reverted. My only intention was to raise an error for the ca

bug#64106: `modify-services` no longer affects multiple instances of the same service

2023-06-19 Thread Ludovic Courtès
Hi, Josselin Poiret skribis: > "David Wilson" writes: > >> Hi Guix! >> >> Recently there was a change to the behavior of `modify-services` that adds >> logic to check for any unused clauses so that an exception can be raised to >> alert the user of this case. >> >> https://git.savannah.gnu.or

bug#64106: `modify-services` no longer affects multiple instances of the same service

2023-06-17 Thread Josselin Poiret via Bug reports for GNU Guix
merge 64106 63921 thankyou Hi David, "David Wilson" writes: > Hi Guix! > > Recently there was a change to the behavior of `modify-services` that adds > logic to check for any unused clauses so that an exception can be raised to > alert the user of this case. > > https://git.savannah.gnu.org/c

bug#64106: `modify-services` no longer affects multiple instances of the same service

2023-06-16 Thread David Wilson
Hi Guix! Recently there was a change to the behavior of `modify-services` that adds logic to check for any unused clauses so that an exception can be raised to alert the user of this case. https://git.savannah.gnu.org/cgit/guix.git/commit/?id=181951207339508789b28ba7cb914f983319920f It seems t