bug#50677: [PATCH] Minetest basic_materials really depends on moreores

2021-10-16 Thread Tobias Geerinckx-Rice via Bug reports for GNU Guix
Vivien, Thanks! I've pushed this series as df2404482495bc3af03e7fc902af1e6b0d10b4a4 et al. I made a only few small tweaks, mainly to the commit message: gnu: minetest-basic-materials: Depend on minetest-moreores. ‘Depend’ sounds wrong to me; it either does, or it doesn't, we don't determ

bug#50677: [PATCH] Minetest basic_materials really depends on moreores

2021-10-15 Thread Maxime Devos
Vivien Kraus schreef op do 14-10-2021 om 17:14 [+0200]: > On IRC you said that you did one test. Aside from you, it seems that > noone cares about minetest. > > Would you accept this patch? [...] IIRC, I tested the patch, it worked, and it looked good to me. However, I'm not a committer. Anyway

bug#50677: [PATCH] Minetest basic_materials really depends on moreores

2021-10-14 Thread Vivien Kraus via Bug reports for GNU Guix
Hello Maxime, Le mercredi 22 septembre 2021 à 20:43 +0200, Maxime Devos a écrit : > Vivien Kraus schreef op wo 22-09-2021 om 20:37 [+0200]: > > Le mercredi 22 septembre 2021 à 20:15 +0200, Maxime Devos a écrit : > > > The latest patch you sent looks good to me, but I didn't test ti. > > > > I tes

bug#50677: [PATCH] Minetest basic_materials really depends on moreores

2021-09-22 Thread Vivien Kraus via Bug reports for GNU Guix
Le mercredi 22 septembre 2021 à 20:15 +0200, Maxime Devos a écrit : > The latest patch you sent looks good to me, but I didn't test ti. I tested it by comparing the build of minetest-moreores when it fails because of the missing file and when it succeeds. Do you think it should be enough if it wer

bug#50677: [PATCH] Minetest basic_materials really depends on moreores

2021-09-22 Thread Maxime Devos
Vivien Kraus schreef op wo 22-09-2021 om 20:37 [+0200]: > Le mercredi 22 septembre 2021 à 20:15 +0200, Maxime Devos a écrit : > > The latest patch you sent looks good to me, but I didn't test ti. > > I tested it by comparing the build of minetest-moreores when it fails > because of the missing fil

bug#50677: [PATCH] Minetest basic_materials really depends on moreores

2021-09-22 Thread Maxime Devos
Vivien Kraus schreef op wo 22-09-2021 om 20:04 [+0200]: > Le mercredi 22 septembre 2021 à 19:41 +0200, Maxime Devos a écrit : > > It would be more convenient > > if the output of Minetest was send to current-output-port, > OK, so it’s like the existing solution, except it should not stop just > at

bug#50677: [PATCH] Minetest basic_materials really depends on moreores

2021-09-22 Thread Vivien Kraus via Bug reports for GNU Guix
Le mercredi 22 septembre 2021 à 19:41 +0200, Maxime Devos a écrit : > It would be more convenient > if the output of Minetest was send to current-output-port, OK, so it’s like the existing solution, except it should not stop just at the first error. From ed878447d600aabdfd80073dab4fdb77cef3801d Mon

bug#50677: [PATCH] Minetest basic_materials really depends on moreores

2021-09-22 Thread Maxime Devos
Vivien Kraus schreef op wo 22-09-2021 om 18:46 [+0200]: > +(define log-file (open-output-file "guix-test.log")) > +(let loop ((has-errors? #f)) > + (let ((line (read-line port))) > +(unless (eof-obj ect? line) > + (write-line line log-file)) > +

bug#50677: [PATCH] Minetest basic_materials really depends on moreores

2021-09-22 Thread Vivien Kraus via Bug reports for GNU Guix
lylip on the #guix chat suggested to save the log to disk, so that the errors can be read in context. I think it is the best thing to do, what do you think? Vivien From f5cafa5aaf26b065f3627d5e013d06c86c251f8f Mon Sep 17 00:00:00 2001 From: Vivien Kraus Date: Sun, 19 Sep 2021 17:00:45 +0200 Subje

bug#50677: [PATCH] Minetest basic_materials really depends on moreores

2021-09-19 Thread Vivien Kraus via Bug reports for GNU Guix
Le dimanche 19 septembre 2021 à 21:11 +0200, Maxime Devos a écrit : > I found a use of "config.txt" ( > https://forum.minetest.net/viewtopic.php?t=2290), > "settingstypes.txt" ( > https://github.com/NathanSalapat/more_fire/blob/master/settingtypes.txt > ) > and another "_config.txt" ( > https://for

bug#50677: [PATCH] Minetest basic_materials really depends on moreores

2021-09-19 Thread Maxime Devos
Vivien Kraus schreef op zo 19-09-2021 om 20:59 [+0200]: > Le dimanche 19 septembre 2021 à 20:54 +0200, Vivien Kraus a écrit : > > I forgot to say, I could not figure out why the package did not > > build, > > because the check phase in the minetest build system stops after the > > first error line

bug#50677: [PATCH] Minetest basic_materials really depends on moreores

2021-09-19 Thread Maxime Devos
Vivien Kraus schreef op zo 19-09-2021 om 20:54 [+0200]: > Hello, > > Le dimanche 19 septembre 2021 à 19:40 +0200, Maxime Devos a écrit : > > > + (version "v2.1.0") > > > > Versions in guix don't use any leading "v" prefix. If I'm not > > mistaken, > > Ludovic applied the patched to remove them a

bug#50677: [PATCH] Minetest basic_materials really depends on moreores

2021-09-19 Thread Vivien Kraus via Bug reports for GNU Guix
Le dimanche 19 septembre 2021 à 20:54 +0200, Vivien Kraus a écrit : > I forgot to say, I could not figure out why the package did not > build, > because the check phase in the minetest build system stops after the > first error line of output, which only stated that there was a > problem > with ini

bug#50677: [PATCH] Minetest basic_materials really depends on moreores

2021-09-19 Thread Vivien Kraus via Bug reports for GNU Guix
Hello, Le dimanche 19 septembre 2021 à 19:40 +0200, Maxime Devos a écrit : > > + (version "v2.1.0") > > Versions in guix don't use any leading "v" prefix. If I'm not > mistaken, > Ludovic applied the patched to remove them automatically. Right, I just had not guix pulled lately, I confirm it wor

bug#50677: [PATCH] Minetest basic_materials really depends on moreores

2021-09-19 Thread Maxime Devos
Vivien Kraus via Bug reports for GNU Guix schreef op zo 19-09-2021 om 17:23 [+0200]: > Dear guix, > > basic_materials actually requires moreores, otherwise some craft > recipes are just not possible. For instance, > basic_materials:silver_wire can only be crafted with > moreores:silver_ingot. Thi

bug#50677: [PATCH] Minetest basic_materials really depends on moreores

2021-09-19 Thread Vivien Kraus via Bug reports for GNU Guix
Dear guix, basic_materials actually requires moreores, otherwise some craft recipes are just not possible. For instance, basic_materials:silver_wire can only be crafted with moreores:silver_ingot. This silver wire is actually needed for basic technic machines, such as the LV compressor. So, let’s