bug#46925: Ripgrep tests failures due to bstr update

2021-03-10 Thread Nicolas Goaziou
John Soo writes: > I think the problem is that the version bound is too loose in > cargo.toml upstream. What does the cargo.lock say on the current > master? I am beginning to think we need to follow the cargo.lock to > resolve dependencies first if it exists. It's 0.2.12 in Cargo.toml and 0.2.1

bug#46925: Ripgrep tests failures due to bstr update

2021-03-10 Thread John Soo
Hey Nicolas, I think the problem is that the version bound is too loose in cargo.toml upstream. What does the cargo.lock say on the current master?I am beginning to think we need to follow the cargo.lock to resolve dependencies first if it exists. Thanks, John

bug#46925: Ripgrep tests failures due to bstr update

2021-03-10 Thread Nicolas Goaziou
Hello, John Soo writes: > I think the breaking tests do actually indicate breaking functionality > in this case since there is a whole test suite dedicated to the > bytestring representation. I use ripgrep daily, and I haven't encountered a regression so far. Of course, this proves nothing. >

bug#46925: Ripgrep tests failures due to bstr update

2021-03-09 Thread John Soo
Hey Nicolas, I think the breaking tests do actually indicate breaking functionality in this case since there is a whole test suite dedicated to the bytestring representation. Maybe the fix could be using a later commit in which the later bstr is used. There are definitely unreleased com

bug#46925: Ripgrep tests failures due to bstr update

2021-03-09 Thread JOULAUD François via Bug reports for GNU Guix
Hello, On Mon, Mar 08, 2021 at 10:40:27PM +0100, Nicolas Goaziou wrote: > JOULAUD François via Bug reports for GNU Guix writes: > > Upgrade rust-bstr-0.2 to be 0.2.12, possibly only upgrading needed > > dependent packages. > > Just to be clear, your are suggesting a downgrade, because currently,

bug#46925: Ripgrep tests failures due to bstr update

2021-03-08 Thread Nicolas Goaziou
Hello, JOULAUD François via Bug reports for GNU Guix writes: > Two possibilities seems to be possible here. > > Upgrade rust-bstr-0.2 to be 0.2.12, possibly only upgrading needed > dependent packages. Just to be clear, your are suggesting a downgrade, because currently, Guix packages bstr 0.2.1

bug#46925: Ripgrep tests failures due to bstr update

2021-03-08 Thread JOULAUD François via Bug reports for GNU Guix
Hello, On Thu, Mar 04, 2021 at 09:38:39PM +0100, Nicolas Goaziou wrote: > John Soo writes: > > > I just talked to burntsushi on github about the failing ripgrep tests. > > It looks like the version of bstr we are now using changed the > > representation of bstrs and caused us test failures. Cha

bug#46925: Ripgrep tests failures due to bstr update

2021-03-04 Thread Nicolas Goaziou
Hello, John Soo writes: > I just talked to burntsushi on github about the failing ripgrep tests. > It looks like the version of bstr we are now using changed the > representation of bstrs and caused us test failures. Changing the > version of bstr used in ripgrep@12.1.1 to 0.2.12 should fix the

bug#46925: Ripgrep tests failures due to bstr update

2021-03-04 Thread John Soo
Hi Guix, I just talked to burntsushi on github about the failing ripgrep tests. It looks like the version of bstr we are now using changed the representation of bstrs and caused us test failures. Changing the version of bstr used in ripgrep@12.1.1 to 0.2.12 should fix the problem. See https://gi