bug#45193: Wrapper of Qt programs doesn't extend existing environment variable

2021-01-11 Thread Hartmut Goebel
Patches are almost done. Expect the within thee next few days. -- Regards Hartmut Goebel | Hartmut Goebel | h.goe...@crazy-compilers.com | | www.crazy-compilers.com | compilers which you thought are impossible |

bug#45193: Wrapper of Qt programs doesn't extend existing environment variable

2021-01-10 Thread Zhu Zihao
Any progress in this patch? It's painful for CJK users that can't use input method for Qt programs :( -- Retrieve my PGP public key: gpg --recv-keys D47A9C8B2AE3905B563D9135BE42B352A9F6821F Zihao signature.asc Description: PGP signature

bug#45193: Wrapper of Qt programs doesn't extend existing environment variable

2020-12-19 Thread Hartmut Goebel
Am 19.12.20 um 19:20 schrieb Zhu Zihao: BTW, would you like to use prefix wrap for wrap-qt-program in qt-utils.scm? I would support your proposal of unifying both wrappers. (Which way round is a matter of closure-size. I assume moving the code to qt-util.scm is the smaller solution.) -- Reg

bug#45193: Wrapper of Qt programs doesn't extend existing environment variable

2020-12-19 Thread Zhu Zihao
Hartmut Goebel writes: > I agree that leaking the environments variables from the build environment to > the package is not a good idea. Also we might want to add some filters to > avoid > all imports (including cmake) are going into the wrapping variables - which is > much easier when dealing w

bug#45193: Wrapper of Qt programs doesn't extend existing environment variable

2020-12-19 Thread Hartmut Goebel
Zhu Zihao wrote When building QT program, Guix builder populates qt related environmentvariable, and wrap-qt-program just record it into wrapper. However, the wrap behaviour in qt-build-system is quite different, itsearch all inputs and mark them should be included in envvar definitionif cor

bug#45193: Wrapper of Qt programs doesn't extend existing environment variable

2020-12-17 Thread Zhu Zihao
I try to read and understand how wrap-qt-program in qt-utils.scm works. When building QT program, Guix builder populates qt related environment variable, and wrap-qt-program just record it into wrapper. However, the wrap behaviour in qt-build-system is quite different, it search all inputs and ma

bug#45193: Wrapper of Qt programs doesn't extend existing environment variable

2020-12-14 Thread Zhu Zihao
Mark H Weaver writes: > I agree with your analysis. Would you like to propose a patch and test > it as thoroughly as you can? I just saw a patch posted by somebody on debbugs. https://issues.guix.gnu.org/45221 Maybe we can go there to improve his patch and we don't have to write it from scrat

bug#45193: Wrapper of Qt programs doesn't extend existing environment variable

2020-12-14 Thread Mark H Weaver
Hi, Zhu Zihao writes: > Reproduce steps: > >guix environment --ad-hoc qbittorrent && cat > $GUIX_ENVIRONMENT/bin/qbittorrent > > > We can see the wrapper generated in qt-build-system doesn't extend > existing environment variable. Instead, it overrides them. > > It was discussed in > https:

bug#45193: Wrapper of Qt programs doesn't extend existing environment variable

2020-12-12 Thread Zhu Zihao
Reproduce steps: guix environment --ad-hoc qbittorrent && cat $GUIX_ENVIRONMENT/bin/qbittorrent We can see the wrapper generated in qt-build-system doesn't extend existing environment variable. Instead, it overrides them. It was discussed in https://lists.gnu.org/archive/html/guix-devel/201