bug#44254: Performance of package input rewriting

2020-11-03 Thread Ludovic Courtès
Hi, Lars-Dominik Braun skribis: >> I guess it’s easy to end up creating huge object graphs. Here’s an >> example of an anti-pattern: >> >> (define a >> ((package-input-rewriting x) ((package-input-rewriting y) p1))) >> >> (define b >> ((package-input-rewriting x) ((package-input-

bug#44254: Performance of package input rewriting

2020-11-03 Thread Lars-Dominik Braun
Hi Ludo, > I guess it’s easy to end up creating huge object graphs. Here’s an > example of an anti-pattern: > > (define a > ((package-input-rewriting x) ((package-input-rewriting y) p1))) > > (define b > ((package-input-rewriting x) ((package-input-rewriting y) p2))) > > The corre

bug#44254: Performance of package input rewriting

2020-10-31 Thread Ludovic Courtès
Hi Lars, Lars-Dominik Braun skribis: >> Another thing to look at is the object graph (as show by ‘guix >> graph’). Input rewriting can duplicate parts of the graph, which in >> turn defeats package->derivation memoization. Just looking at the >> number of nodes in the graph can give hints. >

bug#44254: Performance of package input rewriting

2020-10-30 Thread Lars-Dominik Braun
Hi, > Yes, that’s a possible culprit. Try passing #:deep? #f if it works for > your use case. Yeah, that brings it down to ~8s, which is still alot. > Another thing to look at is the object graph (as show by ‘guix > graph’). Input rewriting can duplicate parts of the graph, which in > turn def

bug#44254: Performance of package input rewriting

2020-10-28 Thread Ludovic Courtès
Hi, zimoun skribis: > On Tue, 27 Oct 2020 at 14:26, Lars-Dominik Braun > wrote: > >> Previously I have been doing this using package-input-rewriting, but starting >> an environment containing python-jupyterlab alone took about 20s (warm >> caches, >> all derivations in the store). Manually re

bug#44254: Performance of package input rewriting

2020-10-27 Thread Ricardo Wurmus
Lars-Dominik Braun writes: > this issue is similar to https://issues.guix.gnu.org/41702, but I’m not sure > it’s exactly the same. For guix-science I’m trying to provide some packages > like python-jupyterlab, which depend on a mix of packages from guix proper and > newer versions of packages a

bug#44254: Performance of package input rewriting

2020-10-27 Thread zimoun
Hi Lars, On Tue, 27 Oct 2020 at 14:26, Lars-Dominik Braun wrote: > Previously I have been doing this using package-input-rewriting, but starting > an environment containing python-jupyterlab alone took about 20s (warm caches, > all derivations in the store). Manually rewriting inputs by inherit

bug#44254: Performance of package input rewriting

2020-10-27 Thread Lars-Dominik Braun
Hi, this issue is similar to https://issues.guix.gnu.org/41702, but I’m not sure it’s exactly the same. For guix-science I’m trying to provide some packages like python-jupyterlab, which depend on a mix of packages from guix proper and newer versions of packages already included in guix proper. Th