bug#37955: warning: '.desktop' file refers to '', which cannot be found

2022-10-10 Thread Tobias Geerinckx-Rice via Bug reports for GNU Guix
I moved the informational background above the changelog and pushed this to c-u as 685110045c04a60bf18163aab1c230f944c871c9. Thanks! T G-R signature.asc Description: PGP signature

bug#37955: warning: '.desktop' file refers to '', which cannot be found

2022-10-08 Thread Brendan Tildesley
PING. Could the patch I sent get reviewed please? This would apply to core-updates. It's been a while so I don't remember much about it myself actually.

bug#37955: warning: '.desktop' file refers to '', which cannot be found

2021-04-10 Thread Pierre Neidhardt
Brendan Tildesley writes: > Do you mean delete the phase entirely or just from Racket? It's not always > the case that they are absolute paths. Racket probably just has some code to > generate them automatically. Good point! -- Pierre Neidhardt https://ambrevar.xyz/ signature.asc Descripti

bug#37955: warning: '.desktop' file refers to '', which cannot be found

2021-04-09 Thread Brendan Tildesley via Bug reports for GNU Guix
> On 04/09/2021 7:39 PM Pierre Neidhardt wrote: > > > So if the path is already an absolute store path, then I suppose that > the whole phase is superfluous, isn't it? > > Couldn't we just delete it? Do you mean delete the phase entirely or just from Racket? It's not always the case that t

bug#37955: warning: '.desktop' file refers to '', which cannot be found

2021-04-09 Thread Pierre Neidhardt
So if the path is already an absolute store path, then I suppose that the whole phase is superfluous, isn't it? Couldn't we just delete it? -- Pierre Neidhardt https://ambrevar.xyz/ signature.asc Description: PGP signature

bug#37955: warning: '.desktop' file refers to '', which cannot be found

2021-04-09 Thread Brendan Tildesley via Bug reports for GNU Guix
> On 04/09/2021 1:23 PM Pierre Neidhardt wrote: > > > Thanks for the investigation. Would you like to send a patch? I'm not sure what the right way to fix it is. I may have come up with a brilliant idea. Untested patch attached.From 64c200f3630de13ec3487cb5c756b47b133c6ecf Mon Sep 17 00:00:

bug#37955: warning: '.desktop' file refers to '', which cannot be found

2021-04-09 Thread Pierre Neidhardt
Thanks for the investigation. Would you like to send a patch? signature.asc Description: PGP signature

bug#37955: warning: '.desktop' file refers to '', which cannot be found

2021-04-09 Thread Brendan Tildesley via Bug reports for GNU Guix
The Exec paths in these files already refer to absolute paths, infact, /gnu/store paths Thus the regex: ("^Exec=([^/[:blank:]\r\n]*)(.*)$" _ binary rest) with binary = empty string and rest = everything after Exec= Why? The second subexpression [^/[:blank:]\r\n]* is bound to binary, but it mea