bug#35068: GDM crashes when it cannot find any .desktop files

2019-04-27 Thread Ludovic Courtès
Timothy Sample skribis: > Pushed as 8caa458953eeac783c73a0e5aaa72842fe3914c9. Thanks! > I’m closing the bug and the patch. If we want to change the “xinitrc” > script to understand “custom”, we can start a new discussion to figure > out the best way to do it after 1.0. Sounds good. Ludo’.

bug#35068: GDM crashes when it cannot find any .desktop files

2019-04-26 Thread Timothy Sample
Hi Ludo and Danny, Ludovic Courtès writes: > Hello, > > Timothy Sample skribis: > >> There are two workarounds. The first is to keep Danny’s patch as-is, >> but add logic to “xinitrc” so that it only uses “~/.xsession” when >> passed “custom” as an argument (it’s kinda magic, but it seems to b

bug#35068: GDM crashes when it cannot find any .desktop files

2019-04-26 Thread Danny Milosavljevic
Hi Timothy, On Thu, 25 Apr 2019 21:02:53 -0400 Timothy Sample wrote: > Furthermore (I was surprised by this), even though the > “data/Xsession.in” script says that it will honour “custom” in a > comment, the code says otherwise. There’s a commit where support for it > gets removed, but they mus

bug#35068: GDM crashes when it cannot find any .desktop files

2019-04-26 Thread Ludovic Courtès
Hello, Timothy Sample skribis: > There are two workarounds. The first is to keep Danny’s patch as-is, > but add logic to “xinitrc” so that it only uses “~/.xsession” when > passed “custom” as an argument (it’s kinda magic, but it seems to be a > common convention). I have a slight preference f

bug#35068: GDM crashes when it cannot find any .desktop files

2019-04-25 Thread Timothy Sample
Hi Danny, Oh my! I explained things very poorly. Sorry. I’ll provide some more context. Danny Milosavljevic writes: > Hi Timothy, > > On Thu, 25 Apr 2019 14:49:42 -0400 > Timothy Sample wrote: > >> exploding. I did look at Danny’s patch (#35377), and it would work, but >> it seems a little

bug#35068: GDM crashes when it cannot find any .desktop files

2019-04-25 Thread Danny Milosavljevic
Hi Timothy, On Thu, 25 Apr 2019 14:49:42 -0400 Timothy Sample wrote: > exploding. I did look at Danny’s patch (#35377), and it would work, but > it seems a little arbitrary. Nothing understands the “Exec=custom” > line, and our “xinitrc” runs “~/.xsession” regardless of what desktop > entry is

bug#35068: GDM crashes when it cannot find any .desktop files

2019-04-25 Thread Timothy Sample
Hi Ludo and Danny, Date: Thu, 25 Apr 2019 11:36:36 -0400 Ludovic Courtès writes: > Danny Milosavljevic skribis: > >> Apr 21 11:23:57 localhost gdm: XXX gdm: value == NULL for key == PATH >> Apr 21 11:23:57 localhost gdm: Child process -1384 was already dead. >> Apr 21 11:23:57 localhost gdm:

bug#35068: GDM crashes when it cannot find any .desktop files

2019-04-21 Thread Ludovic Courtès
Danny Milosavljevic skribis: > Apr 21 11:23:57 localhost gdm: XXX gdm: value == NULL for key == PATH > Apr 21 11:23:57 localhost gdm: Child process -1384 was already dead. > Apr 21 11:23:57 localhost gdm: Child process 1381 was already dead. > Apr 21 11:23:57 localhost gdm: Unable to kill sess

bug#35068: GDM crashes when it cannot find any .desktop files

2019-04-21 Thread Danny Milosavljevic
Apr 21 11:38:51 localhost gdm: GdmSessionWorkerJob: Running session_worker_job process: gdm-session-worker [pam/gdm-launch-environment] /gnu/store/qz8413ijzxnh6kfkxr8syxjwvhsc6s3a-gdm-3.26.2.1/libexec/gdm-session-worker Apr 21 11:38:51 localhost gdm: GdmSessionWorkerJob: : SessionWorkerJob on p

bug#35068: GDM crashes when it cannot find any .desktop files

2019-04-21 Thread Danny Milosavljevic
Further investigation: diff -ru orig/gdm-3.26.2.1/daemon/gdm-session.c gdm-3.26.2.1/daemon/gdm-session.c --- orig/gdm-3.26.2.1/daemon/gdm-session.c 1970-01-01 01:00:00.0 +0100 +++ gdm-3.26.2.1/daemon/gdm-session.c 2019-04-21 10:58:31.211164558 +0200 @@ -2483,6 +2483,10 @@

bug#35068: GDM crashes when it cannot find any .desktop files

2019-04-20 Thread Ludovic Courtès
Hi, Danny Milosavljevic skribis: > I have the following suggestions for improvements: > > (1) Please back off after trying to login so one can actually debug things. > If the login doesn't work on the first try it won't work on the next 245 tries > in the next second either. > (2) Please have a

bug#35068: GDM crashes when it cannot find any .desktop files

2019-04-20 Thread Danny Milosavljevic
Hi, I just got hit by a similar problem. I've got .xinitrc in my home directory and no .xsession file. The former just invokes startfluxbox. Now after guix system reconfigure, gdm got selected as login manager. After I log in at the gdm prompt, it enters an endless loop, switching terminals wi

bug#35068: GDM crashes when it cannot find any .desktop files

2019-04-01 Thread Ludovic Courtès
Hello, I used to have a config (when using SLiM) where my system profile did not contain any window manager, so no .desktop files. Instead, the WM would be installed in my profile and ~/.xsession would start it and a couple of other things. Unfortunately GDM crashes in that context. More precis