bug#32773: [PATCH] Fix clang libstdc++ header location search

2019-11-19 Thread Mathieu Othacehe
> Thanks for merging this! Would it be possible to change the copyright > to Arm Ltd. but leave my email as the point of contact? Please let me > know if this is an issue. No I guess its ok. Pushed! Mathieu

bug#32773: [PATCH] Fix clang libstdc++ header location search

2019-11-19 Thread David Truby
Hi Mathier, Thanks for merging this! Would it be possible to change the copyright to Arm Ltd. but leave my email as the point of contact? Please let me know if this is an issue. Thanks David Truby On Sun, 2019-11-17 at 12:21 +0100, Mathieu Othacehe wrote: > Hello, > > I edited your patch to inc

bug#32773: [PATCH] Fix clang libstdc++ header location search

2019-11-17 Thread Ludovic Courtès
Mathieu Othacehe skribis: > From ea662ff1ed62183ae0036242f53a14bb0889cb47 Mon Sep 17 00:00:00 2001 > From: Mathieu Othacehe > Date: Thu, 14 Nov 2019 13:25:00 +0100 > Subject: [PATCH] gnu: Add clang-toolchain. > > * gnu/packages/llvm.scm (make-clang-toolchain): New method. > (clang-toolchain): Ne

bug#32773: [PATCH] Fix clang libstdc++ header location search

2019-11-17 Thread Ludovic Courtès
Hello, Mathieu Othacehe skribis: > mathieu@elbruz ~/guix [env]$ ./pre-inst-env guix environment --ad-hoc clang > --pure Isn’t it enough to add ‘ld-wrapper’ to the environment? Thanks, Ludo’.

bug#32773: [PATCH] Fix clang libstdc++ header location search

2019-11-17 Thread Mathieu Othacehe
Hello, I edited your patch to include a copyright line, adapted commit log message to our conventions and pushed it! Please tell me if you want a different copyright. I also pushed my patch adding clang-toolchain packages. Thanks, Mathieu

bug#32773: [PATCH] Fix clang libstdc++ header location search

2019-11-15 Thread Mathieu Othacehe
> I'm not sure what the answer is there though, as we still need to patch > in the full path to the headers... maybe a cmake option and associated > macro to be used in that file? They already have a CMake option to select libc++ or libstdc++, so adding another option to specify the path of the

bug#32773: [PATCH] Fix clang libstdc++ header location search

2019-11-14 Thread David Truby
No problem, happy to help! I'm also vaguely thinking if there's a way to upstream some of this stuff in to clang so that we aren't patching it manually here. The same file that we're patching has stuff specifically for other distros (e.g. it has some Gentoo and Cray Linux specific fixes) so I don'

bug#32773: [PATCH] Fix clang libstdc++ header location search

2019-11-14 Thread Mathieu Othacehe
> Applying both your patch and my patch works for me, in both pure and > non-pure environments. I would suggest taht we also hide clang in the > same way as gcc is hidden (in favour of clang-toolchain) to avoid > confusion, but otherwise it seems these two patches together at least > get things t

bug#32773: [PATCH] Fix clang libstdc++ header location search

2019-11-14 Thread David Truby
Hi Mathieu, Applying both your patch and my patch works for me, in both pure and non-pure environments. I would suggest taht we also hide clang in the same way as gcc is hidden (in favour of clang-toolchain) to avoid confusion, but otherwise it seems these two patches together at least get things

bug#32773: [PATCH] Fix clang libstdc++ header location search

2019-11-14 Thread David Truby
Hi Mathieu, > mathieu@elbruz ~/guix [env]$ ./pre-inst-env guix environment --ad-hoc > clang --pure > mathieu@elbruz ~/guix [env]$ clang ~/tmp/t.cpp > clang-8: error: unable to execute command: Executable "ld" doesn't > exist! > clang-8: error: linker command failed with exit code 1 (use -v to se

bug#32773: [PATCH] Fix clang libstdc++ header location search

2019-11-14 Thread Mathieu Othacehe
> I think adding gcc-toolchain to propagated-inputs should work in > principle, other than the fact that the gcc used for gcc-lib and > libstdc++ need to be the same as the propagated gcc-toolchain. I did > have a fix for this but I'm not sure if it's the best way of writing > it. > I'll send anot

bug#32773: [PATCH] Fix clang libstdc++ header location search

2019-11-14 Thread Mathieu Othacehe
Hello David, This patch is a real progress, thank you! However, I still have a linking error when compiling a trivial test program with clang: mathieu@elbruz ~/guix [env]$ ./pre-inst-env guix environment --ad-hoc clang --pure mathieu@elbruz ~/guix [env]$ clang ~/tmp/t.cpp clang-8: error: unab

bug#32773: [PATCH] Fix clang libstdc++ header location search

2019-11-13 Thread Carl Dong
Hi David! This patch is most welcome, I’m wondering if you think it’d be possible to add more details in the comments for future readers of the code. See below. > On Nov 13, 2019, at 11:56 AM, David Truby wrote: > > +;; Make clang look for libstdc++ in the right >

bug#32773: [PATCH] Fix clang libstdc++ header location search

2019-11-13 Thread David Truby
--- gnu/packages/llvm.scm | 5 + 1 file changed, 5 insertions(+) diff --git a/gnu/packages/llvm.scm b/gnu/packages/llvm.scm index 33fb53d65e..0a7efe980f 100644 --- a/gnu/packages/llvm.scm +++ b/gnu/packages/llvm.scm @@ -202,6 +202,7 @@ compiler. In LLVM this library is called \"compiler-rt\"