bug#30265: Fish embeds store file names in UCS-4/UTF-32 literal strings

2022-10-09 Thread Maxim Cournoyer
Hi, Mark H Weaver writes: > John Soo writes: >> I looked into it and I think a patch to fish might be required but I >> got buried in other work. > > Note that commit 1bab9b9f17256a9e4f45f5b0cceb8b52e0a1b1ed (April 2021) > added support in our grafting code to find and rewrite UTF-16 and UTF-32

bug#30265: Fish embeds store file names in UCS-4/UTF-32 literal strings

2022-10-07 Thread Mark H Weaver
John Soo writes: > I looked into it and I think a patch to fish might be required but I > got buried in other work. Note that commit 1bab9b9f17256a9e4f45f5b0cceb8b52e0a1b1ed (April 2021) added support in our grafting code to find and rewrite UTF-16 and UTF-32 store references. That might have mi

bug#30265: Fish embeds store file names in UCS-4/UTF-32 literal strings

2022-10-07 Thread John Soo
I looked into it and I think a patch to fish might be required but I got buried in other work.

bug#30265: Fish embeds store file names in UCS-4/UTF-32 literal strings

2022-10-07 Thread Maxim Cournoyer
Hello, John Soo writes: > Hi Ludo, > > I am willing to work on this. I use fish as my login shell and noticed some > more funky behavior when I tried to use fish-foreign-env. > > It looks like fish.cpp still uses widestrings. So the references to old store > paths I think become stale, if I un

bug#30265: Fish embeds store file names in UCS-4/UTF-32 literal strings

2022-10-07 Thread Maxim Cournoyer
Hello, John Soo writes: > Hi Ludo, > > I am willing to work on this. I use fish as my login shell and noticed some > more funky behavior when I tried to use fish-foreign-env. > > It looks like fish.cpp still uses widestrings. So the references to old store > paths I think become stale, if I un

bug#30265: Fish embeds store file names in UCS-4/UTF-32 literal strings

2020-03-29 Thread John Soo
Hi Ludo, I am willing to work on this. I use fish as my login shell and noticed some more funky behavior when I tried to use fish-foreign-env. It looks like fish.cpp still uses widestrings. So the references to old store paths I think become stale, if I understand the rest of the conversation.

bug#30265: Fish embeds store file names in UCS-4/UTF-32 literal strings

2019-02-04 Thread Ludovic Courtès
Hi Meiyo, Meiyo Peng skribis: > `guix gc` does not break fish shell any more. I am not sure if this is > related to changes in fish shell v3.0.0. It’s not really ‘guix gc’ that’s problematic but rather grafting: those UCS-4 strings do not get grafted, and eventually become “dangling references

bug#30265: Fish embeds store file names in UCS-4/UTF-32 literal strings

2019-02-01 Thread Meiyo Peng
Hi, `guix gc` does not break fish shell any more. I am not sure if this is related to changes in fish shell v3.0.0. If no one is interested in doing more investigation, maybe we should close this bug. -- Meiyo Peng https://www.pengmeiyu.com/