bug#23170: [PATCH shepherd] Restart dependent services on service restart

2018-08-27 Thread Clément Lassieur
Carlo Zancanaro writes: >>Anyway, it all LGTM, thanks! > > Pushed! Thanks for the review. > > Carlo Awesome! Thanks a lot Carlo for working on this :-)

bug#23170: [PATCH shepherd] Restart dependent services on service restart

2018-08-27 Thread Carlo Zancanaro
On Mon, Aug 27 2018, Ludovic Courtès wrote: I see that you also reverted the patch that removed the ‘EINTR-safe’ workaround. Could you explain why that was necessary? (It should not be necessary with current Guile versions.) I'm not really sure of the details, but as I mentioned on IRC, th

bug#23170: [PATCH shepherd] Restart dependent services on service restart

2018-08-27 Thread Ludovic Courtès
Hi, Carlo Zancanaro skribis: > Pushed! Thanks for the review. Great! I see that you also reverted the patch that removed the ‘EINTR-safe’ workaround. Could you explain why that was necessary? (It should not be necessary with current Guile versions.) Thank you, Ludo’.

bug#23170: [PATCH shepherd] Restart dependent services on service restart

2018-08-26 Thread Carlo Zancanaro
Hey Ludo’! On 27 August 2018 7:08:34 am AEST, l...@gnu.org wrote: >I forgot if this was already done, but perhaps you can add a bit in the manual >to insist that ‘restart’ is not quite the same as ‘stop’ + ‘start’. I hadn't done that, but I have now. There aren't many mentions of restart in th

bug#23170: [PATCH shepherd] Restart dependent services on service restart

2018-08-26 Thread Carlo Zancanaro
Hey Ludo’! On 27 August 2018 7:08:34 am AEST, l...@gnu.org wrote: >I forgot if this was already done, but perhaps you can add a bit in the manual >to insist that ‘restart’ is not quite the same as ‘stop’ + ‘start’. I hadn't done that, but I have now. There aren't many mentions of restart in th

bug#23170: [PATCH shepherd] Restart dependent services on service restart

2018-08-26 Thread Ludovic Courtès
Carlo Zancanaro skribis: > On Sun, Aug 26 2018, Ludovic Courtès wrote: >> I wonder if there are cases where one might want to restart a >> service without restarting its dependent services. We can probably >> ignore it for now, but perhaps we’ll need to add a flag or a >> separate action later.

bug#23170: [PATCH shepherd] Restart dependent services on service restart

2018-08-25 Thread Carlo Zancanaro
On Sun, Aug 26 2018, Ludovic Courtès wrote: I wonder if there are cases where one might want to restart a service without restarting its dependent services. We can probably ignore it for now, but perhaps we’ll need to add a flag or a separate action later. Thoughts? I think this is best se

bug#23170: [PATCH shepherd] Restart dependent services on service restart

2018-08-25 Thread Ludovic Courtès
Hi again! :-) Carlo Zancanaro skribis: > I've written a patch to fix this. It's not super smart, but it should > do the job. I wonder if there are cases where one might want to restart a service without restarting its dependent services. We can probably ignore it for now, but perhaps we’ll ne

bug#23170: [PATCH shepherd] Restart dependent services on service restart

2018-08-25 Thread Carlo Zancanaro
I've written a patch to fix this. It's not super smart, but it should do the job. It currently targets the branch after my patch in #32408[1], but it's technically an independent change. [1]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=32408 From 50dd3ef4888b04ea3b869da893b23ad69fad8971 Mo