Re: Rollback problems

2013-01-28 Thread Ludovic Courtès
Andreas Enge skribis: > Am Sonntag, 27. Januar 2013 schrieb Ludovic Courtès: >> l...@gnu.org (Ludovic Courtès) skribis: >> > Having agreed on linear history, it seems that (a) the current >> > behavior is broken because roll-backs don’t actually follow the >> > history, as illustrated previously,

Re: Rollback problems

2013-01-28 Thread Andreas Enge
Am Sonntag, 27. Januar 2013 schrieb Ludovic Courtès: > l...@gnu.org (Ludovic Courtès) skribis: > > Having agreed on linear history, it seems that (a) the current > > behavior is broken because roll-backs don’t actually follow the > > history, as illustrated previously, and (b) the generation from w

Re: Rollback problems

2013-01-27 Thread Ludovic Courtès
Andreas Enge skribis: > $ guix-package --roll-back > error: no previous profile; not rolling back > > No links are changed. I think in this case, rollback should create the > "empty profile" and have $PERUSER/guix-profile-1-link point to it. Implemented in d930726. Ludo’.

Re: Rollback problems

2013-01-27 Thread Ludovic Courtès
l...@gnu.org (Ludovic Courtès) skribis: > Having agreed on linear history, it seems that (a) the current behavior > is broken because roll-backs don’t actually follow the history, as > illustrated previously, and (b) the generation from which we are rolling > back must be deleted. Commit 82fe08e

Re: Rollback problems

2013-01-25 Thread Ludovic Courtès
Nikita Karetnikov skribis: >> 3. More generally, should the history of generations be linear, or >> should it be a DAG like Git commits? > > If the latter is the case, then we can probably use a simple tree. Here > is a related link: [1]. Right, if we went for a tree, each manifest could c

Re: Rollback problems

2013-01-25 Thread Andreas Enge
Am Freitag, 25. Januar 2013 schrieb Alex Sassmannshausen: > I guess a generation would only be destroyed at a junction, not when > moving back and forth in straight lines. > A --> B --> C > You could travel from C back to A and back to C without having to > re-install packages... Yes, that

Re: Rollback problems

2013-01-25 Thread Alex Sassmannshausen
> > Let me illustrate.  Suppose these generations: > > > A --> B --> C > > > When doing a roll-back from C, one should obviously get back at B.  At > > that point, C would still be available.  Keeping it around means that > > users can easily switch back to C if B turned out to be less

Re: Rollback problems

2013-01-24 Thread Nikita Karetnikov
> No, I disagree; when I have nothing, install hello and roll back, I should be > back to nothing. Some other opinions would be useful on this matter. I agree. Nikita pgpTWEdV44igV.pgp Description: PGP signature

Re: Rollback problems

2013-01-24 Thread Nikita Karetnikov
> 3. More generally, should the history of generations be linear, or > should it be a DAG like Git commits? If the latter is the case, then we can probably use a simple tree. Here is a related link: [1]. > Regarding (3), it seems that a linear history not only simplifies the > implementatio

Re: Rollback problems

2013-01-24 Thread Ludovic Courtès
Hello, So Andreas and I discussed this IRL–we happen to be in the same local GGUUG[*]. Here’s a summary. Issues were: 1. Should generations from which we roll back be kept? 2. If not, should they be deleted directly after a successful roll-back, or just when a new diverging generation

Re: Rollback problems

2013-01-24 Thread Ludovic Courtès
Alex Sassmannshausen skribis: > Is rollback supposed to be one-directional? I.e. you can go back in > time, but you can't then go forward in time again ('undo' and 'redo')? That’s a good question: should undos be stored in the history? IOW, should users be able to undo an undo operation, as is u

Re: Rollback problems

2013-01-24 Thread Alex Sassmannshausen
Hello, For what it's worth, my 2 cents on the issue: - I too think that rollback into an empty profile should be possible. The empty state seems like a valid state to be in for me. On the issue of rollbacks and branches, I like the simplicity of numbers. To try and understand Ludo's suggestion,

Re: Rollback problems

2013-01-24 Thread Ludovic Courtès
Hello! Andreas Enge skribis: > Am Mittwoch, 23. Januar 2013 schrieb Ludovic Courtès: >> And what if you roll back once you’re at the empty profile? > > Then nothing should happen. > >> It seems more intuitive for me to error out like this, because there was >> really nothing but nothingness befo

Re: Rollback problems

2013-01-23 Thread Andreas Enge
Am Mittwoch, 23. Januar 2013 schrieb Ludovic Courtès: > And what if you roll back once you’re at the empty profile? Then nothing should happen. > It seems more intuitive for me to error out like this, because there was > really nothing but nothingness before “hello” was installed. :-) > WDYT? N

Re: Rollback problems

2013-01-23 Thread Ludovic Courtès
Andreas Enge skribis: > $ guix-package -i hello > > This creates a link $HOME/.guix-profile to $PERUSER/guix-profile; the > latter points to the newly created $PERUSER/guix-profile-1-link > > $ guix-package --roll-back > error: no previous profile; not rolling back > > No links are changed. I th

Rollback problems

2013-01-23 Thread Andreas Enge
Rollback does not quite work as expected for me. I am starting without .guix-profile in the home directory, and an empty directory $PREFIX/var/nix/profiles/per-user/$USER (which I will shorten to $PERUSER in the following). $ guix-package -i hello This creates a link $HOME/.guix-profile to $PE