bug#18592: FFI should have portable access to ‘errno’

2016-01-05 Thread tomas
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Tue, Jan 05, 2016 at 10:24:35AM +0800, Chaos Eternal wrote: > On Tue, Jan 5, 2016 at 3:14 AM, Nala Ginrut wrote: > > Hi Mark! > > Thanks for all the advices. > > > > Here's the new patch according to your advices. > > Include: > > 1. Added new proc

bug#18592: FFI should have portable access to ‘errno’

2016-01-05 Thread Nala Ginrut
On Tue, 2016-01-05 at 08:49 +0100, to...@tuxteam.de wrote: > Sorry for intervening from the peanut gallery, but if I understood Mark > correctly, he only was proposing to introduce a second function for the > C API (to keep backward compatibility at the linking-to-C level). At the > Guile source le

bug#18592: FFI should have portable access to ‘errno’

2016-01-05 Thread Mark H Weaver
Nala Ginrut writes: > On Tue, 2016-01-05 at 08:49 +0100, to...@tuxteam.de wrote: >> Sorry for intervening from the peanut gallery, but if I understood Mark >> correctly, he only was proposing to introduce a second function for the >> C API (to keep backward compatibility at the linking-to-C level

bug#18592: FFI should have portable access to ‘errno’

2016-01-05 Thread Mark H Weaver
Hi Nala, In addition to the API issues raised in my previous mail, the other problem with this new patch is that it seems that you converted all tabs to spaces in foreign.c. Please do not change whitespace in lines that would otherwise be unchanged by your patch. I only meant to use spaces in ne

bug#18592: FFI should have portable access to ‘errno’

2016-01-05 Thread Nala Ginrut
Here's updated patch Thanks! On Tue, 2016-01-05 at 10:08 -0500, Mark H Weaver wrote: > More specifically, here's what I'd suggest: > > * A new, static, 'pointer_to_procedure' C function that inherits the > signature and body of 'scm_pointer_to_procedure' but with a new and > required 'return