bug#13809: [PATCH] Support calling foreign functions of 10 or more arguments

2013-02-27 Thread Andy Wingo
Hi! On Tue 26 Feb 2013 23:40, Mark H Weaver writes: > I've attached a patch that implements dynamic allocation of objcode > stubs for larger arities. What do you think? LGTM. Please lazily initialize the vector as well. If you like, CODE and META could probably be reworked as higher-order ma

bug#13827: faulty range check in bytevector accessor

2013-02-27 Thread Ludovic Courtès
Ian Price skribis: > Branch: master > Commit: 9b977c836bf147d386944c401113aba32776fa68 > System: 32 bit x86 Fedora 16 > > (use-modules (rnrs bytevectors)) > (define not-32-bit (expt 2 32)) > (define bv (make-bytevector 4)) > (bytevector-u32-set! bv 0 not-32-bit (endianness big)) > (pk bv) FWIW,

bug#13835: [PATCH] Let reverse! accept arbitrary types as second argument (new_tail)

2013-02-27 Thread David Kastrup
There is no reason to restrict the type of the second argument to proper lists as it is added as last CDR to the list without interpretation. This allows for stack-depth friendly usage (simplified from an actual use case that blew up around my ears) like SCM my_tree_copy (SCM src) { if (scm_is_

bug#13809: [PATCH] Support calling foreign functions of 10 or more arguments

2013-02-27 Thread Mark H Weaver
Hi Andy, Andy Wingo writes: > On Tue 26 Feb 2013 23:40, Mark H Weaver writes: > >> I've attached a patch that implements dynamic allocation of objcode >> stubs for larger arities. What do you think? > > LGTM. Please lazily initialize the vector as well. Okay. > If you like, CODE and META cou

bug#13827: faulty range check in bytevector accessor

2013-02-27 Thread Mark H Weaver
l...@gnu.org (Ludovic Courtès) writes: > Ian Price skribis: > >> Branch: master >> Commit: 9b977c836bf147d386944c401113aba32776fa68 >> System: 32 bit x86 Fedora 16 >> >> (use-modules (rnrs bytevectors)) >> (define not-32-bit (expt 2 32)) >> (define bv (make-bytevector 4)) >> (bytevector-u32-set!

bug#13835: [PATCH] Let reverse! accept arbitrary types as second argument (new_tail)

2013-02-27 Thread Mark H Weaver
David Kastrup writes: > There is no reason to restrict the type of the second argument to proper > lists as it is added as last CDR to the list without interpretation. > > This allows for stack-depth friendly usage [...] Looks good to me. Applied, thanks! Mark