bug#61095: possible misuse of posix_spawn API on non-linux OSes

Hi! Omar Polo skribis: > On 2023/03/30 22:21:28 +0200, Josselin Poiret wrote: >> Hi Ludo, >> >> Ludovic Courtès writes: >> >> > Coming next is an updated patch series addressing this as proposed >> > above. Let me know what y’all think! >> > >> > I tested the ‘posix_spawn_file_actions_addcl

bug#61095: possible misuse of posix_spawn API on non-linux OSes

On 2023/03/30 22:21:28 +0200, Josselin Poiret wrote: > Hi Ludo, > > Ludovic Courtès writes: > > > Coming next is an updated patch series addressing this as proposed > > above. Let me know what y’all think! > > > > I tested the ‘posix_spawn_file_actions_addclosefrom_np’ path by building in: > >

bug#61095: possible misuse of posix_spawn API on non-linux OSes

Hi Ludo, Ludovic Courtès writes: > Coming next is an updated patch series addressing this as proposed > above. Let me know what y’all think! > > I tested the ‘posix_spawn_file_actions_addclosefrom_np’ path by building in: > > guix time-machine --branch=core-updates -- shell -CP -D -f guix.scm

bug#61095: possible misuse of posix_spawn API on non-linux OSes

Hi! Josselin Poiret skribis: > Ludovic Courtès writes: > >> - posix_spawn_file_actions_addclose (actions, fd); >> + /* Adding invalid file descriptors to an 'addclose' action leads >> + to 'posix_spawn' failures on some operating systems: >> +

bug#61095: possible misuse of posix_spawn API on non-linux OSes

Hi Ludo, Ludovic Courtès writes: > - posix_spawn_file_actions_addclose (actions, fd); > + /* Adding invalid file descriptors to an 'addclose' action leads > + to 'posix_spawn' failures on some operating systems: > + . Hence the extra check.

bug#61095: possible misuse of posix_spawn API on non-linux OSes

Hi Omar, Apologies for the late reply. Omar Polo skribis: > I've noticed that test-system-cmds fails on OpenBSD-CURRENT while > testing the update to guile 3.0.9: > > test-system-cmds: system* exit status was 127 rather than 42 > FAIL: test-system-cmds We’re seeing the same failure on

bug#61095: possible misuse of posix_spawn API on non-linux OSes

Actually I can avoid the EBADF by checking that the fd is 'live' with something like fstat: [[[ Index: libguile/posix.c --- libguile/posix.c.orig +++ libguile/posix.c @@ -1325,8 +1325,12 @@ SCM_DEFINE (scm_fork, "primitive-fork", 0, 0, 0, static void close_inherited_fds_slow (posix_spawn_file_ac

bug#61095: possible misuse of posix_spawn API on non-linux OSes

Hello, I've noticed that test-system-cmds fails on OpenBSD-CURRENT while testing the update to guile 3.0.9: test-system-cmds: system* exit status was 127 rather than 42 FAIL: test-system-cmds Here's an excerpt of the ktrace of the child process while executing that specific test: (the fi