bug#13544: (web http) fails to parse numeric timezones in Date header

2013-03-27 Thread Ludovic Courtès
Daniel Hartwig skribis: >>From 430fc9498ee08f6d06b5ec494a5d65e395c6c067 Mon Sep 17 00:00:00 2001 > From: Daniel Hartwig > Date: Fri, 15 Mar 2013 22:25:10 +0800 > Subject: [PATCH] web http: parse numeric time zones in headers > > * module/web/http.scm (parse-zone-offset, normalize-date): New >

bug#13544: (web http) fails to parse numeric timezones in Date header

2013-03-15 Thread Ludovic Courtès
Daniel Hartwig skribis: > From: Daniel Hartwig > Date: Fri, 15 Mar 2013 22:25:10 +0800 > Subject: [PATCH] web http: parse numeric time zones in headers > > * module/web/http.scm (parse-zone-offset, normalize-date): New > procedures. > (parse-rfc-822-date, parse-rfc-850-date, parse-date): Upd

bug#13544: (web http) fails to parse numeric timezones in Date header

2013-03-15 Thread Daniel Hartwig
See attached for handling of numeric time zones that may or may not be GMT. >From 430fc9498ee08f6d06b5ec494a5d65e395c6c067 Mon Sep 17 00:00:00 2001 From: Daniel Hartwig Date: Fri, 15 Mar 2013 22:25:10 +0800 Subject: [PATCH] web http: parse numeric time zones in headers * module/web/http.scm (pa

bug#13544: (web http) fails to parse numeric timezones in Date header

2013-03-15 Thread Daniel Hartwig
On 15 March 2013 15:08, Daniel Hartwig wrote: > Ludo’s patch can be applied with support for arbitrary timezones > removed. Actually, Appendix C (RFC 2616) recommends converting non-GMT tz to GMT: If an HTTP header incorrectly carries a date value with a time zone other than GMT, it MUST be co

bug#13544: (web http) fails to parse numeric timezones in Date header

2013-03-15 Thread Daniel Hartwig
On 14 March 2013 23:00, Andy Wingo wrote: > On Thu 14 Mar 2013 14:34, l...@gnu.org (Ludovic Courtès) writes: > Ok. What about Ludo's original comment, about the extra space in the sqlite header? >>> >>> Dunno. Is it common? In the sample data from last year there were no instances of

bug#13544: (web http) fails to parse numeric timezones in Date header

2013-03-14 Thread Ludovic Courtès
Andy Wingo skribis: > On Thu 14 Mar 2013 14:34, l...@gnu.org (Ludovic Courtès) writes: > Ok. What about Ludo's original comment, about the extra space in the sqlite header? >>> >>> Dunno. Is it common? In this particular case I would mail and try to >>> get them to fix their server,

bug#13544: (web http) fails to parse numeric timezones in Date header

2013-03-14 Thread Andy Wingo
On Thu 14 Mar 2013 14:34, l...@gnu.org (Ludovic Courtès) writes: >>> Ok. What about Ludo's original comment, about the extra space in the >>> sqlite header? >> >> Dunno. Is it common? In this particular case I would mail and try to >> get them to fix their server, given that it is run by hacker

bug#13544: (web http) fails to parse numeric timezones in Date header

2013-03-14 Thread Ludovic Courtès
Andy Wingo skribis: > On Sun 10 Mar 2013 00:50, Daniel Hartwig writes: > >> On 9 March 2013 16:21, Andy Wingo wrote: >>> On Sat 09 Mar 2013 02:41, Daniel Hartwig writes: >>> Interpretting ‘+’ timezone is sensible in a robust implementation, >>> >>> Yes, I agree, this makes sense. >>>

bug#13544: (web http) fails to parse numeric timezones in Date header

2013-03-10 Thread Andy Wingo
On Sun 10 Mar 2013 00:50, Daniel Hartwig writes: > On 9 March 2013 16:21, Andy Wingo wrote: >> On Sat 09 Mar 2013 02:41, Daniel Hartwig writes: >> >>> Interpretting ‘+’ timezone is sensible in a robust implementation, >> >> Yes, I agree, this makes sense. >> >>> though what to do if a numer

bug#13544: (web http) fails to parse numeric timezones in Date header

2013-03-09 Thread Daniel Hartwig
On 9 March 2013 16:21, Andy Wingo wrote: > On Sat 09 Mar 2013 02:41, Daniel Hartwig writes: > >> Interpretting ‘+’ timezone is sensible in a robust implementation, > > Yes, I agree, this makes sense. > >> though what to do if a numeric timezone is given other than this? > > I would continue t

bug#13544: (web http) fails to parse numeric timezones in Date header

2013-03-09 Thread Andy Wingo
On Sat 09 Mar 2013 02:41, Daniel Hartwig writes: > Interpretting ‘+’ timezone is sensible in a robust implementation, Yes, I agree, this makes sense. > though what to do if a numeric timezone is given other than this? I would continue to raise an error I think. Timezones get complicated,

bug#13544: (web http) fails to parse numeric timezones in Date header

2013-03-08 Thread Daniel Hartwig
On 9 March 2013 09:41, Daniel Hartwig wrote: > A survey of HTTP sites I performed > last year as research for another header issue in Guile showed > something like 1% of those sites using the numeric timezone format, > contrary to the specification. Reference:

bug#13544: (web http) fails to parse numeric timezones in Date header

2013-03-08 Thread Daniel Hartwig
On 8 March 2013 06:28, Andy Wingo wrote: > On Thu 24 Jan 2013 23:13, l...@gnu.org (Ludovic Courtès) writes: > >> scheme@(guile-user)> (use-modules(web client)(web uri)) >> scheme@(guile-user)> (http-get (string->uri "http://www.sqlite.org/";)) >> web/http.scm:768:6: In procedure parse-asctime-date

bug#13544: (web http) fails to parse numeric timezones in Date header

2013-03-07 Thread Andy Wingo
On Thu 24 Jan 2013 23:13, l...@gnu.org (Ludovic Courtès) writes: > scheme@(guile-user)> (use-modules(web client)(web uri)) > scheme@(guile-user)> (http-get (string->uri "http://www.sqlite.org/";)) > web/http.scm:768:6: In procedure parse-asctime-date: > web/http.scm:768:6: Bad Date header: Thu, 24

bug#13544: (web http) fails to parse numeric timezones in Date header

2013-01-24 Thread Ludovic Courtès
--8<---cut here---start->8--- scheme@(guile-user)> (use-modules(web client)(web uri)) scheme@(guile-user)> (http-get (string->uri "http://www.sqlite.org/";)) web/http.scm:768:6: In procedure parse-asctime-date: web/http.scm:768:6: Bad Date header: Thu, 24 Jan 20