bug#18592: FFI should have portable access to ‘errno’

2016-01-04 Thread Chaos Eternal
On Tue, Jan 5, 2016 at 3:14 AM, Nala Ginrut wrote: > Hi Mark! > Thanks for all the advices. > > Here's the new patch according to your advices. > Include: > 1. Added new procedure pointer->procedure-with-errno with > #:return-errno? > > Question: Should we make #:return-errno? true in default? Thi

bug#18592: FFI should have portable access to ‘errno’

2016-01-04 Thread Nala Ginrut
Hi Mark! Thanks for all the advices. Here's the new patch according to your advices. Include: 1. Added new procedure pointer->procedure-with-errno with #:return-errno? Question: Should we make #:return-errno? true in default? This would make the name *-with-errno more reasonable. At present, it's

bug#18592: FFI should have portable access to ‘errno’

2016-01-04 Thread Mark H Weaver
One more thing I forgot to mention: These two commits should be combined into a single commit. Thanks! Mark

bug#18592: FFI should have portable access to ‘errno’

2016-01-04 Thread Mark H Weaver
Hi Nala, Thanks for working on this :) Please see below for comments. Nala Ginrut writes: > From 88a99af4b5db9096c3cde51c72eb371b6be76754 Mon Sep 17 00:00:00 2001 > From: Nala Ginrut > Date: Thu, 31 Dec 2015 20:27:59 +0800 > Subject: [PATCH 1/2] Add option to pointer->procedure to return errno

bug#18592: FFI should have portable access to ‘errno’

2016-01-04 Thread Nala Ginrut
Resubmit since errno should be stored after ffi_call. >From 88a99af4b5db9096c3cde51c72eb371b6be76754 Mon Sep 17 00:00:00 2001 From: Nala Ginrut Date: Thu, 31 Dec 2015 20:27:59 +0800 Subject: [PATCH 1/2] Add option to pointer->procedure to return errno if necessary --- libguile/foreign.c | 33