Some tests with timeout erroneously skipped on Debian

2010-04-11 Thread Stefano Lattarini
Hello everybody. When I run the testsuite of GNU grep (from latest git master) on my Debian unstable system, some tests are skipped with the message: TEST-NAME: skipped test: your system lacks the timeout program The list of tests skipped for this reason is: empty fgrep-infloop sjis-mb Howeve

Re: [PATCH] dfa: don't overrun a malloc'd buffer for certain regexps

2011-06-17 Thread Stefano Lattarini
Hi Jim. Sorry to jump in just to be nitpicky, but ... On Friday 17 June 2011, Jim Meyering wrote: > If you give your favorite grep program the wrong ERE, > it may clobber the heap: > > $ grep -E '(^| )*(a|b)*(c|d)*( |$)' < /dev/null > [Exit 139 (SEGV)] > > This bug affects gawk, too, si

Re: [PATCH 1/2] tests: make test runner a script, not a shell function

2011-06-20 Thread Stefano Lattarini
[Adding bug-grep, dropping bug-coreutils and automake-patches] Reference: On Sunday 19 June 2011, Jim Meyering wrote: > Thank you! > That patch looks fine modulo two typos. > I'm folding in these corrections and have adjust

Re: [PATCH 1/2] tests: make test runner a script, not a shell function

2011-06-20 Thread Stefano Lattarini
On Monday 20 June 2011, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Mon, Jun 20, 2011 at 10:22:28AM CEST: > > [Adding bug-grep, dropping bug-coreutils and automake-patches] > > re-adding the latter. > > > I've noticed that grep uses a definition of TESTS_EN

Re: [PATCH 1/2] tests: make test runner a script, not a shell function

2011-06-20 Thread Stefano Lattarini
On Monday 20 June 2011, Ralf Wildenhues wrote: > * Jim Meyering wrote on Mon, Jun 20, 2011 at 10:29:50PM CEST: > > Ralf Wildenhues wrote: > > > One thing I've regularly done with new code that is not 100% backward > > > compatible is have a new Automake option for them. That is exactly why > > > t

Re: [PATCH 1/2] tests: make test runner a script, not a shell function

2011-06-21 Thread Stefano Lattarini
On Tuesday 21 June 2011, Ralf Wildenhues wrote: > * Stefano Lattarini wrote on Mon, Jun 20, 2011 at 11:12:23PM CEST: > > Maybe we should also say that using TESTS_ENVIRONMENT to define a custom > > test runner is now not only strongly deprecated (as it already was I hope), &g

Re: [PATCH 1/2] tests: make test runner a script, not a shell function

2011-06-21 Thread Stefano Lattarini
On Tuesday 21 June 2011, Jim Meyering wrote: > Stefano Lattarini wrote: > > On Tuesday 21 June 2011, Ralf Wildenhues wrote: > >> * Stefano Lattarini wrote on Mon, Jun 20, 2011 at 11:12:23PM CEST: > >> > Maybe we should also say that using TESTS_ENVIRONMENT to define

Re: the release of grep-2.9 is imminent

2011-06-21 Thread Stefano Lattarini
On Tuesday 21 June 2011, Jim Meyering wrote: > Jim Meyering wrote: > > I'm prepared to release grep-2.9. > > There have been more than enough fixes since 2.8: > > (from NEWS): > > > > grep no longer clobbers heap for an ERE like '(^| )*( |$)' > > [bug introduced in grep-2.6] > > > > gre

Re: [PATCH 1/2] tests: make test runner a script, not a shell function

2011-06-21 Thread Stefano Lattarini
On Monday 20 June 2011, Stefano Lattarini wrote: > > [SNIP] > > To quote from the added NEWS entry: > > - The parallel-tests driver is now implemented (partly at least) with > the help of automake-provided auxiliary scripts (e.g., `test-driver'), > instead o

Re: the release of grep-2.9 is imminent

2011-06-21 Thread Stefano Lattarini
On Tuesday 21 June 2011, Jim Meyering wrote: > Stefano Lattarini wrote: > ... > >> FYI, I've just pushed the following. > >> Now, I expect to tag grep-2.9 and release later today. > >> Last chance... > >> > > On NetBSD 5.1, I'm seeing

[PATCH] {master} tests: interactions between TESTS_ENVIRONMENT and LOG_COMPILER

2011-06-21 Thread Stefano Lattarini
On Tuesday 21 June 2011, Stefano Lattarini wrote: > On Monday 20 June 2011, Stefano Lattarini wrote: > > > > [SNIP] > > > > To quote from the added NEWS entry: > > > > - The parallel-tests driver is now implemented (partly at least) with > > th

Re: [PATCH 01/34] maint: convert #if-MBS_SUPPORT (kwsinit)

2011-09-15 Thread Stefano Lattarini
Hi Jim. On Thursday 15 September 2011, Jim Meyering wrote: > From: Jim Meyering > > * src/searchutils.c (kwsinit): Remove in-function #if MBS_SUPPORT. > --- > src/searchutils.c |6 +- > 1 files changed, 1 insertions(+), 5 deletions(-) > > diff --git a/src/searchutils.c b/src/searchutil

[PATCH 2/3] tests: tiny simplification in TESTS_ENVIRONMENT definition

2011-10-10 Thread Stefano Lattarini
* tests/Makefile.am (TESTS_ENVIRONMENT): Remove redundant use of `export'. --- tests/Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 736df9e..13d3ca6 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -121,7 +

[PATCH 1/3] tests: support development version of automake too

2011-10-10 Thread Stefano Lattarini
This change implements a more correct and idiomatic use of the features of the Automake-provided 'parallel-tests' harness. Moreover, this change is required in order for the testsuite to continue to work with the new testsuite harness that is planned to be introduced in Automake 1.12 (which, as of

[PATCH 3/3] gitignore: merge top-level and tests/ .gitignore files

2011-10-10 Thread Stefano Lattarini
* tests/.gitignore: Remove; what little remained of its contents has been moved ... * .gitignore: ... here. --- .gitignore |5 + tests/.gitignore |5 - 2 files changed, 5 insertions(+), 5 deletions(-) delete mode 100644 tests/.gitignore diff --git a/.gitignore b/.gitignore

Re: [PATCH 2/3] tests: tiny simplification in TESTS_ENVIRONMENT definition

2011-10-10 Thread Stefano Lattarini
On Monday 10 October 2011, Paolo Bonzini wrote: > On 10/10/2011 02:32 PM, Stefano Lattarini wrote: > > * tests/Makefile.am (TESTS_ENVIRONMENT): Remove redundant use of > > `export'. > > --- > > tests/Makefile.am |2 +- > > 1 files changed, 1 insertions

Re: [PATCH 2/3] tests: tiny simplification in TESTS_ENVIRONMENT definition

2011-10-10 Thread Stefano Lattarini
Hi Jim, thanks for the quick answer. On Monday 10 October 2011, Jim Meyering wrote: > Stefano Lattarini wrote: > > * tests/Makefile.am (TESTS_ENVIRONMENT): Remove redundant use of > > `export'. > > --- > > tests/Makefile.am |2 +- > > 1 files

"make dist" fails if I delete the dummy ChangeLog

2011-10-10 Thread Stefano Lattarini
y, in the hope you might share my preferences on this matter. Regards, Stefano From a633a041a75ffc3398c8dcc73e5b67db65a7f1f6 Mon Sep 17 00:00:00 2001 Message-Id: From: Stefano Lattarini Date: Mon, 10 Oct 2011 17:03:09 +0200 Subject: [PATCH] dist: better automatic generation of Chan

[PATCH] distcheck: ensure dist-hook fails if syntax-check fails

2011-10-13 Thread Stefano Lattarini
* Makefile.am (run-syntax-check): Fix logic, to ensure that the recipe of this target returns a non-zero exit status if "make syntax-check" fails. --- Makefile.am |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.am b/Makefile.am index a13f262..e9005d7 100644 --- a

Re: "make dist" fails if I delete the dummy ChangeLog

2011-10-13 Thread Stefano Lattarini
On Thursday 13 October 2011, Jim Meyering wrote: > Stefano Lattarini wrote: > > On my Debian GNU/Linux system: > > > > $ cd ~/src/grep > > $ rm -f ChangeLog > > $ make dist > > make: *** No rule to make target `ChangeLog', needed by `dist

Re: [PATCH] distcheck: ensure dist-hook fails if syntax-check fails

2011-10-16 Thread Stefano Lattarini
Hi Jim. On Friday 14 October 2011, Jim Meyering wrote: > Stefano Lattarini wrote: > > * Makefile.am (run-syntax-check): Fix logic, to ensure that > > the recipe of this target returns a non-zero exit status if > > "make syntax-check" fails. > > Good catch.

Re: [PATCH] distcheck: ensure dist-hook fails if syntax-check fails

2011-10-16 Thread Stefano Lattarini
On Sunday 16 October 2011, Jim Meyering wrote: > > Thanks. However, I run the syntax-checks solely from srcdir builds. > For me at least, imposing the VPATH regimen for that rule is an added > maintenance burden (and slight obfuscation) that brings little to no benefit. > Perfectly fine by me; I

Re: "make dist" fails if I delete the dummy ChangeLog

2011-10-25 Thread Stefano Lattarini
Hi Jim. On Thursday 13 October 2011, Stefano Lattarini wrote: > > Also, I've made the recipe more customizable, allowing overrides of the > build-aux directory, and allowing an empty "start date" (which will mean > "give me all the git log entries, from the roo

Re: grep-2.9.69-f91c on OSF/1

2011-11-11 Thread Stefano Lattarini
> + doc: mention export portability hint > + * doc/autoconf.texi (Limitations of Builtins) : Document > + export limitation. > + Suggested by Bruno Haible. > + > 2011-10-21 Stefano Lattarini > > fortran: define $GFC to "yes" if $FC is a GNU

Re: grep-2.9.69-f91c on OSF/1

2011-11-12 Thread Stefano Lattarini
Hi Bruno. On Saturday 12 November 2011, Bruno Haible wrote: > Jim Meyering wrote: > > +it is probably because you are using non-GNU-make with an old /bin/sh. If > > so, > > sed 's/with an old/or an old/ > > The workaround is to use GNU make *and* a different SHELL. > My understanding is that,

Re: grep-2.9.69-f91c on OSF/1

2011-11-12 Thread Stefano Lattarini
Hi Bruno. On Saturday 12 November 2011, Bruno Haible wrote: > Jim Meyering wrote: > > > 2011-11-11 Bruno Haible > > > > > > Fix test suite execution failure on OSF/1 5.1. > > > * tests/Makefile.am (TESTS_ENVIRONMENT): Use only the portable form > > > of > > > the 'export' she

Re: grep-2.9.69-f91c on OSF/1

2011-11-12 Thread Stefano Lattarini
On Saturday 12 November 2011, Jim Meyering wrote: > Stefano Lattarini wrote: > > This might cause annoying slow-downs on systems where forks are more > > expensive (i.e., MinGW and Cygwin). What about doing something like > > this instead, so that the extra forks are avoi

Re: grep-2.9.69-f91c on OSF/1

2011-11-12 Thread Stefano Lattarini
On Saturday 12 November 2011, Jim Meyering wrote: > > Thanks for the suggestion. > I was leaning towards accepting it, but then checked... > > When /bin/sh is a link to bash, that envvar is not set here (F16): > Because it's not an environment variable, but only a shell variable :-) Which makes se

Re: failure in building gnulib tests wih pcc on debian

2011-11-15 Thread Stefano Lattarini
On Tuesday 15 November 2011, Bruno Haible wrote: > Eric Blake wrote: > > > ... on an unstable Debian using pcc > > > (Portable C Compiler, version 1.1.0~DEVEL+20110422-1 > > ... > > Warnings like this, and the error in test-float.c, mean that all other > > packages using the same gnulib modules wil

Re: grep-2.10 on OSF/1

2011-11-21 Thread Stefano Lattarini
On Monday 21 November 2011, Jim Meyering wrote: > > +# Given compare_dev_null_'s preprocessing, for 0 or 2, defer to compare_. > This comments should be adjusted as well, I think. > +# Otherwise, differences have already been printed, so return 1. > +compare () > +{ > + compare_dev_null_ "$@" >

Re: [PATCH 1/4] grep: don't say "write error" over and over

2012-02-08 Thread Stefano Lattarini
Hi Paul, just a quick outsider nit ... On 02/08/2012 08:22 PM, Paul Eggert wrote: > Thanks for reviewing that. What a mess! > An odd thing is that the patch *did* fix things for > Fedora 15. Maybe its shell is busted? But that's a > different matter. > > I think we can address this particular

Re: Emulating old -r functionality.

2012-12-19 Thread Stefano Lattarini
On 12/19/2012 05:44 PM, Paolo Bonzini wrote: > > [SNIP] > > ** New features > > If no file operand is given, and a command-line -r or equivalent > option is given, grep now searches the working directory. Formerly > grep ignored the -r and searched standard input nonrecursively. > An -r

bug#15441: [PATCH] tests: ensure neither \s nor \S matches an invalid multibyte character

2013-09-23 Thread Stefano Lattarini
Hi Jim. On 09/23/2013 06:18 AM, Jim Meyering wrote: Here's a test for the original problem, which is also fixed by the preceding patch: ... > +grep '^\S$' in > out-S && fail=1 > +compare /dev/null out-S || exit=1 > Shouldn't this be "|| fail=1"? > +grep '^\s$' in > out-s && fail=1 > +compar

bug#15759: bug#15758: grep 2.15 calls abort() on larger searches with -P

2013-10-30 Thread Stefano Lattarini
merge 15758 15759 stop bug#15758 is the same as bug#15759, so I'm merging them, to avoid confusion or the risk of dispersing the discussion. Regards, Stefano

bug#15773: grep-2.15 bug report

2013-11-01 Thread Stefano Lattarini
Hi Jim. On 11/01/2013 03:15 PM, Jim Meyering wrote: On Fri, Nov 1, 2013 at 12:53 AM, Aharon Robbins wrote: Hello All. After updating from 2.14 to 2.15 grep has started to fail to match patterns that contain '\s*' or '\s\+' And here's a proper patch, including NEWS and test suite additions:

bug#15773: grep-2.15 bug report

2013-11-02 Thread Stefano Lattarini
On 11/02/2013 03:20 PM, Jim Meyering wrote:> On Fri, Nov 1, 2013 at 8:55 AM, Stefano Lattarini > wrote: >> This probably calls for a two patch series: the first introducing the test >> as >> an XFAIL, the second fixing the bug without touching the tests, and >&