bug#20526: grep BUG: text file is detected as binary

2016-01-08 Thread Norihiro Tanaka
On Wed, 6 Jan 2016 09:57:46 -0800 Paul Eggert wrote: > On 01/06/2016 12:32 AM, Paul Eggert wrote: > > I installed the attached patch, which fixed this performance bug for me. > Whoops! I forgot to 'git add src/search.h' before committing. We also need > the attached followup patch, which I ins

bug#22103: bug#20526: grep BUG: text file is detected as binary

2016-01-08 Thread Norihiro Tanaka
On Wed, 6 Jan 2016 09:57:46 -0800 Paul Eggert wrote: > On 01/06/2016 12:32 AM, Paul Eggert wrote: > > I installed the attached patch, which fixed this performance bug for me. > Whoops! I forgot to 'git add src/search.h' before committing. We also need > the attached followup patch, which I ins

bug#20526: grep BUG: text file is detected as binary

2016-01-08 Thread Paul Eggert
Paul Eggert wrote: I missed the possibility of a unibyte encoding where not all bytes are valid unibyte characters. I found a significant performance problem related to that bug and bug fix, and installed the attached further patch 0001. Come to think of it, this issue should be in NEWS too,

bug#22181: endless loop in grep 2.22

2016-01-08 Thread Paul Eggert
On 01/07/2016 09:47 PM, Jim Meyering wrote: FAIL: encoding-error ... --- exp 2016-01-07 21:39:42.018646618 -0800 +++ out 2016-01-07 21:39:42.018646618 -0800 @@ -1 +1 @@ -Binary file in matches +Pedro P\xe9rez + fail=1 I can't reproduce that in Fedora 23 x86-64, which is usi

bug#22181: endless loop in grep 2.22

2016-01-08 Thread Jim Meyering
On Fri, Jan 8, 2016 at 8:50 AM, Paul Eggert wrote: > On 01/07/2016 09:47 PM, Jim Meyering wrote: >> >> FAIL: encoding-error >> >> ... >> --- exp 2016-01-07 21:39:42.018646618 -0800 >> +++ out 2016-01-07 21:39:42.018646618 -0800 >> @@ -1 +1 @@ >> -Binary file in matches >> +Ped

bug#22103: bug#20526: grep BUG: text file is detected as binary

2016-01-08 Thread Jim Meyering
On Fri, Jan 8, 2016 at 5:46 AM, Norihiro Tanaka wrote: > > On Wed, 6 Jan 2016 09:57:46 -0800 > Paul Eggert wrote: > >> On 01/06/2016 12:32 AM, Paul Eggert wrote: >> > I installed the attached patch, which fixed this performance bug for me. >> Whoops! I forgot to 'git add src/search.h' before comm

bug#22181: endless loop in grep 2.22

2016-01-08 Thread Jim Meyering
On Fri, Jan 8, 2016 at 1:32 PM, Jim Meyering wrote: > On Fri, Jan 8, 2016 at 8:50 AM, Paul Eggert wrote: >> On 01/07/2016 09:47 PM, Jim Meyering wrote: >>> >>> FAIL: encoding-error >>> >>> ... >>> --- exp 2016-01-07 21:39:42.018646618 -0800 >>> +++ out 2016-01-07 21:39:42.018

bug#22181: endless loop in grep 2.22

2016-01-08 Thread Paul Eggert
Jim Meyering wrote: It was trivial: printf does not necessarily support \xHH hexadecimal escapes. Thanks for catching that. I looked and found one other problem of that kind. I tried running the tests on Solaris and AIX and found a few more porting issues in the grep tests, and installed the