bug#18738: Reference of a uninitialized variable in grep -P

2014-10-15 Thread Norihiro Tanaka
A variable validated_boundary is used in grep -P. However, it isn't initialized correctly. I found that it causes reference of the uninitialized variable and wrong result. $ echo . | env LC_ALL=C src/grep -P . $ echo . | env LC_ALL=en_US.utf8 src/grep -P . We expect that they return each on

bug#18738: Reference of a uninitialized variable in grep -P

2014-10-15 Thread Paul Eggert
Thanks for reporting that. It's a bug in one of the optimizations I recently added to work around the libpcre slownesses with UTF-8. It's also a bug in our test cases, which should have caught the bug. I fixed it with the attached patch. >From bc66a23879afc54063708afce4f79d0928e444c0 Mon Sep

bug#18738: Reference of a uninitialized variable in grep -P

2014-10-15 Thread Norihiro Tanaka
Paul Eggert wrote: > Thanks for reporting that. It's a bug in one of the optimizations I > recently added to work around the libpcre slownesses with UTF-8. > It's also a bug in our test cases, which should have caught the bug. > I fixed it with the attached patch. Thanks for fixing that. BTW, va

bug#18738: Reference of a uninitialized variable in grep -P

2014-10-15 Thread Paul Eggert
Norihiro Tanaka wrote: BTW, validation_boundary isn't initialized before pre-searching for an empty line Oh, so *that's* the uninitialized variable you were referring to! Sorry, I didn't know. Yes, it should be initialized; it's not portable to assume that NULL < valid pointers. I install