On Mon, Apr 21, 2025 at 12:20 AM Jaroslav Škarvada wrote:
> > $ { env printf %4095s; env printf %4096s; } > /dev/full
> > printf: write error: Broken pipe
> > printf: write error
> >
> Guys, thanks for the analysis and quick actions. BTW is the Fedora
> help patch which uncovered this
On Fri, Apr 18, 2025 at 7:35 AM Grisha Levit wrote:
>
> On Fri, Apr 18, 2025, 01:18 Jim Meyering wrote:
> >
> > On Tue, Apr 15, 2025 at 9:17 PM Jim Meyering wrote:
> > ...
> > > We're going to have to revise that code.
> > > The difference I see is that before rawhide, that fclose would fail.
>
Pádraig Brady wrote:
> bs=0
> ws=4095: printf: write error
> ws=4096: printf: write error
> ws=4097: printf: write error
> bs=4096
> ws=4095: printf: write error: No space left on device
> ws=4096: printf: write error
> ws=4097: printf: write error
> bs=8192
> ws=4095: printf: w
On 18/04/2025 06:18, Jim Meyering wrote:
On Tue, Apr 15, 2025 at 9:17 PM Jim Meyering wrote:
...
We're going to have to revise that code.
The difference I see is that before rawhide, that fclose would fail.
It's perfectly fine for fclose to succeed in this case, as now happens
on rawhide (becau
On Fri, Apr 18, 2025 at 2:58 AM Jim Meyering wrote:
>
> Now, as for what changed in F42 to make us go from printing the ENOSPC
> expansion to not printing it, so far I haven't reproduced the failure.
> Just built there and this works just as it does on F41:
>
> $ src/grep --help > /dev/full
>
>
On Thu, Apr 17, 2025 at 11:15 PM Grisha Levit wrote:
>
> On Fri, Apr 18, 2025 at 1:51 AM Jim Meyering wrote:
> >
> > Surprised to find that coreutils-9.5 (fedora 41 stock) works fine:
> >
> > $ { /bin/printf %4095s; /bin/printf %4096s; } > /dev/full
> > /bin/printf: write error: No space left
On Fri, Apr 18, 2025 at 1:51 AM Jim Meyering wrote:
>
> Surprised to find that coreutils-9.5 (fedora 41 stock) works fine:
>
> $ { /bin/printf %4095s; /bin/printf %4096s; } > /dev/full
> /bin/printf: write error: No space left on device
> /bin/printf: write error: No space left on device
Th
On Tue, Apr 15, 2025 at 9:17 PM Jim Meyering wrote:
...
> We're going to have to revise that code.
> The difference I see is that before rawhide, that fclose would fail.
> It's perfectly fine for fclose to succeed in this case, as now happens
> on rawhide (because with 4k BUFSIZ, the fclose wrote
On Thu, Apr 17, 2025 at 10:35 PM Grisha Levit wrote:
> On Fri, Apr 18, 2025, 01:18 Jim Meyering wrote:
> >
> > On Tue, Apr 15, 2025 at 9:17 PM Jim Meyering wrote:
> > ...
> > > We're going to have to revise that code.
> > > The difference I see is that before rawhide, that fclose would fail.
> >
On Fri, Apr 18, 2025, 01:18 Jim Meyering wrote:
>
> On Tue, Apr 15, 2025 at 9:17 PM Jim Meyering wrote:
> ...
> > We're going to have to revise that code.
> > The difference I see is that before rawhide, that fclose would fail.
> > It's perfectly fine for fclose to succeed in this case, as now ha
On Tue, Apr 15, 2025 at 8:32 PM Jim Meyering wrote:
> On Tue, Apr 15, 2025 at 7:26 PM Grisha Levit wrote:
> > On Tue, Apr 15, 2025 at 9:54 PM Jim Meyering wrote:
> > > Whoa. Thanks. It looks like this is a >19-year-old bug in stream-close.c
> > > Here's a tentative fix -- the ChangeLog entry sti
On Tue, Apr 15, 2025 at 7:26 PM Grisha Levit wrote:
> On Tue, Apr 15, 2025 at 9:54 PM Jim Meyering wrote:
> > Whoa. Thanks. It looks like this is a >19-year-old bug in stream-close.c
> > Here's a tentative fix -- the ChangeLog entry still lacks details of
> > when it was introduced:
>
> - if
On Tue, Apr 15, 2025 at 9:54 PM Jim Meyering wrote:
> Whoa. Thanks. It looks like this is a >19-year-old bug in stream-close.c
> Here's a tentative fix -- the ChangeLog entry still lacks details of
> when it was introduced:
- if (! fclose_fail)
+ if (!fclose_fail && !prev_fail)
On Tue, Apr 15, 2025 at 4:12 PM Grisha Levit wrote:
>
> On Tue, Apr 15, 2025 at 6:38 PM wrote:
> >
> > >> This seems to be fixed if the patch here [1] is _not_ applied when
> > >> building the RPM
> >
> > Can you check, perhaps using strace, whether that problematic patch pushes
> > the total amo
On Tue, Apr 15, 2025 at 6:38 PM wrote:
>
> >> This seems to be fixed if the patch here [1] is _not_ applied when
> >> building the RPM
>
> Can you check, perhaps using strace, whether that problematic patch pushes
> the total amount of bytes written to stdout by grep, writing to /dev/full as
> yo
>> This seems to be fixed if the patch here [1] is _not_ applied when
>> building the RPM
Can you check, perhaps using strace, whether that problematic patch pushes
the total amount of bytes written to stdout by grep, writing to /dev/full as you
invoke it, goes from a little below 4096 bytes, in a
On Tue, Apr 15, 2025 at 6:53 AM Jaroslav Škarvada via Bug reports for
GNU grep wrote:
> With the 3.12 build from the sources:
> # yes 12345 | head -n 5 > in
> # strace -o out -- ./grep -q --help >/dev/full
> ./grep: write error
>
This seems to be fixed if the patch here [1] is _not_ applied w
Oh, sorry, I hadn't seen the email between you and Jim.
I am suspicious that rawhide gettext doesn't preserve errno. Could you
please run the built grep under gdb as follows and say what happens to
errno? The following transcript is on Fedora 41 where things work as
expected (ENOSPC == 28):
Thanks for the bug report. What is the output of the following command
on Fedora rawhide?
LC_ALL=C strace src/grep -q --help >/dev/full
On my Fedora 41 x86-64 host, the output of the above command ends as
follows; what's different on your platform?
sigaltstack({ss_sp=0x429f40, ss_flags=0, ss
On the system where the test failed (fedora 43/rawhide):
# yes 12345 | head -n 5 > in
# strace -o out -- grep -q --help >/dev/full
grep: write error: No space left on device
write(1, "Usage: grep [OPTION]... PATTERNS"..., 4068) = -1 ENOSPC (No
space left on device)
It's the system grep 3.11.
On Mon, Apr 14, 2025 at 5:56 AM Jaroslav Škarvada via Bug reports for
GNU grep wrote:
> test log is attached
Hi Jaroslav,
Thanks for testing!
The test that's failing is ensuring that a disk-full write failure
elicits a diagnostic like this:
grep: write error: No space left on device
On your s
Hi,
test log is attached
thanks & regards
Jaroslav
=
GNU grep 3.12: tests/test-suite.log
=
# TOTAL: 128
# PASS: 117
# SKIP: 8
# XFAIL: 2
# FAIL: 1
# XPASS: 0
# ERROR: 0
System information (uname -a): Linux 6.
22 matches
Mail list logo
