bug#74159: Unexpected exit code of 0 when -q is set and close_stdout fails

2024-11-03 Thread Jan Černohorský
Thank you for your very swift reply and fix. when the `-q` option is detected (grep.c:2697), the `exit_failure` variable is set to 0. This causes any error, when not specially handled, to exit with 0, even before any match is found. Yes, that's a mistake. I can't reproduce your bug but I can

bug#74159: Unexpected exit code of 0 when -q is set and close_stdout fails

2024-11-02 Thread Martin Schulte
Hello Jan! On Fri, 1 Nov 2024 14:10:43 +0100 you wrote: > https://grsc.cz/blog/loffice-linux-issues/, but it's mostly not relevant > for this bug). While I can't help you with grep/operating system issue I suggest replacing if echo "$checks" | grep -q "cc" ; then by if [ ${#checks} -gt 1 ] ;

bug#74159: Unexpected exit code of 0 when -q is set and close_stdout fails

2024-11-01 Thread Paul Eggert
On 2024-11-01 06:10, Jan Černohorský wrote: when the `-q` option is detected (grep.c:2697), the `exit_failure` variable is set to 0. This causes any error, when not specially handled, to exit with 0, even before any match is found. Yes, that's a mistake. I can't reproduce your bug but I can

bug#74159: Unexpected exit code of 0 when -q is set and close_stdout fails

2024-11-01 Thread Jan Černohorský
Hello, I've encountered a particularly interesting bug in GNU grep yesterday while hunting some issues with LibreOffice (if you're interested in the whole post-mortem, it can be read here: https://grsc.cz/blog/loffice-linux-issues/, but it's mostly not relevant for this bug). Whenever the `