On 4/11/23 23:08, Carlo Arenas wrote:
Yes. but I would probably prefer voiding the return value to make it explicit.
Thanks for checking. Casting expressions to void is not our style so
I'll omit that (the comment makes things obvious to the reader anyway).
So I installed the patch without th
On Tue, Apr 11, 2023 at 3:11 PM Paul Eggert wrote:
>
> On 4/10/23 23:47, Carlo Arenas wrote:
> > The original code was done in a way that would be useful during
> > porting, but that would hinder future work unnecessarily.
>
> Thanks, but wouldn't the attached patch be better?
Yes. but I would pr
On 4/10/23 23:47, Carlo Arenas wrote:
The original code was done in a way that would be useful during
porting, but that would hinder future work unnecessarily.
Thanks, but wouldn't the attached patch be better? If I understand you
correctly, we can simply ignore pcre2_jit_compile failure as th
The original code was done in a way that would be useful during
porting, but that would hinder future work unnecessarily.
Carlo
0001-pcre-correct-overpessimistic-error-checking-of-pcre2.patch
Description: Binary data