bug#43527: [PATCH] grep: avoid unneeded compilation of regex

2020-09-26 Thread Norihiro Tanaka
On Sat, 26 Sep 2020 18:12:37 -0700 Paul Eggert wrote: > The patch should be harmless (though this fact isn't trivial) and I can > see it being useful for plausible future performance improvements, so it > would make sense to install it after the next release. No longer need the patch. This bu

bug#43527: [PATCH] grep: avoid unneeded compilation of regex

2020-09-26 Thread Paul Eggert
On 9/26/20 1:48 PM, Jim Meyering wrote: As far as I can see, this patch is not necessary (also, I could not reproduce your abort), so I'm closing this issue. Please reopen if you can demonstrate its utility. When I looked into it last week, I did the same thing with an assert with the same res

bug#43527: [PATCH] grep: avoid unneeded compilation of regex

2020-09-26 Thread Jim Meyering
On Tue, Sep 22, 2020 at 8:04 PM Norihiro Tanaka wrote: > On Tue, 22 Sep 2020 16:25:06 -0700 > Jim Meyering wrote: > > > Oh! Good timing. I was about to make a new snapshot. > > Do you happen to have a test case handy that demonstrates the failure? > > I added test case to previous patch. > > By t

bug#43527: [PATCH] grep: avoid unneeded compilation of regex

2020-09-23 Thread Jim Meyering
On Wed, Sep 23, 2020 at 8:16 PM Paul Eggert wrote: > On 9/23/20 8:00 PM, Jim Meyering wrote: > > Thank you, I expect to push it shortly, along with a gnulib-sync diff, > > to pull in Paul's regex fixes. > > Ouch, it looks like we had dueling commits prepared, as I read your email just > after push

bug#43527: [PATCH] grep: avoid unneeded compilation of regex

2020-09-23 Thread Paul Eggert
On 9/23/20 8:00 PM, Jim Meyering wrote: Thank you, I expect to push it shortly, along with a gnulib-sync diff, to pull in Paul's regex fixes. Ouch, it looks like we had dueling commits prepared, as I read your email just after pushing a more-extensive patch. I looked at Norihiro's recent "g

bug#43527: [PATCH] grep: avoid unneeded compilation of regex

2020-09-23 Thread Jim Meyering
On Tue, Sep 22, 2020 at 8:04 PM Norihiro Tanaka wrote: > On Tue, 22 Sep 2020 16:25:06 -0700 > Jim Meyering wrote: > > > Oh! Good timing. I was about to make a new snapshot. > > Do you happen to have a test case handy that demonstrates the failure? > > I added test case to previous patch. Thank y

bug#43527: [PATCH] grep: avoid unneeded compilation of regex

2020-09-22 Thread Norihiro Tanaka
On Tue, 22 Sep 2020 16:25:06 -0700 Jim Meyering wrote: > Oh! Good timing. I was about to make a new snapshot. > Do you happen to have a test case handy that demonstrates the failure? I added test case to previous patch. By the way, I found the following bug in making the test case, and it's st

bug#43527: [PATCH] grep: avoid unneeded compilation of regex

2020-09-22 Thread Jim Meyering
On Tue, Sep 22, 2020 at 3:57 PM Norihiro Tanaka wrote: > On Tue, 22 Sep 2020 08:50:03 -0700 > Jim Meyering wrote: > > > On Tue, Sep 22, 2020 at 7:54 AM Norihiro Tanaka wrote: > > > On Mon, 21 Sep 2020 17:33:25 -0700 > > > Jim Meyering wrote: > > ... > > > > Here are the two patches (tested on t

bug#43527: [PATCH] grep: avoid unneeded compilation of regex

2020-09-22 Thread Norihiro Tanaka
On Tue, 22 Sep 2020 08:50:03 -0700 Jim Meyering wrote: > On Tue, Sep 22, 2020 at 7:54 AM Norihiro Tanaka wrote: > > On Mon, 21 Sep 2020 17:33:25 -0700 > > Jim Meyering wrote: > ... > > > Here are the two patches (tested on top of a third that updates to > > > latest gnulib). I'll await an 'ok'

bug#43527: [PATCH] grep: avoid unneeded compilation of regex

2020-09-22 Thread Jim Meyering
On Tue, Sep 22, 2020 at 7:54 AM Norihiro Tanaka wrote: > On Mon, 21 Sep 2020 17:33:25 -0700 > Jim Meyering wrote: ... > > Here are the two patches (tested on top of a third that updates to > > latest gnulib). I'll await an 'ok' from Norihiro Tanaka before > > pushing, since commit-log metadata is

bug#43527: [PATCH] grep: avoid unneeded compilation of regex

2020-09-22 Thread Norihiro Tanaka
On Mon, 21 Sep 2020 17:33:25 -0700 Jim Meyering wrote: > On Sun, Sep 20, 2020 at 6:34 PM Jim Meyering wrote: > > > > On Sun, Sep 20, 2020 at 12:17 AM Norihiro Tanaka wrote: > > > Hi, > > > Performace for as following case is fixed in bug#43040. > > > > > > $ yes 0 | head -10 | sed '$s/.

bug#43527: [PATCH] grep: avoid unneeded compilation of regex

2020-09-21 Thread Jim Meyering
On Sun, Sep 20, 2020 at 6:34 PM Jim Meyering wrote: > > On Sun, Sep 20, 2020 at 12:17 AM Norihiro Tanaka wrote: > > Hi, > > Performace for as following case is fixed in bug#43040. > > > > $ yes 0 | head -10 | sed '$s/././' >pat > > $ grep -vf pat /dev/null > > > > However, still slow and

bug#43527: [PATCH] grep: avoid unneeded compilation of regex

2020-09-20 Thread Jim Meyering
On Sun, Sep 20, 2020 at 12:17 AM Norihiro Tanaka wrote: > Hi, > Performace for as following case is fixed in bug#43040. > > $ yes 0 | head -10 | sed '$s/././' >pat > $ grep -vf pat /dev/null > > However, still slow and a lot of memory wasted for the following cases. > > $ grep -vf /usr/s

bug#43527: [PATCH] grep: avoid unneeded compilation of regex

2020-09-20 Thread Norihiro Tanaka
Hi, Performace for as following case is fixed in bug#43040. $ yes 0 | head -10 | sed '$s/././' >pat $ grep -vf pat /dev/null However, still slow and a lot of memory wasted for the following cases. $ grep -vf /usr/share/dict/linux.words /usr/share/dict/linux.words This bug is introduc