bug#24323: "regcomp.c", line 467: error: syntax error before or at: preg

2016-08-28 Thread Dennis Clarke
On 08/28/2016 07:58 PM, Paul Eggert wrote: Dennis Clarke wrote: On 08/28/2016 03:58 PM, Paul Eggert wrote: I see the problem ... Ah, that explains it. 12.4 c99 supports __restrict__ but not __restrict, Sort of what I said .. I think. For that matter are you sure about the use of "__restr

bug#24323: "regcomp.c", line 467: error: syntax error before or at: preg

2016-08-28 Thread Paul Eggert
Dennis Clarke wrote: On 08/28/2016 03:58 PM, Paul Eggert wrote: I see the problem ... Ah, that explains it. 12.4 c99 supports __restrict__ but not __restrict, Sort of what I said .. I think. For that matter are you sure about the use of "__restrict__" ? Your original bug report said 12.

bug#24323: "regcomp.c", line 467: error: syntax error before or at: preg

2016-08-28 Thread Dennis Clarke
On 08/28/2016 03:58 PM, Paul Eggert wrote: I see the problem ... Ah, that explains it. 12.4 c99 supports __restrict__ but not __restrict, Sort of what I said .. I think. For that matter are you sure about the use of "__restrict__" ? This Gnulib commit replaces __restrict with _Restrict_

bug#24323: "regcomp.c", line 467: error: syntax error before or at: preg

2016-08-28 Thread Paul Eggert
I see the problem: the grep 2.25 tarball contains a regression from Gnulib that breaks compilation on some non-GCC compilers. Details below. Dennis Clarke wrote: it has Oracle Studio 12.4 on it. Ah, that explains it. 12.4 c99 supports __restrict__ but not __restrict, and this runs afoul of

bug#24323: "regcomp.c", line 467: error: syntax error before or at: preg

2016-08-28 Thread Dennis Clarke
On 08/28/2016 04:45 AM, Paul Eggert wrote: Dennis Clarke wrote: Coffee number two. Digging through the Changelog and looking at things like http://debbugs.gnu.org/cgi/bugreport.cgi?bug=16911#24 I see the problems run deeper. This rabbit hole just goes on and on. I am happy with the change

bug#24323: "regcomp.c", line 467: error: syntax error before or at: preg

2016-08-28 Thread Dennis Clarke
POSIX requires a 'restrict' here; see . (Whether a compiler takes advantage of 'restrict' is not something under our control) Maybe the first coffee has not hit yet but why is there a redefined "int regcomp" function

bug#24323: "regcomp.c", line 467: error: syntax error before or at: preg

2016-08-28 Thread Dennis Clarke
On 08/28/2016 04:45 AM, Paul Eggert wrote: Dennis Clarke wrote: lib/regcomp.c will not compile with C99 strict compiler because of the usage of the non-standard "__restrict". Thanks for the bug report. What are the diagnostics? I didn't get to see much other than this : CC regex.o

bug#24323: "regcomp.c", line 467: error: syntax error before or at: preg

2016-08-28 Thread Paul Eggert
Dennis Clarke wrote: lib/regcomp.c will not compile with C99 strict compiler because of the usage of the non-standard "__restrict". Thanks for the bug report. What are the diagnostics? I compiled and tested 2.25 both with and without the "restrict" and there was no measurable difference. P

bug#24323: "regcomp.c", line 467: error: syntax error before or at: preg

2016-08-27 Thread Dennis Clarke
lib/regcomp.c will not compile with C99 strict compiler because of the usage of the non-standard "__restrict". I question the use here of the "restrict" for the purpose of optimization so I compiled and tested 2.25 both with and without the "restrict" and there was no measurable difference. The