Paul Eggert wrote:
> Perhaps we can improve the behavior of grep by changing its heuristic
> slightly.
> Currently grep reports "Binary file FOO matches" if it finds binary
> data in FOO before it finds the first match. Instead, perhaps we
> could change grep to report "Binary file FOO match
Eric Blake wrote:
I'm still a bit worried that encoding errors encountered on input, even
though they don't match for output, may still cause issues for some
patterns (we've had cases of encoding errors causing 'grep -P' to go
into an infinite loop, for example);
Yes, that's right. We can't go
On 05/12/2015 02:41 AM, Kamil Dudka wrote:
> On Monday 11 May 2015 21:27:35 Paul Eggert wrote:
>> Perhaps we can improve the behavior of grep by changing its heuristic
>> slightly. Currently grep reports "Binary file FOO matches" if it finds
>> binary data in FOO before it finds the first match. I
On Monday 11 May 2015 21:27:35 Paul Eggert wrote:
> Perhaps we can improve the behavior of grep by changing its heuristic
> slightly. Currently grep reports "Binary file FOO matches" if it finds
> binary data in FOO before it finds the first match. Instead, perhaps we
> could change grep to report
Kamil Dudka wrote:
Which bug does it fix?
I don't recall a bug report being filed for it, but the old grep behavior had
real problems: as I remember at times it dumped core, and at other times it spit
out improperly encoded data to the terminal. We've fixed the core dumps I know
about, thou
On Thursday 07 May 2015 13:11:49 Eric Blake wrote:
> On 05/07/2015 11:47 AM, Sebastian Pöhn wrote:
> > Thanks for this fast feedback. Your explanation sounds very reasonable. As
> > you may have noticed this a makefile out of openwrt with is mainlined
> > there.
> >
> > 1) I downgraded to grep 2.2
Sebastian Poehn wrote:
They changed all Makefiles not being ASCII
to UTF-8 three months ago as they run into exactly this.
Hah! Great minds think alike.
But they missed a few files (not Makefiles). The following shell command finds
every openwrt file that's not UTF-8 (and isn't obviously bi
On Thu, 2015-05-07 at 13:07 -0700, Paul Eggert wrote:
> On 05/07/2015 10:47 AM, Sebastian Pöhn wrote:
> >
> > Thanks for this fast feedback. Your explanation sounds very
> > reasonable. As you may have noticed this a makefile out of openwrt
> > with is mainlined there.
> >
> > 1) I downgraded to
Hello,
only an addendum FYI:
On May 7 09:23 Paul Eggert wrote (excerpt):
That file uses ISO 8859 encoding (presumably Latin-1 or Latin-9),
so you need to grep it in a locale compatible with that encoding.
For some general information about that kind of issue have a look at
https://en.opensus
On 05/07/2015 10:47 AM, Sebastian Pöhn wrote:
Thanks for this fast feedback. Your explanation sounds very
reasonable. As you may have noticed this a makefile out of openwrt
with is mainlined there.
1) I downgraded to grep 2.20. Issue is gone with the same environment.
So this is in my eyes
On 05/07/2015 11:47 AM, Sebastian Pöhn wrote:
> Thanks for this fast feedback. Your explanation sounds very reasonable. As
> you may have noticed this a makefile out of openwrt with is mainlined there.
>
> 1) I downgraded to grep 2.20. Issue is gone with the same environment. So
> this is in my ey
Thanks for this fast feedback. Your explanation sounds very reasonable. As
you may have noticed this a makefile out of openwrt with is mainlined there.
1) I downgraded to grep 2.20. Issue is gone with the same environment. So
this is in my eyes a regression.
2) I will also open a report at fedora
That file uses ISO 8859 encoding (presumably Latin-1 or Latin-9), so you
need to grep it in a locale compatible with that encoding. It appears
that you ran grep in a UTF-8 or other incompatible locale, which meant
the ISO 8859 encoding wasn't valid and was treated as binary gibberish.
You cou
Fedora 21
grep (GNU grep) 2.21
Grep detects text file as Binary. File is attached.
file Makefile
Makefile: ISO-8859 text
ack PKG_NAME
Makefile
10:PKG_NAME:=clearsilver
14:PKG_SOURCE:=$(PKG_NAME)-$(PKG_VERSION).tar.gz
grep --version ; grep "PKG_NAME" Makefile
grep (GNU grep) 2.7
...
PKG_NAME:=c
14 matches
Mail list logo
