bug#19173: [PATCH] dfa: speed-up for long pattern

2015-07-18 Thread Jim Meyering
On Sat, Jul 4, 2015 at 8:40 PM, Jim Meyering wrote: > On Mon, Nov 24, 2014 at 5:15 PM, Norihiro Tanaka wrote: ... > Thank you for that patch. > I have rebased it and made some small improvements: > I combined an if+do loop into a single for-loop and moved > some declarations "down". I constructed

bug#19173: [PATCH] dfa: speed-up for long pattern

2015-07-05 Thread Jim Meyering
On Sat, Jul 4, 2015 at 11:18 PM, wrote: > Jim Meyering wrote: > >> and moved >> some declarations "down". > > Can we keep delcarations C89 style please? Gawk still supports > some environments that don't allow declarations in the middle > of executable code. For coreutils, in 2006 I began main

bug#19173: [PATCH] dfa: speed-up for long pattern

2015-07-05 Thread Norihiro Tanaka
On Sat, 4 Jul 2015 20:40:05 -0700 Jim Meyering wrote: > I have rebased it and made some small improvements: > I combined an if+do loop into a single for-loop Thanks for review and improvements. Although, I do not remember why I wrote that code, I see that your change is right. And also change

bug#19173: [PATCH] dfa: speed-up for long pattern

2015-07-04 Thread arnold
Jim Meyering wrote: > and moved > some declarations "down". Can we keep delcarations C89 style please? Gawk still supports some environments that don't allow declarations in the middle of executable code. Thanks, Arnold

bug#19173: [PATCH] dfa: speed-up for long pattern

2015-07-04 Thread Jim Meyering
On Mon, Nov 24, 2014 at 5:15 PM, Norihiro Tanaka wrote: > DFA trys to find a long sequence of characters that must appear in any > line containing the r.e. in dfamust() However, if a pattern is long, it > is very slow, as it processes all characters step by step. This change > makes a string con

bug#19173: [PATCH] dfa: speed-up for long pattern

2014-11-24 Thread Norihiro Tanaka
DFA trys to find a long sequence of characters that must appear in any line containing the r.e. in dfamust() However, if a pattern is long, it is very slow, as it processes all characters step by step. This change makes a string concatenated some normal characters process at a time. Following te